Uh oh!
There was an error while loading. Please reload this page.
Spark: Add support for Spark 4.1 - #14155
Conversation
f506107 to
7c1ebb6CompareCreated apache/spark#52423 at Spark side to fix failed tests for Spark 4.1.0-preview1. |
…ith null DataType ### What changes were proposed in this pull request? Check whether the parameter DataType is null in ColumnVector constructor before transforming it ### Why are the changes needed? A subclass of ColumnVector, e.g. Iceberg's [ConstantColumnVector](https://github.com/apache/iceberg/blob/main/spark/v4.0/spark/src/main/java/org/apache/iceberg/spark/data/vectorized/ConstantColumnVector.java#L41), could be created with null `DataType`. It throws NPE after #51349, which can be verified by failed tests in [integrating Spark 4.1.0-preview1 in Iceberg](apache/iceberg#14155) ### Does this PR introduce _any_ user-facing change? No. ### How was this patch tested? UT. ### Was this patch authored or co-authored using generative AI tooling? No. Closes#52423 from manuzhang/SPARK-53678. Authored-by: manuzhang <owenzhang1990@gmail.com> Signed-off-by: Dongjoon Hyun <dongjoon@apache.org>
7df730b to
030d9e8Comparecac12c7 to
ad82343Comparead82343 to
5020976Comparec3f856b to
13d315bCompare13d315b to
22d51beCompare0e2436b to
612a72aCompare| qualifyTableIdentifiers( | ||
| qualifyFunctionIdentifiers( | ||
| SubstituteUnresolvedOrdinals.apply(CTESubstitution.apply(plan)), | ||
| CTESubstitution.apply(plan), |
There was a problem hiding this comment.
SubstituteUnresolvedOrdinals removed and not needed after apache/spark#50606
Uh oh!
There was an error while loading. Please reload this page.
4f994d6 to
e24f002Compare11a7ba2 to
6ef2c11Compare6ef2c11 to
d2468a1Compareraphaelauv
commented
Dec 17, 2025
will it be part of iceberg 1.10.1 ? ( since spark 4.1.0 was release today ) thanks |
nastra
commented
Dec 17, 2025
No this won't be part of 1.10.1 since 1.10.1 is a patch release |
pan3793
commented
Dec 19, 2025
Spark 4.1.0 jars are available in Maven Central, do you guys have a plan to move this forward? |
manuzhang
commented
Dec 19, 2025
@pan3793 Since Spark 4.1.0 has known issues and Spark 4.1.1 will be released soon, we can wait for 4.1.1 RC and test again. |
@manuzhang, what about getting this in now? Can you update the PR to include any changes that went in while it was open? The only open question I had was related to MERGE behavior but we are reconsidering that in 4.1.1, so we will test it separately. |
aokolnychyi
commented
Dec 22, 2025
By the way, thanks for working on this, @manuzhang. I know it is tiring to keep updating such PRs. |
Let's just update to the official 4.1.0, not RC. Forgot to ask. |
d2468a1 to
3b52e92Compareaokolnychyi
commented
Dec 23, 2025
Double checked the last commit, looking good. Waiting for the tests. |
Uh oh!
There was an error while loading. Please reload this page.
aokolnychyi
commented
Dec 23, 2025
Thanks, @manuzhang@pan3793! |
pan3793
commented
Dec 23, 2025
Great, thanks for @manuzhang's work and @aokolnychyi's merging! |
No description provided.