Skip to content

Core: Fixed the unpartitioned check in replace partitions #14186

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
singhpk234 merged 5 commits into from
Sep 30, 2025
Merged

Core: Fixed the unpartitioned check in replace partitions #14186

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
9748742
Fixed the unpartitioned check in replace partitions
yuboxx Sep 25, 2025
0a71ee6
added new unit test
yuboxx Sep 26, 2025
558fda9
fixed the spotless check
yuboxx Sep 26, 2025
bd03705
addressed pr comments
yuboxx Sep 27, 2025
eb977e0
applied spotless check fix
yuboxx Sep 27, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion core/src/main/java/org/apache/iceberg/BaseReplacePartitions.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -111,7 +111,7 @@ public void validate(TableMetadata currentMetadata, Snapshot parent) {

@Override
public List<ManifestFile> apply(TableMetadata base, Snapshot snapshot) {
if (dataSpec().fields().isEmpty()) {
if (dataSpec().isUnpartitioned()) {
// replace all data in an unpartitioned table
deleteByRowFilter(Expressions.alwaysTrue());
}
Expand Down
53 changes: 53 additions & 0 deletions core/src/test/java/org/apache/iceberg/TestReplacePartitions.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -102,6 +102,23 @@ public class TestReplacePartitions extends TestBase {
.withRecordCount(1)
.build();

static final PartitionSpec SPEC_ALL_VOID =
PartitionSpec.builderFor(SCHEMA).alwaysNull("id").alwaysNull("data").build();

static final DataFile FILE_ALL_VOID_UNPARTITIONED_A =
DataFiles.builder(SPEC_ALL_VOID)
.withPath("/path/to/data-all-void-unpartitioned-a.parquet")
.withFileSizeInBytes(10)
.withRecordCount(1)
.build();

static final DataFile FILE_ALL_VOID_UNPARTITIONED_B =
DataFiles.builder(SPEC_ALL_VOID)
.withPath("/path/to/data-all-void-unpartitioned-b.parquet")
.withFileSizeInBytes(10)
.withRecordCount(1)
.build();

@Parameter(index = 1)
private String branch;

Expand Down Expand Up @@ -198,6 +215,42 @@ public void testReplaceWithUnpartitionedTable() throws IOException {
statuses(Status.DELETED));
}

@TestTemplate
public void testReplaceAllVoidUnpartitionedTable() {
Table tableVoid =
TestTables.create(tableDir, "allvoidUnpartitioned", SCHEMA, SPEC_ALL_VOID, formatVersion);

commit(tableVoid, tableVoid.newAppend().appendFile(FILE_ALL_VOID_UNPARTITIONED_A), branch);
validateSnapshot(
null,
latestSnapshot(TestTables.readMetadata("allvoidUnpartitioned"), branch),
FILE_ALL_VOID_UNPARTITIONED_A);

ReplacePartitions replacePartitions =
tableVoid.newReplacePartitions().addFile(FILE_ALL_VOID_UNPARTITIONED_B);
commit(tableVoid, replacePartitions, branch);

assertThat(TestTables.metadataVersion("allvoidUnpartitioned")).isEqualTo(2);
TableMetadata replaceMetadata = TestTables.readMetadata("allvoidUnpartitioned");
long replaceId = latestSnapshot(replaceMetadata, branch).snapshotId();
List<ManifestFile> manifestFiles =
latestSnapshot(replaceMetadata, branch).allManifests(tableVoid.io());

assertThat(manifestFiles).hasSize(2);

validateManifestEntries(
manifestFiles.get(0),
ids(replaceId),
files(FILE_ALL_VOID_UNPARTITIONED_B),
statuses(Status.ADDED));

validateManifestEntries(
manifestFiles.get(1),
ids(replaceId),
files(FILE_ALL_VOID_UNPARTITIONED_A),
statuses(Status.DELETED));
}

@TestTemplate
public void testReplaceAndMergeWithUnpartitionedTable() throws IOException {
Table unpartitioned =
Expand Down