Skip to content

Core, Orc: Remove deprecated partition stats read functionality - #14998

Merged
pvary merged 1 commit into
apache:mainfrom
gaborkaszab:main_remove_deprecated_partition_stat_read
May 22, 2026
Merged

Core, Orc: Remove deprecated partition stats read functionality#14998
pvary merged 1 commit into
apache:mainfrom
gaborkaszab:main_remove_deprecated_partition_stat_read

Conversation

@gaborkaszab

Copy link
Copy Markdown
Contributor

In 1.12.0 we can remove the deprecated read functionality for partition stats

@gaborkaszab
gaborkaszabforce-pushed the main_remove_deprecated_partition_stat_read branch from 0754269 to b3de566CompareJanuary 13, 2026 14:00
@gaborkaszabgaborkaszab changed the title Core, Orc: Remove deptecated partition stats read functionalityCore, Orc: Remove deprecated partition stats read functionalityJan 14, 2026
@gaborkaszab
gaborkaszabforce-pushed the main_remove_deprecated_partition_stat_read branch from b3de566 to 83d9fe9CompareFebruary 2, 2026 13:32
testTable.updatePartitionStatistics().setPartitionStatistics(result).commit();
assertThat(result.snapshotId()).isEqualTo(currentSnapshot.snapshotId());
@Test
public void testAppendWithBothNullOptionalFields() {

Copy link
Copy Markdown
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These tests are from the removed PartitionStats to keep coverage

@gaborkaszab
gaborkaszabforce-pushed the main_remove_deprecated_partition_stat_read branch from 83d9fe9 to 3511127CompareFebruary 2, 2026 13:57
@github-actions

Copy link
Copy Markdown

This pull request has been marked as stale due to 30 days of inactivity. It will be closed in 1 week if no further activity occurs. If you think that’s incorrect or this pull request requires a review, please simply write any comment. If closed, you can revive the PR at any time and @mention a reviewer or discuss it on the dev@iceberg.apache.org list. Thank you for your contributions.

@github-actions

Copy link
Copy Markdown

This pull request has been closed due to lack of activity. This is not a judgement on the merit of the PR in any way. It is just a way of keeping the PR queue manageable. If you think that is incorrect, or the pull request requires review, you can revive the PR at any time.

@pvarypvary reopened this Mar 13, 2026
@github-actions

Copy link
Copy Markdown

This pull request has been marked as stale due to 30 days of inactivity. It will be closed in 1 week if no further activity occurs. If you think that’s incorrect or this pull request requires a review, please simply write any comment. If closed, you can revive the PR at any time and @mention a reviewer or discuss it on the dev@iceberg.apache.org list. Thank you for your contributions.

@gaborkaszab
gaborkaszabforce-pushed the main_remove_deprecated_partition_stat_read branch from 3511127 to 0b9a879CompareApril 14, 2026 11:53
@github-actions

Copy link
Copy Markdown

This pull request has been marked as stale due to 30 days of inactivity. It will be closed in 1 week if no further activity occurs. If you think that’s incorrect or this pull request requires a review, please simply write any comment. If closed, you can revive the PR at any time and @mention a reviewer or discuss it on the dev@iceberg.apache.org list. Thank you for your contributions.

@gaborkaszab
gaborkaszabforce-pushed the main_remove_deprecated_partition_stat_read branch 3 times, most recently from 55e9a7f to eda2d88CompareMay 21, 2026 12:03
Comment thread.palantir/revapi.yml
@gaborkaszab
gaborkaszabforce-pushed the main_remove_deprecated_partition_stat_read branch from eda2d88 to bedc8a6CompareMay 21, 2026 14:36
@pvary
pvary merged commit f37a04b into apache:mainMay 22, 2026
69 of 70 checks passed
@pvary

Copy link
Copy Markdown
Contributor

Merged to main.
Thanks @gaborkaszab for removing the deprecated stuff!

dramaticlly added a commit to dramaticlly/iceberg that referenced this pull request Jun 25, 2026
`build.gradle` line 145 sets `oldVersion = "1.11.0"` — revapi compares
the current code against the 1.11.0 released baseline. Section keys
in `.palantir/revapi.yml` correspond to that baseline, so new
breaks accepted during the 1.12.0 dev cycle belong under `"1.11.0"`,
not under a not-yet-released `"1.12.0"` section.
Evidence in-file: the `"1.10.0"` section already contains entries with
justifications like "Removing deprecated code for 1.11.0" — entries added
during the 1.11.0 dev cycle when `oldVersion` was `"1.10.0"`. Same shape
applies now.
This commit:
- Renames the section header `"1.12.0"` -> `"1.11.0"`, merging the new
entries from PR apache#16449 into the existing 1.11.0 section that was
already on upstream/main (the partition-stats entries from PR apache#14998).
- Restores the original justifications on the 17 partition-stats entries
that were rewritten by an earlier fixup commit
(`fb5ddae9b2 Core: Move partition stats revapi entries to 1.12.0`),
back to "Removed deprecated functionality for partition stats".
- Drops a duplicate `class org.apache.iceberg.PartitionStats` entry
that the earlier fixup commit had introduced.
Net effect: the cumulative PR diff against upstream/main is now
additive only (new entries appended to the existing 1.11.0 section,
no churn on existing entries).
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
dramaticlly added a commit to dramaticlly/iceberg that referenced this pull request Jul 22, 2026
`build.gradle` line 145 sets `oldVersion = "1.11.0"` — revapi compares
the current code against the 1.11.0 released baseline. Section keys
in `.palantir/revapi.yml` correspond to that baseline, so new
breaks accepted during the 1.12.0 dev cycle belong under `"1.11.0"`,
not under a not-yet-released `"1.12.0"` section.
Evidence in-file: the `"1.10.0"` section already contains entries with
justifications like "Removing deprecated code for 1.11.0" — entries added
during the 1.11.0 dev cycle when `oldVersion` was `"1.10.0"`. Same shape
applies now.
This commit:
- Renames the section header `"1.12.0"` -> `"1.11.0"`, merging the new
entries from PR apache#16449 into the existing 1.11.0 section that was
already on upstream/main (the partition-stats entries from PR apache#14998).
- Restores the original justifications on the 17 partition-stats entries
that were rewritten by an earlier fixup commit
(`fb5ddae9b2 Core: Move partition stats revapi entries to 1.12.0`),
back to "Removed deprecated functionality for partition stats".
- Drops a duplicate `class org.apache.iceberg.PartitionStats` entry
that the earlier fixup commit had introduced.
Net effect: the cumulative PR diff against upstream/main is now
additive only (new entries appended to the existing 1.11.0 section,
no churn on existing entries).
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
dramaticlly added a commit to dramaticlly/iceberg that referenced this pull request Jul 23, 2026
`build.gradle` line 145 sets `oldVersion = "1.11.0"` — revapi compares
the current code against the 1.11.0 released baseline. Section keys
in `.palantir/revapi.yml` correspond to that baseline, so new
breaks accepted during the 1.12.0 dev cycle belong under `"1.11.0"`,
not under a not-yet-released `"1.12.0"` section.
Evidence in-file: the `"1.10.0"` section already contains entries with
justifications like "Removing deprecated code for 1.11.0" — entries added
during the 1.11.0 dev cycle when `oldVersion` was `"1.10.0"`. Same shape
applies now.
This commit:
- Renames the section header `"1.12.0"` -> `"1.11.0"`, merging the new
entries from PR apache#16449 into the existing 1.11.0 section that was
already on upstream/main (the partition-stats entries from PR apache#14998).
- Restores the original justifications on the 17 partition-stats entries
that were rewritten by an earlier fixup commit
(`fb5ddae9b2 Core: Move partition stats revapi entries to 1.12.0`),
back to "Removed deprecated functionality for partition stats".
- Drops a duplicate `class org.apache.iceberg.PartitionStats` entry
that the earlier fixup commit had introduced.
Net effect: the cumulative PR diff against upstream/main is now
additive only (new entries appended to the existing 1.11.0 section,
no churn on existing entries).
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@gaborkaszab@pvary