Uh oh!
There was an error while loading. Please reload this page.
Core, Flink, Spark: Deprecate Manifest read methods which rely manifest Metadata - #15575
Merged
RussellSpitzer merged 3 commits intoMar 11, 2026
Merged
Conversation
…st Metadata Similar to apache#15241, this deprecates the ManifestFiles methods that rely on reading partition specs from manifest file metadata. This prepares for future integrations which use the internal reader api which does not have access to the file metadata or files which do not have metadata. Specifically this is for our Parquet Manifests works in Table Spec V4 Deprecate read(ManifestFile, FileIO) in favor of read(ManifestFile, FileIO, Map) - Deprecate readPaths(ManifestFile, FileIO) in favor of readPaths(ManifestFile, FileIO, Map) - Deprecate package-private open(ManifestFile, FileIO) - Add LOG.warn when specsById is null to surface the deprecated code path - Migrate all internal callers and tests to pass specsById explicitly
RussellSpitzerforce-pushed
the
DeprecateManifestMetadata
branch
from
March 10, 2026 01:55
087ff9b to
38ea14eComparepvary
reviewed
Mar 10, 2026
Uh oh!
There was an error while loading. Please reload this page.
pvary
reviewed
Mar 10, 2026
Uh oh!
There was an error while loading. Please reload this page.
pvary
commented
Mar 10, 2026
Contributor
Do we have any place where we still test the old, deprecated methods? Shall we have at least 1 call, just to check they are working? |
MemberAuthor
I can add in a test for the old path, this pr removes all the old calls (everything was in tests I think) |
stevenzwu
approved these changes
Mar 10, 2026
stevenzwu
left a comment
Contributor
There was a problem hiding this comment.
LGTM. just a couple of nit comments
| * @param manifest a ManifestFile | ||
| * @param io a FileIO | ||
| * @return a manifest reader | ||
| * @deprecated since 1.10.0, will be removed in 1.12.0; use {@link #readPaths(ManifestFile, |
Contributor
There was a problem hiding this comment.
next release is 1.11.0. so it should be since 1.11.0
| } else { | ||
| LOG.warn( | ||
| "Reading partition spec from manifest file metadata is deprecated and will be " | ||
| + "removed in a future release. Pass specsById to avoid reading from file metadata: {}", |
Contributor
There was a problem hiding this comment.
nit: future release --> 1.12.0 release.
singhpk234
approved these changes
Mar 11, 2026
singhpk234
left a comment
Contributor
There was a problem hiding this comment.
LGTM too, thanks @RussellSpitzer !
pvary
approved these changes
Mar 11, 2026
huaxingao
approved these changes
Mar 11, 2026
Uh oh!
There was an error while loading. Please reload this page.
RussellSpitzer
commented
Mar 11, 2026
MemberAuthor
Thanks for review @pvary@singhpk234@stevenzwu and @huaxingao ! Merged |
RjLi13 pushed a commit
to RjLi13/iceberg
that referenced
this pull request
Mar 12, 2026
This was referenced Mar 12, 2026
talatuyarer pushed a commit
to talatuyarer/iceberg
that referenced
this pull request
Apr 1, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Similar to #15241, this deprecates the ManifestFiles methods that rely on reading partition specs from manifest file metadata.
This prepares for future integrations which use the internal reader api which does not have access to the file metadata or files which do not have metadata. Specifically this is for our Parquet Manifests works in Table Spec V4
Deprecate read(ManifestFile, FileIO) in favor of read(ManifestFile, FileIO, Map)
Coded with Cursor - Claude-4.6-opus-high