Skip to content

MR: Fix NPE when InputSplit.getLocations is called on mappers #1582

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
rdblue merged 2 commits into from
Oct 13, 2020
Merged

MR: Fix NPE when InputSplit.getLocations is called on mappers #1582

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
29ffa71
MR: Fix NPE when InputSplit.getLocations is called on mappers
shardulm94 Oct 11, 2020
86a92d6
Add comment
shardulm94 Oct 13, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion mr/src/main/java/org/apache/iceberg/mr/mapreduce/IcebergSplit.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -74,9 +74,13 @@ public long getLength() {

@Override
public String[] getLocations() {
if (locations == null) {
// The implementation of getLocations() is only meant to be used during split computation
// getLocations() won't be accurate when called on worker nodes and will always return "*"
if (locations == null && conf != null) {

@rdsr rdsr Oct 11, 2020 •
edited
Loading

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think a comment can help here saying implementation of getLocations is only meant to be used during splits computation. getLocations won't be accurate when called on worker nodes

@shardulm94 shardulm94 Oct 13, 2020

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

boolean localityPreferred = conf.getBoolean(InputFormatConfig.LOCALITY, false);
locations = localityPreferred ? Util.blockLocations(task, conf) : ANYWHERE;
} else {
locations = ANYWHERE;
}

return locations;
Expand Down