Uh oh!
There was an error while loading. Please reload this page.
Core: Relative paths for data files - #16666
Conversation
6d8252b to
9e4a69bCompare1e16f03 to
4484754Compare4484754 to
43b5eebComparerambleraptor
commented
Jun 3, 2026
@talatuyarer@danielcweeks as the relative paths gurus, please take a look! @anoopj I know you've been doing work in the space as well |
| this.manifestLocation = manifestLocation; | ||
| } | ||
| void setLocation(String location) { |
There was a problem hiding this comment.
This is an open design question, but I think BaseFile is probably not the correct place to inject the location since we want to isolate this to v4-only code paths. Most likely, we will do the path resolution/relativization in the v4-only adapter layer, as done in this prototype.
| file.setFileSequenceNumber(manifestEntry.fileSequenceNumber()); | ||
| file.setManifestLocation(manifestLocation); | ||
| if (baseLocation != null && file.path() != null) { | ||
| file.setLocation(LocationUtil.resolveLocation(baseLocation, file.location())); |
There was a problem hiding this comment.
I'm not certain, but I suspect this might cause manifest rewrite paths to always persist the absolute location. (Appends paths would be fine). I guess the tests are probably passing because the v3 paths are always absolute.
This pull request has been marked as stale due to 30 days of inactivity. It will be closed in 1 week if no further activity occurs. If you think that’s incorrect or this pull request requires a review, please simply write any comment. If closed, you can revive the PR at any time and @mention a reviewer or discuss it on the dev@iceberg.apache.org list. Thank you for your contributions. |
This pull request has been marked as stale due to 30 days of inactivity. It will be closed in 1 week if no further activity occurs. If you think that’s incorrect or this pull request requires a review, please simply write any comment. If closed, you can revive the PR at any time and @mention a reviewer or discuss it on the dev@iceberg.apache.org list. Thank you for your contributions. |
anoopj
commented
Aug 17, 2026
#17434 handles it at the v4 reader. |
rambleraptor
commented
Aug 18, 2026
Great, I'll close this out. Thanks for the work on the v4 reader! |
This adds support for reading data files using relative paths.
We've had some issues in the prior PR where a bunch of files have scheme-less "absolute" paths. By Iceberg's definition of absolute, those need schemes. I fixed the ones we ran into.