Skip to content

Core: Add all manifests over-pruning test #17714

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
yangshangqing95 wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Core: Add all manifests over-pruning test #17714

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 19 additions & 0 deletions core/src/test/java/org/apache/iceberg/TestMetadataTableScans.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -509,6 +509,25 @@ public void allManifestsTablePreservesSnapshotPruningWhenIgnoringResiduals() thr
validateTaskScanResiduals(scan, true);
}

@TestTemplate
public void allManifestsTableDoesNotOverPruneWhenIgnoringResiduals() throws IOException {
// Snapshots 1,2,3,4
preparePartitionedTableData();

Table allManifestsTable = new AllManifestsTable(table);
TableScan scan =
allManifestsTable
.newScan()
.filter(Expressions.equal("content", ManifestContent.DELETES.id()))
.ignoreResiduals();

assertThat(scannedPaths(scan))
.as("A non-snapshot filter must not prune snapshots when residuals are ignored")
.isEqualTo(expectedManifestListPaths(table.snapshots(), 1L, 2L, 3L, 4L));

validateTaskScanResiduals(scan, true);
}

@TestTemplate
public void allManifestsTableNegatedPredicateOnNonSnapshotColumn() {
// Snapshots 1,2,3,4
Expand Down
Loading