Uh oh!
There was an error while loading. Please reload this page.
Core: Remove ThreadPools.WORKER_THREAD_POOL_SIZE_PROP update warning log message - #17812
Merged
Merged
Conversation
…ifest spec fallback removal version Resolves the two remaining deprecation markers in iceberg-core that promised action "in 1.12.0" but were missed by the removal PRs. Remove ThreadPools.WORKER_THREAD_POOL_SIZE_PROP. The field was deprecated in apache#5659 in favor of SystemConfigs.WORKER_THREAD_POOL_SIZE and retargeted from 2.0.0 to 1.12.0 by apache#14392. It had no callers anywhere in the repository outside its own declaration and no references in the docs, and it was the only survivor of apache#14392's 13-file batch after apache#17700 removed the rest. The corresponding java.field.removed break is recorded in .palantir/revapi.yml under the 1.11.0 baseline. Correct the ManifestReader warning for the partition-spec-from-file- metadata fallback to say 2.0.0 rather than 1.12.0. The fallback cannot be honored in 1.12.0 because its only production caller is BaseSnapshot:276, which passes a null spec map while serving Snapshot.addedDeleteFiles(FileIO) and removedDeleteFiles(FileIO). Those accessors are themselves already marked "@deprecated will be removed in 2.0.0; use SnapshotChanges#builderFor(Table) instead", and because they receive only a FileIO they structurally cannot supply a spec map. The fallback must therefore outlive 1.12.0, and 2.0.0 aligns its removal with that of its last caller.
dramaticlly
commented
Aug 25, 2026
| LOG.warn( | ||
| "Reading partition spec from manifest file metadata is deprecated and will be " | ||
| + "removed in the 1.12.0 release. Pass specsById to avoid reading from file metadata: {}", | ||
| + "removed in the 2.0.0 release. Pass specsById to avoid reading from file metadata: {}", |
ContributorAuthor
There was a problem hiding this comment.
@RussellSpitzer I updated the warning log message to 2.0 as today
still pass a null specById. Given class of baseSnapshot does not have a way to access specById directly from table metadata, it will continue to use the fallback.Contributor
There was a problem hiding this comment.
This is not directly related to prop removal i think, when merging this lets make sure we add the commit description accordingly !
dramaticlly
commented
Aug 25, 2026
ContributorAuthor
@huaxingao if you can help take a look at this one as well |
dramaticlly
commented
Aug 27, 2026
ContributorAuthor
thanks @huaxingao and @uros-b for the review, shall we merge it if it's ready? |
dramaticlly
commented
Aug 27, 2026
ContributorAuthor
I think this is the last piece needed to close #16445 |
singhpk234
approved these changes
Aug 28, 2026
Uh oh!
There was an error while loading. Please reload this page.
nssalian
approved these changes
Aug 31, 2026
Uh oh!
There was an error while loading. Please reload this page.
huaxingao
commented
Sep 1, 2026
Contributor
Thanks @dramaticlly for the PR! Thanks everyone for the review! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
2 changes
Remove ThreadPools.WORKER_THREAD_POOL_SIZE_PROP. The field was deprecated in Core: Support set system level properties with environmental variables #5659
Update the ManifestReader warning log for reading specById fallback from 1.12.0 to 2.0.0.
fallback cannot be honored in 1.12.0 because
iceberg/core/src/main/java/org/apache/iceberg/BaseSnapshot.java
Line 276 in b1c6cf8