Skip to content

Core, Data, Spark, Flink: Defer removal of position deletes with row data to 1.13.0 #17813

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
dramaticlly wants to merge 1 commit into from
Closed

Core, Data, Spark, Flink: Defer removal of position deletes with row data to 1.13.0 #17813

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion core/src/main/java/org/apache/iceberg/RewriteTablePathUtil.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -690,7 +690,7 @@ default PositionDeleteWriter<Record> writer(
}

/**
* @deprecated This method is deprecated as of version 1.11.0 and will be removed in 1.12.0.
* @deprecated This method is deprecated as of version 1.11.0 and will be removed in 1.13.0.
* Position deletes that include row data are no longer supported. Use {@link
* #writer(OutputFile, FileFormat, PartitionSpec, StructLike)} instead.
*/
Expand Down
4 changes: 2 additions & 2 deletions core/src/main/java/org/apache/iceberg/deletes/PositionDelete.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,7 +44,7 @@ public PositionDelete<R> set(CharSequence newPath, long newPos) {
}

/**
* @deprecated This method is deprecated as of version 1.11.0 and will be removed in 1.12.0.
* @deprecated This method is deprecated as of version 1.11.0 and will be removed in 1.13.0.
* Position deletes that include row data are no longer supported. Use {@link
* #set(CharSequence, long)} instead.
*/
Expand All @@ -70,7 +70,7 @@ public long pos() {
}

/**
* @deprecated This method is deprecated as of version 1.11.0 and will be removed in 1.12.0.
* @deprecated This method is deprecated as of version 1.11.0 and will be removed in 1.13.0.
* Position deletes that include row data are no longer supported.
*/
@Deprecated
Expand Down
2 changes: 1 addition & 1 deletion core/src/main/java/org/apache/iceberg/deletes/PositionDeleteWriter.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -63,7 +63,7 @@ public class PositionDeleteWriter<T> implements FileWriter<PositionDelete<T>, De
/**
* Creates a new position delete writer.
*
* @deprecated since 1.11.0, will be updated in 1.12.0 to accept {@code
* @deprecated since 1.11.0, will be updated in 1.13.0 to accept {@code
* FileAppender<PositionDelete<T>>} instead of {@code FileAppender<? extends StructLike>}.
*/
@Deprecated
Expand Down
4 changes: 4 additions & 0 deletions core/src/main/java/org/apache/iceberg/io/PositionDeltaWriter.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -77,7 +77,11 @@ default void delete(CharSequence path, long pos, PartitionSpec spec, StructLike
* @param row a deleted row
* @param spec a partition spec
* @param partition a partition or null if the spec is unpartitioned
* @deprecated since 1.12.0, will be removed in 1.13.0; position deletes that include row data are
* no longer supported. Use {@link #delete(CharSequence, long, PartitionSpec, StructLike)}
* instead, which will become the method implementations override.
*/
@Deprecated
void delete(CharSequence path, long pos, T row, PartitionSpec spec, StructLike partition);

/**
Expand Down
24 changes: 12 additions & 12 deletions data/src/main/java/org/apache/iceberg/data/GenericFileWriterFactory.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -79,7 +79,7 @@ public class GenericFileWriterFactory extends RegistryBasedFileWriterFactory<Rec
}

/**
* @deprecated This constructor is deprecated as of version 1.11.0 and will be removed in 1.12.0.
* @deprecated This constructor is deprecated as of version 1.11.0 and will be removed in 1.13.0.
* Position deletes that include row data are no longer supported. Use {@link
* #GenericFileWriterFactory(Table, FileFormat, Schema, SortOrder, FileFormat, int[], Schema,
* SortOrder)} instead.
Expand Down Expand Up @@ -116,7 +116,7 @@ public class GenericFileWriterFactory extends RegistryBasedFileWriterFactory<Rec
}

/**
* @deprecated as of 1.11.0; it will be removed in 1.12.0
* @deprecated as of 1.11.0; it will be removed in 1.13.0
*/
@Deprecated
GenericFileWriterFactory(
Expand Down Expand Up @@ -152,7 +152,7 @@ static Builder builderFor(Table table) {
}

/**
* @deprecated Since 1.11.0, will be removed in 1.12.0. It won't be called starting in 1.11.0 as
* @deprecated Since 1.11.0, will be removed in 1.13.0. It won't be called starting in 1.11.0 as
* the configuration is done by the {@link FormatModelRegistry}.
*/
@Deprecated
Expand All @@ -161,7 +161,7 @@ protected void configureDataWrite(Avro.DataWriteBuilder builder) {
}

/**
* @deprecated Since 1.11.0, will be removed in 1.12.0. It won't be called starting in 1.11.0 as
* @deprecated Since 1.11.0, will be removed in 1.13.0. It won't be called starting in 1.11.0 as
* the configuration is done by the {@link FormatModelRegistry}.
*/
@Deprecated
Expand All @@ -170,7 +170,7 @@ protected void configureEqualityDelete(Avro.DeleteWriteBuilder builder) {
}

/**
* @deprecated Since 1.11.0, will be removed in 1.12.0. It won't be called starting in 1.11.0 as
* @deprecated Since 1.11.0, will be removed in 1.13.0. It won't be called starting in 1.11.0 as
* the configuration is done by the {@link FormatModelRegistry}.
*/
@Deprecated
Expand All @@ -179,7 +179,7 @@ protected void configurePositionDelete(Avro.DeleteWriteBuilder builder) {
}

/**
* @deprecated Since 1.11.0, will be removed in 1.12.0. It won't be called starting in 1.11.0 as
* @deprecated Since 1.11.0, will be removed in 1.13.0. It won't be called starting in 1.11.0 as
* the configuration is done by the {@link FormatModelRegistry}.
*/
@Deprecated
Expand All @@ -188,7 +188,7 @@ protected void configureDataWrite(Parquet.DataWriteBuilder builder) {
}

/**
* @deprecated Since 1.11.0, will be removed in 1.12.0. It won't be called starting in 1.11.0 as
* @deprecated Since 1.11.0, will be removed in 1.13.0. It won't be called starting in 1.11.0 as
* the configuration is done by the {@link FormatModelRegistry}.
*/
@Deprecated
Expand All @@ -197,7 +197,7 @@ protected void configureEqualityDelete(Parquet.DeleteWriteBuilder builder) {
}

/**
* @deprecated Since 1.11.0, will be removed in 1.12.0. It won't be called starting in 1.11.0 as
* @deprecated Since 1.11.0, will be removed in 1.13.0. It won't be called starting in 1.11.0 as
* the configuration is done by the {@link FormatModelRegistry}.
*/
@Deprecated
Expand All @@ -206,7 +206,7 @@ protected void configurePositionDelete(Parquet.DeleteWriteBuilder builder) {
}

/**
* @deprecated Since 1.11.0, will be removed in 1.12.0. It won't be called starting in 1.11.0 as
* @deprecated Since 1.11.0, will be removed in 1.13.0. It won't be called starting in 1.11.0 as
* the configuration is done by the {@link FormatModelRegistry}.
*/
@Deprecated
Expand All @@ -215,7 +215,7 @@ protected void configureDataWrite(ORC.DataWriteBuilder builder) {
}

/**
* @deprecated Since 1.11.0, will be removed in 1.12.0. It won't be called starting in 1.11.0 as
* @deprecated Since 1.11.0, will be removed in 1.13.0. It won't be called starting in 1.11.0 as
* the configuration is done by the {@link FormatModelRegistry}.
*/
@Deprecated
Expand All @@ -224,7 +224,7 @@ protected void configureEqualityDelete(ORC.DeleteWriteBuilder builder) {
}

/**
* @deprecated Since 1.11.0, will be removed in 1.12.0. It won't be called starting in 1.11.0 as
* @deprecated Since 1.11.0, will be removed in 1.13.0. It won't be called starting in 1.11.0 as
* the configuration is done by the {@link FormatModelRegistry}.
*/
@Deprecated
Expand Down Expand Up @@ -358,7 +358,7 @@ public Builder equalityDeleteSortOrder(SortOrder newEqualityDeleteSortOrder) {
}

/**
* @deprecated This method is deprecated as of version 1.11.0 and will be removed in 1.12.0.
* @deprecated This method is deprecated as of version 1.11.0 and will be removed in 1.13.0.
* Position deletes that include row data are no longer supported.
*/
@Deprecated
Expand Down
Loading
Loading