Uh oh!
There was an error while loading. Please reload this page.
Core: Drop stale path avg sizes in rewrite_table_path - #17856
Draft
huan233usc wants to merge 1 commit into
Draft
Conversation
Remove the position-delete file_path average when rewriting path bounds, keep unrelated averages, and normalize an empty map to null. Generated-by: Cursor
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Follow-up to #17451.
rewrite_table_pathkept a stale average for the position-deletefile_pathcolumn after rewriting that path.Remove the
file_pathaverage value size when rewriting position-delete path bounds, preserve unrelated averages, and normalize an empty result to null.Test plan
./gradlew :iceberg-core:test --tests org.apache.iceberg.TestRewriteTablePathUtil./gradlew :iceberg-core:spotlessCheckAI Disclosure