Skip to content

MR: Keep computed block locations in IcebergSplit.getLocations #18036

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
thswlsqls wants to merge 1 commit into
base: main
Choose a base branch
from
+5 −4
Open

MR: Keep computed block locations in IcebergSplit.getLocations #18036

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 3 additions & 4 deletions mr/src/main/java/org/apache/iceberg/mr/mapreduce/IcebergSplit.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -71,11 +71,10 @@ public long getLength() {
public String[] getLocations() {
// The implementation of getLocations() is only meant to be used during split computation
// getLocations() won't be accurate when called on worker nodes and will always return "*"
if (locations == null && conf != null) {
boolean localityPreferred = conf.getBoolean(InputFormatConfig.LOCALITY, false);
if (locations == null) {
boolean localityPreferred =
conf != null && conf.getBoolean(InputFormatConfig.LOCALITY, false);
locations = localityPreferred ? Util.blockLocations(task, conf) : ANYWHERE.clone();
} else {
locations = ANYWHERE.clone();
}

return locations;
Expand Down
2 changes: 2 additions & 0 deletions mr/src/test/java/org/apache/iceberg/mr/TestIcebergInputFormats.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -326,6 +326,8 @@ public void testLocality() throws Exception {

for (InputSplit split : testInputFormat.create(builder.conf()).getSplits()) {
assertThat(split.getLocations()).containsExactly("localhost");
// repeated calls must return the same locations that were computed and cached above
assertThat(split.getLocations()).containsExactly("localhost");
}
}

Expand Down
Loading