Uh oh!
There was an error while loading. Please reload this page.
Bump Nessie to 0.8.2 + related changes - #2588
Conversation
snazy
commented
May 19, 2021
Should worth to have projectnessie/nessie#1249 merged into Nessie first and use Nessie 0.6.1 in this PR then. |
rymurr
commented
May 24, 2021
Looks like this needs a rebase. @snazy do you still want to update to |
a25ee34 to
ebc441fComparesnazy
commented
May 27, 2021
Yup, updated this PR to bump Nessie to 0.6.1. |
Uh oh!
There was an error while loading. Please reload this page.
rymurr
commented
May 27, 2021
@snazy looks like the build failed for java8. Presumably its the recent chagne to nessie server to not support java8? |
snazy
commented
May 28, 2021
Oh yea, projectnessie/nessie#1245 broke the test runs. It's not that the Nessie Client in Iceberg is broken, it's "just" the server that cannot run. Reverting projectnessie/nessie#1245 doesn't make much sense, because Quarkus 2 drops support for Java 8 entirely. I see these options here:
I think, option 1 is a good workaround for now and then follow-up with option 2 within a short time. WDYT? |
rymurr
commented
May 28, 2021
I see no rush to get this patch in. The only deadline is the 0.12.0 release. So lets fix the tests correctly. Lets go with the uber-jar too. I don't want to complicate the CI and introduce another build dependency. |
3abe81e to
14cc6d4Compare070c269 to
bd0a28bCompareUh oh!
There was an error while loading. Please reload this page.
2b6bbb5 to
53ab73aCompare3e5c976 to
5e425d6CompareUh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
snazy
commented
Jul 13, 2021
Tests pass locally w/ Java 11 + Java 8 against latest in-dev Nessie. |
Uh oh!
There was an error while loading. Please reload this page.
rymurr
left a comment
There was a problem hiding this comment.
I think there are two things:
- more documentation of the individual changes - some aren't clear
- separate into a few changes
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
2badb38 to
8bd6f75CompareUh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
More changes in this PR in following commits. Replace Gradle plugin with new JUnit extension. See [Add JAX-RS tests and add JUnit/Jupyter extension](projectnessie/nessie#1566)
Apply changes to Iceberg required by API changes in Nessie: * [Re-introduce wrapper classes for query params of CommitLog/Entries](projectnessie/nessie#1595) * [Server-side commit range filtering](projectnessie/nessie#1596) * [Add hashOnRef query param to support time travel on a named ref](projectnessie/nessie#1589) * [Only accept NamedRefs in REST API](projectnessie/nessie#1583)
Nessie's `Contents.id` is a random ID generated when the `Contents.Key` is first used (think: CREATE TABLE) and must not be changed. This change addresses a bug in the Iceberg-Nesie code that caused a new id for every change.
When commiting a change, the Nessie-API now returns the hash of the commit for the change. This returned hash should then be used as the "expected hash" for the next commit. The previous approach was to commit the change to Nessie and then do another request to retrieve the new hash of HEAD. This old approach is prone to a race condition, namely when another commit happens after "this" commit but before retrieving the "new HEAD", so "this" instance would wrongly ignore the other commit's changes during conflict checks. See [Let VersionStore.create()+commit() return the current hash](projectnessie/nessie#1089)
* Bump Nessie to 0.8.2 + replace Gradle plugin with new JUnit extension More changes in this PR in following commits. Replace Gradle plugin with new JUnit extension. See [Add JAX-RS tests and add JUnit/Jupyter extension](projectnessie/nessie#1566) * Changes required by Nessie-API changes Apply changes to Iceberg required by API changes in Nessie: * [Re-introduce wrapper classes for query params of CommitLog/Entries](projectnessie/nessie#1595) * [Server-side commit range filtering](projectnessie/nessie#1596) * [Add hashOnRef query param to support time travel on a named ref](projectnessie/nessie#1589) * [Only accept NamedRefs in REST API](projectnessie/nessie#1583) * Bugfix: must send the Contents.id of the existing table Nessie's `Contents.id` is a random ID generated when the `Contents.Key` is first used (think: CREATE TABLE) and must not be changed. This change addresses a bug in the Iceberg-Nesie code that caused a new id for every change. * Throw `CommitStateUnknownException` for `renameTable` as well Follow-up of apache#2515 * Fix race-condition & save one roundtrip to Nessie during "commit" When commiting a change, the Nessie-API now returns the hash of the commit for the change. This returned hash should then be used as the "expected hash" for the next commit. The previous approach was to commit the change to Nessie and then do another request to retrieve the new hash of HEAD. This old approach is prone to a race condition, namely when another commit happens after "this" commit but before retrieving the "new HEAD", so "this" instance would wrongly ignore the other commit's changes during conflict checks. See [Let VersionStore.create()+commit() return the current hash](projectnessie/nessie#1089)
Bump Nessie to 0.8.2 + replace Gradle plugin with new JUnit extension
See Add JAX-RS tests and add JUnit/Jupyter extension
Apply changes to Iceberg required by API changes in Nessie:
Bugfix: must send the Contents.id of the existing table
Nessie's
Contents.idis a random ID generated when theContents.Keyis first used (think:CREATE TABLE) and must not be changed. This change addresses a bug in the Iceberg-Nesie code
that caused a new id for every change.
Throw
CommitStateUnknownExceptionforrenameTableas wellFollow-up of Use
CommitStatusUnknownExceptionfor Nessie #2515Fix race-condition & save one roundtrip to Nessie during "commit"
When commiting a change, the Nessie-API now returns the hash of the commit for the change.
This returned hash should then be used as the "expected hash" for the next commit.
The previous approach was to commit the change to Nessie and then do another request to
retrieve the new hash of HEAD.
This old approach is prone to a race condition, namely when another commit happens after
"this" commit but before retrieving the "new HEAD", so "this" instance would wrongly
ignore the other commit's changes during conflict checks.
See Let VersionStore.create()+commit() return the current hash