Skip to content

Spark: Set properties for deletewriter #2859

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
coolderli wants to merge 1 commit into from
Closed

Spark: Set properties for deletewriter #2859

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions spark/src/main/java/org/apache/iceberg/spark/source/SparkAppenderFactory.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -205,6 +205,7 @@ public EqualityDeleteWriter<InternalRow> newEqDeleteWriter(EncryptedOutputFile f
case PARQUET:
return Parquet.writeDeletes(file.encryptingOutputFile())
.createWriterFunc(msgType -> SparkParquetWriters.buildWriter(lazyEqDeleteSparkType(), msgType))
.setAll(properties)

@openinx openinx Jul 26, 2021

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution, @coolderli ! I also think the newPosDeleteWriter need the properties setting ...

@coolderli coolderli Jul 26, 2021

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, I have already added. https://github.com/apache/iceberg/pull/2859/files#diff-906095312ad35f773d13f65e57921be14d10ba569ce7c3ff9a03dbedf423b666R248

@rdblue rdblue Sep 12, 2021

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@coolderli, could you add this update?

.overwrite()
.rowSchema(eqDeleteRowSchema)
.withSpec(spec)
Expand All @@ -216,6 +217,7 @@ public EqualityDeleteWriter<InternalRow> newEqDeleteWriter(EncryptedOutputFile f
case AVRO:
return Avro.writeDeletes(file.encryptingOutputFile())
.createWriterFunc(ignored -> new SparkAvroWriter(lazyEqDeleteSparkType()))
.setAll(properties)
.overwrite()
.rowSchema(eqDeleteRowSchema)
.withSpec(spec)
Expand Down Expand Up @@ -243,6 +245,7 @@ public PositionDeleteWriter<InternalRow> newPosDeleteWriter(EncryptedOutputFile
SparkSchemaUtil.convert(DeleteSchemaUtil.posDeleteSchema(posDeleteRowSchema));
return Parquet.writeDeletes(file.encryptingOutputFile())
.createWriterFunc(msgType -> SparkParquetWriters.buildWriter(sparkPosDeleteSchema, msgType))
.setAll(properties)
.overwrite()
.rowSchema(posDeleteRowSchema)
.withSpec(spec)
Expand All @@ -254,6 +257,7 @@ public PositionDeleteWriter<InternalRow> newPosDeleteWriter(EncryptedOutputFile
case AVRO:
return Avro.writeDeletes(file.encryptingOutputFile())
.createWriterFunc(ignored -> new SparkAvroWriter(lazyPosDeleteSparkType()))
.setAll(properties)
.overwrite()
.rowSchema(posDeleteRowSchema)
.withSpec(spec)
Expand Down