Uh oh!
There was an error while loading. Please reload this page.
Hive: Fix NoSuchMethodError of OrcTail with Hive3.x and Vectorized ORC - #3155
Merged
Conversation
szlta
commented
Sep 21, 2021
Contributor
LGTM, I'm okay with copying this over from Hive for the time being. Checkstyle errors need to be fixed though in the copied OrcSplit class. |
omarsmak
commented
Sep 21, 2021
MemberAuthor
Thanks for the feedback. Sure, I will fix the Checkstyle errors and update the PR. |
omarsmak
commented
Sep 21, 2021
MemberAuthor
@szlta Checkstyle should be fixed now. |
omarsmak
commented
Oct 5, 2021
MemberAuthor
hey @szlta ping |
szlta
commented
Oct 11, 2021
Contributor
Can you retrigger the tests? I still see some failures :( |
omarsmakforce-pushed
the
fix-iceberg-hive-orc
branch
from
October 11, 2021 15:26
6554786 to
0c69b95Compareomarsmak
commented
Oct 11, 2021
MemberAuthor
@szlta things look good now in the CI :) |
szlta
commented
Oct 12, 2021
Contributor
LGTM, @pvary can you please take a look too? |
pvary
approved these changes
Oct 12, 2021
pvary
commented
Oct 12, 2021
Contributor
omarsmak
commented
Oct 20, 2021
MemberAuthor
@rdblue I think this PR is a good candidate for 0.12.1 milestone |
rdblue
commented
Oct 20, 2021
Contributor
Thanks, @omarsmak. I've added this to the 0.12.1 milestone. |
kbendick pushed a commit
to kbendick/iceberg
that referenced
this pull request
Oct 27, 2021
kbendick pushed a commit
to kbendick/iceberg
that referenced
this pull request
Oct 27, 2021
kbendick pushed a commit
to kbendick/iceberg
that referenced
this pull request
Oct 27, 2021
rdblue pushed a commit
that referenced
this pull request
Oct 29, 2021
RussellSpitzer pushed a commit
to RussellSpitzer/iceberg
that referenced
this pull request
Oct 29, 2021
izchen pushed a commit
to izchen/iceberg
that referenced
this pull request
Dec 7, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes#3041
As I explained here, this issue seems happen as regression result from PR: #2613
So the issue is that compiled class
HiveVectorizedReaderrefers to the shadedorg.apache.iceberg.shaded.org.apache.orc.OrcTailinstead oforg.apache.orc.OrcTailwhich triggers the error that is described in the github issue when using Vectorized ORC with MR jobs.Honestly, this is a bit annoying issue due to the inter-dependencies between Hive, Iceberg and ORC and therefore, the simplest solution is to copy
OrcTailclass from Hive 3.1.2 into Iceberg for this only case. However, to be honest I am not happy to copy such classes from Hive but from my humble understanding is that, such solution will be temporary until the release of Hive 4. Thus, I am submitting this PR for this purposed solution, if anybody has a better idea how to solve such issue, I will be happy to hear.