Skip to content

Hive: Ensure tableLevelMutex is unlocked when uncommitted metadata de… - #3264

Merged
pvary merged 1 commit into
apache:masterfrom
jshmchenxi:tableLevelMutex
Oct 11, 2021
Merged

Hive: Ensure tableLevelMutex is unlocked when uncommitted metadata de…#3264
pvary merged 1 commit into
apache:masterfrom
jshmchenxi:tableLevelMutex

Conversation

@jshmchenxi

@jshmchenxijshmchenxi commented Oct 9, 2021

Copy link
Copy Markdown
Contributor

…lete fails

Simillar to #1998, tableLevelMutex should also be in the finally block of cleanupMetadataAndUnlock() so that it must be unlocked.

@pvary
pvary merged commit 665da79 into apache:masterOct 11, 2021
@pvary

Copy link
Copy Markdown
Contributor

Thanks for the catch and fix @jshmchenxi!

@jshmchenxi

Copy link
Copy Markdown
ContributorAuthor

@pvary Thanks for merging this!

RussellSpitzer pushed a commit to RussellSpitzer/iceberg that referenced this pull request Oct 29, 2021
@kbendick

Copy link
Copy Markdown
Contributor

Marking this one temporarily for 0.12.1, as I've noticed that some test suites will run forever.

When people go to test the release candidate, we don't want that to happen.

Very open to not including it if need be.

@kbendickkbendick added this to the Java 0.12.1 Release milestone Nov 1, 2021
kbendick pushed a commit to kbendick/iceberg that referenced this pull request Nov 1, 2021
kbendick pushed a commit to kbendick/iceberg that referenced this pull request Nov 1, 2021
This was referenced Nov 1, 2021
rdblue pushed a commit that referenced this pull request Nov 1, 2021
@kbendick

Copy link
Copy Markdown
Contributor

Marking this one temporarily for 0.12.1, as I've noticed that some test suites will run forever.

When people go to test the release candidate, we don't want that to happen.

Very open to not including it if need be.

This is a correctness fix so leaving it marked for inclusion in 0.12.1.

izchen pushed a commit to izchen/iceberg that referenced this pull request Dec 7, 2021
Initial-neko pushed a commit to Initial-neko/iceberg that referenced this pull request Dec 13, 2021
Initial-neko pushed a commit to Initial-neko/iceberg that referenced this pull request Dec 17, 2021
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@jshmchenxi@pvary@kbendick