Uh oh!
There was an error while loading. Please reload this page.
Core: Use the latest RoaringBitmap version 0.9.22 - #3513
Merged
Conversation
kbendick
approved these changes
Nov 10, 2021
Contributor
There was a problem hiding this comment.
+1. Thanks @flyrain!
We might consider not moving too far ahead of Spark with this dependency in general in the future. This is the present master Spark version, so seems good to me. I know we shade it, I'm just not very familiar with who actually looks after this dependency.
But I know it's used everywhere, so if you told me that the committers were at Apple I wouldn't be surprised in the least. Thanks for taking care of this @flyrain :)
aokolnychyi
approved these changes
Nov 10, 2021
aokolnychyi
commented
Nov 10, 2021
Contributor
@flyrain, could you rebase this one? |
flyrainforce-pushed
the
roaringbitmap-version
branch
from
November 10, 2021 18:41
f45a796 to
8beb76dCompareaokolnychyi
commented
Nov 10, 2021
Contributor
Thanks, @flyrain! |
flyrain
commented
Nov 10, 2021
ContributorAuthor
Thanks all for the review. |
Initial-neko pushed a commit
to Initial-neko/iceberg
that referenced
this pull request
Nov 23, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A followup of #3287. We should use the latest version of RoaringBitmap.
cc @aokolnychyi@RussellSpitzer@karuppayya@szehon-ho