Uh oh!
There was an error while loading. Please reload this page.
API: Use Immutables for TableIdentifier/Namespace - #3688
Closed
nastra wants to merge 1 commit into
Closed
Conversation
nastra
commented
Dec 8, 2021
Uh oh!
There was an error while loading. Please reload this page.
nastra
commented
Dec 8, 2021
| Assertions.assertThatThrownBy(() -> TableIdentifier.of(Namespace.empty(), null)) | ||
| .isInstanceOf(IllegalArgumentException.class) | ||
| .hasMessage("Invalid table name: null or empty"); | ||
| .isInstanceOf(NullPointerException.class) |
ContributorAuthor
There was a problem hiding this comment.
this is because the Immutables lib does an Objects.requireNonNull(name, "name") for everything that isn't marked as @Nullable
ContributorAuthor
There was a problem hiding this comment.
alternatively, we could add @Value.Style(throwForNullPointer = IllegalArgumentException.class) to throw an IAE for nulls
nastraforce-pushed
the
use-immutables
branch
2 times, most recently
from
December 9, 2021 07:34
68fde04 to
011d4e5Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
This is relying on https://immutables.github.io/ (Apache License 2.0), which allows generating immutable objects and builders via annotation processing.