Uh oh!
There was an error while loading. Please reload this page.
[0.13] Core: Fixes read metadata failed after dropped partition transform for V1 format - #4572
Merged
Merged
Conversation
…r V1 format (apache#3411) V1 Tables replace dropped partition transforms with a Void Transform which always returns null. The type of this Void transform always matches the column's original type. This has issues when the column's type differed from the transform used to previously partition the column. Here the issue is patched by retaining the correct type for the transform values when those values are being read after the transform has been dropped.
ConeyLiu
commented
Apr 16, 2022
ContributorAuthor
szehon-ho
approved these changes
Apr 16, 2022
szehon-ho added a commit
to szehon-ho/iceberg
that referenced
this pull request
Apr 18, 2022
ConeyLiu
commented
Apr 19, 2022
ContributorAuthor
Thanks @szehon-ho. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This backs port #3411 to 0.13.x branch.
This patch fixes two problems:
VoidTransformto replace the removed partition field. While the result type ofVoidTransformsame as the type of the field. For example, the result type ofBucket(2, string_type_field)is int, while is string forVoidTransform(string_type_field). So we should use the original partition field type(int instead of string) to build the common partitioning type.PartitionSpecto convert thePartitionFiedlSummaryto human string, not the current table spec.