Skip to content

Core: Use table partitioning with manual sort order - #5187

Merged
rdblue merged 3 commits into
apache:masterfrom
rdblue:use-table-partitioning-with-manual-sort-order
Jul 7, 2022
Merged

Core: Use table partitioning with manual sort order#5187
rdblue merged 3 commits into
apache:masterfrom
rdblue:use-table-partitioning-with-manual-sort-order

Conversation

@rdblue

@rdbluerdblue commented Jul 3, 2022•
edited
Loading

Copy link
Copy Markdown
Contributor

This is based on #4922, but adds a check for the unsorted order to make tests pass without modification.

Closes#4922.

@rdbluerdblue added this to the Iceberg 0.14.0 Release milestone Jul 3, 2022
@rdbluerdblue changed the title Use table partitioning with manual sort orderCore: Use table partitioning with manual sort orderJul 5, 2022
@aokolnychyi

aokolnychyi commented Jul 7, 2022

Copy link
Copy Markdown
Contributor

I am confused. This PR does not seem to include all changes from #4922. Are both needed then?

@rdblue

rdblue commented Jul 7, 2022

Copy link
Copy Markdown
ContributorAuthor

@aokolnychyi, I updated #4922 to fix the outstanding problems to get it into the release, but it looks like it was updated yesterday. A review would still be helpful to make sure we're happy with the change, on either PR.

@rdblue
rdblue merged commit 761eadc into apache:masterJul 7, 2022
@rdblue

rdblue commented Jul 7, 2022

Copy link
Copy Markdown
ContributorAuthor

Thanks, @aokolnychyi!

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@aokolnychyiaokolnychyiaokolnychyi approved these changes
@RussellSpitzerRussellSpitzerAwaiting requested review from RussellSpitzer

Assignees

No one assigned

Labels

core

Projects

None yet

Milestone

Iceberg 0.14.0 Release

Development

Successfully merging this pull request may close these issues.

3 participants

@rdblue@aokolnychyi@rajarshisarkar