Uh oh!
There was an error while loading. Please reload this page.
AWS: S3FileIo Integration test include UUID prefix in Prefix integration tests - #5413
Merged
Merged
Conversation
…t runs of the integration tests don't interfere with each other
szehon-ho
approved these changes
Aug 2, 2022
szehon-ho
commented
Aug 2, 2022
Member
Merged, thanks @amogh-jahagirdar |
amogh-jahagirdar
commented
Aug 2, 2022
ContributorAuthor
Thanks for the review Szehon! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Right now, running s3 file io integration test multiple times will lead to failures in expectations of the testPrefixList. This is because the cleanup which happens in AfterClass only cleans up under s3://bucket/uuid-prefix where uuid prefix is the random uuid created on each run of the test class. The testPrefixList is creating objects in s3://bucket/prefix-list-test. We should actually put this in s3://bucket/uuid-prefix/prefix-list-test so that After class will properly clean this up, and we can run multiple runs of the integ test successfully.
Going forward, we will also want #4855 so that issues like this can be caught earlier on. I tested this by running the AWS integ tests multiple times on a pre-existing bucket I used for iceberg-aws integration tests.