Skip to content

Spark: DROP BRANCH SQL implementation - #6752

Merged
jackye1995 merged 1 commit into
apache:masterfrom
amogh-jahagirdar:drop-branch
Feb 11, 2023
Merged

Spark: DROP BRANCH SQL implementation#6752
jackye1995 merged 1 commit into
apache:masterfrom
amogh-jahagirdar:drop-branch

Conversation

@amogh-jahagirdar

@amogh-jahagirdaramogh-jahagirdar commented Feb 6, 2023•
edited
Loading

Copy link
Copy Markdown
Contributor

This is an implementation of DROP BRANCH Spark SQL

Co-authored-by: liliwei hililiwei@gmail.com
Co-authored-by: xuwei xuwei132@huawei.com
Co-authored-by: chidayong chidayong2@h-partners.com

CC: @jackye1995@hililiwei@flyrain@singhpk234@aokolnychyi

@jackye1995
jackye1995 self-requested a review February 6, 2023 04:03
@amogh-jahagirdar
amogh-jahagirdarforce-pushed the drop-branch branch 2 times, most recently from a66b371 to b8cade0CompareFebruary 6, 2023 04:08
singhpk234
singhpk234 reviewed Feb 6, 2023
View reviewed changes
Comment thread...extensions/src/main/scala/org/apache/spark/sql/execution/datasources/v2/DropBranchExec.scala Outdated
Comment thread...extensions/src/main/scala/org/apache/spark/sql/execution/datasources/v2/DropBranchExec.scala Outdated
Comment thread...sions/src/main/antlr/org.apache.spark.sql.catalyst.parser.extensions/IcebergSqlExtensions.g4 Outdated
Comment thread.../v3.3/spark-extensions/src/test/java/org/apache/iceberg/spark/extensions/TestDropBranch.java Outdated
Comment thread.../v3.3/spark-extensions/src/test/java/org/apache/iceberg/spark/extensions/TestDropBranch.java Outdated
@amogh-jahagirdar
amogh-jahagirdarforce-pushed the drop-branch branch 7 times, most recently from 261249c to 2040da3CompareFebruary 7, 2023 16:54
@amogh-jahagirdaramogh-jahagirdar mentioned this pull request Feb 7, 2023
Merged
jackye1995
jackye1995 approved these changes Feb 7, 2023
View reviewed changes

@jackye1995jackye1995 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me!

singhpk234
singhpk234 reviewed Feb 8, 2023
View reviewed changes
Comment thread...k/v3.3/spark-extensions/src/test/java/org/apache/iceberg/spark/extensions/TestBranchDDL.java
Comment thread...k/v3.3/spark-extensions/src/test/java/org/apache/iceberg/spark/extensions/TestBranchDDL.java Outdated
Comment thread...k/v3.3/spark-extensions/src/test/java/org/apache/iceberg/spark/extensions/TestBranchDDL.java Outdated
singhpk234
singhpk234 approved these changes Feb 8, 2023
View reviewed changes

@singhpk234singhpk234 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, Thanks @amogh-jahagirdar !!

yyanyy
yyanyy approved these changes Feb 10, 2023
View reviewed changes

@yyanyyyyanyy left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@jackye1995
jackye1995 removed the request for review from aokolnychyiFebruary 10, 2023 22:08
@amogh-jahagirdar
Spark: DROP BRANCH SQL implementation
77dffba
Co-authored-by: liliwei hililiwei@gmail.com
Co-authored-by: xuwei xuwei132@huawei.com
Co-authored-by: chidayong chidayong2@h-partners.com
@jackye1995

jackye1995 commented Feb 11, 2023

Copy link
Copy Markdown
Contributor

Looks like all comments are addressed and we have enough vote, I will go ahead and merge this. We can address further comments in the subsequent DROP TAG PR if necessary. Thanks for the work @amogh-jahagirdar & @hililiwei , and thanks for everyone's review!

@jackye1995
jackye1995 merged commit 970aeae into apache:masterFeb 11, 2023
krvikash pushed a commit to krvikash/iceberg that referenced this pull request Mar 16, 2023
@amogh-jahagirdar@krvikash
Spark 3.3: DROP BRANCH SQL implementation (apache#6752)
e7428c8
Co-authored-by: liliwei hililiwei@gmail.com
Co-authored-by: xuwei xuwei132@huawei.com
Co-authored-by: chidayong chidayong2@h-partners.com
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@rdbluerdbluerdblue left review comments
@jackye1995jackye1995jackye1995 approved these changes
@singhpk234singhpk234singhpk234 approved these changes
@yyanyyyyanyyyyanyy approved these changes
+1 more reviewer
@hililiweihililiweihililiwei left review comments
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

spark

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@amogh-jahagirdar@jackye1995@rdblue@singhpk234@hililiwei@yyanyy