Uh oh!
There was an error while loading. Please reload this page.
API, Core: Move schemaID from ViewRepresentation to ViewVersion and make it required - #7421
Merged
Merged
Conversation
amogh-jahagirdar
commented
Apr 24, 2023
ContributorAuthor
I'll wait for #7417 to go in with all the cleanup and then rebase my changes. |
amogh-jahagirdarforce-pushed
the
view-version-schema
branch
from
April 24, 2023 17:58
e746b74 to
f7c2fa4Compareamogh-jahagirdarforce-pushed
the
view-version-schema
branch
from
April 25, 2023 04:59
f7c2fa4 to
0c76c11CompareUh oh!
There was an error while loading. Please reload this page.
jackye1995
approved these changes
Apr 25, 2023
jackye1995
left a comment
Contributor
There was a problem hiding this comment.
looks good to me, just a nit!
amogh-jahagirdarforce-pushed
the
view-version-schema
branch
from
April 25, 2023 05:27
0c76c11 to
3ba1bcbComparejackye1995
commented
Apr 25, 2023
Contributor
Thanks for the quick fix! I will merge this to continue the conversations in #6559 |
manisin pushed a commit
to Snowflake-Labs/iceberg
that referenced
this pull request
May 9, 2023
zhongyujiang pushed a commit
to zhongyujiang/iceberg
that referenced
this pull request
Apr 16, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow up from #6559 (comment) . The conclusion was that it's better to make schema required and part of the ViewVersion since all representations should share the same schema.