Skip to content

Update documentation to reflect new catalog features - #7433

Merged
szehon-ho merged 3 commits into
apache:masterfrom
dramaticlly:SparkCatalogJavadoc
May 3, 2023
Merged

Update documentation to reflect new catalog features#7433
szehon-ho merged 3 commits into
apache:masterfrom
dramaticlly:SparkCatalogJavadoc

Conversation

@dramaticlly

@dramaticllydramaticlly commented Apr 25, 2023

Copy link
Copy Markdown
Contributor

I want to include new features we developed over last few releases to be reflected in javadoc of SparkCatalog as it's lacking at the moment

CC @jackye1995@Fokko@SinghAsDev@nastra

@dramaticlly
dramaticllyforce-pushed the SparkCatalogJavadoc branch 2 times, most recently from ecda518 to 19259a6CompareApril 25, 2023 23:02
@dramaticllydramaticlly changed the title Update javadoc to reflect new features supported on SparkCatalogUpdate documentation to reflect new catalog featuresApr 25, 2023
@jackye1995

jackye1995 commented Apr 26, 2023

Copy link
Copy Markdown
Contributor

Could you also do it for Spark 3.4?

@jackye1995

jackye1995 commented Apr 26, 2023

Copy link
Copy Markdown
Contributor

oh nvm about last comment, clicked the wrong link only showing the first commit.

jackye1995
jackye1995 reviewed Apr 26, 2023
View reviewed changes
Comment threaddocs/spark-configuration.md Outdated
jackye1995
jackye1995 reviewed Apr 26, 2023
View reviewed changes
Comment threaddocs/spark-configuration.md Outdated
jackye1995
jackye1995 reviewed Apr 26, 2023
View reviewed changes
Comment threaddocs/spark-configuration.md Outdated
@jackye1995

jackye1995 commented Apr 26, 2023

Copy link
Copy Markdown
Contributor

Looks like CI failed, could you check that?

nastra
nastra reviewed Apr 26, 2023
View reviewed changes

@nastranastra left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

mostly LGTM but would be could to simplify the diff

Comment threaddocs/spark-configuration.md Outdated
Comment threadspark/v3.3/spark/src/main/java/org/apache/iceberg/spark/SparkCatalog.java Outdated
Comment threaddocs/spark-configuration.md Outdated
nastra
nastra reviewed Apr 27, 2023
View reviewed changes
Comment threaddocs/spark-configuration.md Outdated
Comment threaddocs/spark-configuration.md Outdated
Comment threaddocs/spark-configuration.md Outdated
nastra
nastra approved these changes Apr 28, 2023
View reviewed changes

@nastranastra left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

there were still a few unnecessary whitespace changes in the Table. Once those are fixed the changes LGTM

Comment threaddocs/spark-configuration.md Outdated
Comment threaddocs/spark-configuration.md Outdated
Comment threaddocs/spark-configuration.md Outdated
Comment threaddocs/spark-configuration.md Outdated
Comment threaddocs/spark-configuration.md Outdated
@dramaticlly@nastra
Apply suggestions from code review
eba2115
Co-authored-by: Eduard Tudenhoefner <etudenhoefner@gmail.com>
szehon-ho
szehon-ho reviewed May 1, 2023
View reviewed changes

@szehon-hoszehon-ho left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, just a few suggestions. Hope its not repeating any of the above comments

Comment threaddocs/spark-configuration.md Outdated
Comment threaddocs/spark-configuration.md Outdated
@szehon-ho
szehon-ho merged commit 5117b6b into apache:masterMay 3, 2023
@szehon-ho

szehon-ho commented May 3, 2023

Copy link
Copy Markdown
Member

Merged, thanks @dramaticlly , @nastra@jackye1995 for review

manisin pushed a commit to Snowflake-Labs/iceberg that referenced this pull request May 9, 2023
@dramaticlly@manisin
Docs: Update new catalog features (apache#7433)
2aabce6
@dramaticlly
dramaticlly deleted the SparkCatalogJavadoc branch June 28, 2023 21:42
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jackye1995jackye1995jackye1995 left review comments
@nastranastranastra approved these changes
@szehon-hoszehon-hoszehon-ho approved these changes

Assignees

No one assigned

Labels

docsspark

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@dramaticlly@jackye1995@szehon-ho@nastra