Implement ReadableMetrics for Entries table - #7539
Merged
Merged
Conversation
szehon-ho
reviewed
May 10, 2023
szehon-ho
left a comment
Member
There was a problem hiding this comment.
Great job, just some comments about code - reuse
szehon-ho
reviewed
May 12, 2023
szehon-ho
reviewed
May 12, 2023
szehon-ho
reviewed
May 12, 2023
szehon-ho
approved these changes
May 12, 2023
szehon-ho
reviewed
May 12, 2023
Member
|
Merged, thanks @dramaticlly for the change! |
Member
|
Hi, @dramaticlly as I didnt want to block the change, I had some follow up that I made in #7613 including what we discussed in #7539 (comment). I think it makes the code between BaseFilesTable and BaseEntriesTable even more similar and with more re-use, if you wanted to take a look |
|
Hello, I want to get upper/lower bounds from the manifest file like: The log will be byteBuffer, I see @szehon-ho pr for a readable metrics, I am wondering do we have a java api we can use, or I have to use DDL? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
close #7364
This enable query readable metrics on entry metadata table, similar to #5376 by @szehon-ho
Given table schema like below
we can query its per column min/max for each manifest entry