Uh oh!
There was an error while loading. Please reload this page.
Core, Hive, Nessie: Use ResolvingFileIO as default instead of HadoopFileIO - #8272
Core, Hive, Nessie: Use ResolvingFileIO as default instead of HadoopFileIO#8272nastra wants to merge 1 commit into
Conversation
948a917 to
fb23e4dComparefb23e4d to
fcbc64eCompareszehon-ho
commented
Aug 9, 2023
Also, can we make it support SupportsPrefixOperations. Thinking it a possible option for: #8194 |
nastra
commented
Aug 10, 2023
@szehon-ho did you mean to comment on #7976 w.r.t |
dramaticlly
left a comment
There was a problem hiding this comment.
change LGTM, do we need to update docs anywhere to better inform user? Since this default value change and some might not be fully aware of
nastra
commented
Aug 15, 2023
This change should be completely transparent for users |
fcbc64e to
d24c581Compare| private static final String NAMESPACE_EXISTS_PROPERTY = "exists"; | ||
| private static final Logger LOG = LoggerFactory.getLogger(JdbcCatalog.class); | ||
| private static final Joiner SLASH = Joiner.on("/"); | ||
| private static final String DEFAULT_FILE_IO_IMPL = "org.apache.iceberg.io.ResolvingFileIO"; |
There was a problem hiding this comment.
You could use the name from the class potentially, rather than a string literal, as ResolvingFileIO is in core.
rdblue
commented
Sep 13, 2023
I think we need to discuss this more before merging it. This will change the default |
ajantha-bhat
commented
Dec 12, 2023
I remember discussing this in the community sync. Why this didn't move forward? |
nastra
commented
Dec 12, 2023
@ajantha-bhat this will be done prior to releasing 2.0.0 |
This pull request has been marked as stale due to 30 days of inactivity. It will be closed in 1 week if no further activity occurs. If you think that’s incorrect or this pull request requires a review, please simply write any comment. If closed, you can revive the PR at any time and @mention a reviewer or discuss it on the dev@iceberg.apache.org list. Thank you for your contributions. |
This pull request has been marked as stale due to 30 days of inactivity. It will be closed in 1 week if no further activity occurs. If you think that’s incorrect or this pull request requires a review, please simply write any comment. If closed, you can revive the PR at any time and @mention a reviewer or discuss it on the dev@iceberg.apache.org list. Thank you for your contributions. |
No description provided.