Uh oh!
There was an error while loading. Please reload this page.
Load: Implement region operations cache for load × region migration detection - #15210
Merged
SteveYurongSu merged 8 commits intoMar 28, 2025
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR implements a caching mechanism for region operations to improve the management of region migration and its related notifications. Key changes include:
- Refactoring in ProcedureManager to extract region operation procedures and provide a consensus ID list.
- Introduction of a new RegionOperationsCache inner class in RegionMigrateService to cache region operations along with logical clock and timestamp updates.
- Updates across ConfigNodeProcedureEnv, HeartbeatService, DataNodeInternalRPCServiceImpl, and RegionMigrateProcedure to integrate the new cache information in region migration notifications.
Reviewed Changes
Copilot reviewed 7 out of 8 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| ProcedureManager.java | Refactored methods for retrieving region operation procedures and duplication checks. |
| RegionMigrateService.java | Introduced RegionOperationsCache to manage caching of region operation data and replaced the static lastNotifyTime. |
| ConfigNodeProcedureEnv.java | Updated construction of TNotifyRegionMigrationReq to include logical clock, timestamp, and region operations list. |
| DataNodeInternalRPCServiceImpl.java | Integrated region migration notifications with the new region operations update mechanism. |
| HeartbeatService.java | Changed heartbeat request generation to include logical clock and region operation updates. |
| RegionMigrateProcedure.java | Updated logging calls to use RegionMaintainHandler for improved clarity. |
| DataNodeHeartbeatHandler.java | Added logger import and initialization for enhanced logging. |
Files not reviewed (1)
- iotdb-protocol/thrift-datanode/src/main/thrift/datanode.thrift: Language not supported
Uh oh!
There was an error while loading. Please reload this page.
SteveYurongSu
approved these changes
Mar 28, 2025
liyuheng55555 added a commit
to liyuheng55555/iotdb
that referenced
this pull request
Apr 1, 2025
…etection (apache#15210) Co-authored-by: Steve Yurong Su <rong@apache.org> (cherry picked from commit 8889255)
Caideyipi pushed a commit
to Caideyipi/iotdb
that referenced
this pull request
Mar 25, 2026
…etection (apache#15210) (apache#15246) Co-authored-by: Steve Yurong Su <rong@apache.org> (cherry picked from commit 8889255)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.