Skip to content

[To dev/1.3] Load: Support multi-disks awareness for IoTV2 and Pipe - #15213

Merged
OneSizeFitsQuorum merged 1 commit into
apache:dev/1.3from
Pengzna:dev/1.3
Mar 27, 2025
Merged

[To dev/1.3] Load: Support multi-disks awareness for IoTV2 and Pipe#15213
OneSizeFitsQuorum merged 1 commit into
apache:dev/1.3from
Pengzna:dev/1.3

Conversation

@Pengzna

Copy link
Copy Markdown
Collaborator

(cherry picked from commit a81c5c6)

@SteveYurongSuSteveYurongSu self-assigned this Mar 27, 2025

CopilotAI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds multi-disks awareness for IoTV2 and Pipe load operations by introducing new disk selector implementations and updating disk selector configuration. Key changes include:

  • The introduction of ILoadDiskSelector interface and its two implementations (InheritSystemMultiDisksStrategySelector and MinIOSelector).
  • Modifications in DataRegion to initialize and use the appropriate disk selector based on configuration.
  • Updates in IoTDBDescriptor and IoTDBConfig to expose new configuration properties for disk selection.

Reviewed Changes

Copilot reviewed 7 out of 8 changed files in this pull request and generated no comments.

Show a summary per file
FileDescription
InheritSystemMultiDisksStrategySelector.javaAdds a new disk selector implementation inheriting system multi-disk strategy
ILoadDiskSelector.javaDefines the disk selector interface and enum for supported strategies
MinIOSelector.javaImplements load disk selection based on minimal IO, augmenting the existing system strategy
DataRegion.javaIntroduces fields and initialization logic to choose the appropriate disk selector based on configuration
IoTDBDescriptor.java and IoTDBConfig.javaUpdates to load and apply new configuration properties for disk selection
Files not reviewed (1)
  • iotdb-core/node-commons/src/assembly/resources/conf/iotdb-system.properties.template: Language not supported

@OneSizeFitsQuorumOneSizeFitsQuorum left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@OneSizeFitsQuorum
OneSizeFitsQuorum merged commit 2594187 into apache:dev/1.3Mar 27, 2025
Caideyipi pushed a commit to Caideyipi/iotdb that referenced this pull request Mar 25, 2026
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

@Pengzna@SteveYurongSu@OneSizeFitsQuorum