Skip to content

fix: export-tsfile change pull mode - #15306

Merged
CritasWang merged 8 commits into
apache:masterfrom
CritasWang:wx_fix
Apr 28, 2025
Merged

fix: export-tsfile change pull mode#15306
CritasWang merged 8 commits into
apache:masterfrom
CritasWang:wx_fix

Conversation

@CritasWang

Copy link
Copy Markdown
Collaborator

No description provided.

@CritasWangCritasWang changed the title fix: export-tsfile change modefix: export-tsfile change pull modeApr 9, 2025
@CritasWang
CritasWang requested a review from CopilotApril 9, 2025 09:55

CopilotAI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 6 out of 6 changed files in this pull request and generated no comments.

Comments suppressed due to low confidence (3)

iotdb-client/cli/src/main/java/org/apache/iotdb/tool/tsfile/subscription/SubscriptionTreeTsFile.java:147

  • Using a loop based solely on consumer.allSnapshotTopicMessagesHaveBeenConsumed() for termination could result in an endless loop if the condition is never met. Consider adding a retry or timeout mechanism to prevent potential infinite waiting.
while (!consumer.allSnapshotTopicMessagesHaveBeenConsumed()) {

iotdb-client/cli/src/main/java/org/apache/iotdb/tool/tsfile/subscription/SubscriptionTableTsFile.java:151

  • Using a termination condition without a fallback (e.g., a retry counter) might lead to an infinite loop if messages remain unconsumed. Consider incorporating a limit to ensure the loop eventually terminates.
while (!consumer.allSnapshotTopicMessagesHaveBeenConsumed()) {

iotdb-client/cli/src/main/java/org/apache/iotdb/tool/common/Constants.java:288

  • Changing AUTO_COMMIT from false to true may alter the commit behavior significantly. Confirm that enabling auto-commit is intended and that downstream processes can handle this change.
public static final boolean AUTO_COMMIT = true;

@SteveYurongSuSteveYurongSu self-assigned this Apr 10, 2025
@CritasWang

Copy link
Copy Markdown
CollaboratorAuthor

add #15206

@CritasWang
CritasWang merged commit 4af9c59 into apache:masterApr 28, 2025
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

@CritasWang@VGalaxies@SteveYurongSu