Skip to content

Pipe: Fixed the bug that a realtime only pipe will not transfer historical data when it is altered to a historical pipe#17223

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jt2594838 merged 3 commits into from
Feb 27, 2026
+52 −1
Merged

Pipe: Fixed the bug that a realtime only pipe will not transfer historical data when it is altered to a historical pipe #17223

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
e43acae
try-fix-index
Caideyipi Feb 26, 2026
cc24c4a
fix
Caideyipi Feb 26, 2026
d654e2a
pi-fix
Caideyipi Feb 26, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
45 changes: 45 additions & 0 deletions ...st/src/test/java/org/apache/iotdb/pipe/it/dual/treemodel/auto/basic/IoTDBPipeAlterIT.java
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -570,4 +570,49 @@ public void testAlterPipeSourceAndProcessor() {
"count(timeseries),",
Collections.singleton("3,"));
}

@Test
public void testAlterPipeRealtime() {
final DataNodeWrapper receiverDataNode = receiverEnv.getDataNodeWrapper(0);

// Insert data on sender
TestUtils.executeNonQueries(
senderEnv,
Arrays.asList(
"insert into root.db.d1 (time, at1) values (1000, 1), (1500, 2), (2000, 3), (2500, 4), (3000, 5)",
"flush"),
null);

// Create pipe
final String sql =
String.format(
"create pipe a2b with source ('history.enable'='false') with sink ('node-urls'='%s')",
receiverDataNode.getIpAndPortString());

try (final Connection connection = senderEnv.getConnection();
final Statement statement = connection.createStatement()) {
statement.execute(sql);
} catch (final SQLException e) {
fail(e.getMessage());
}

TestUtils.assertDataAlwaysOnEnv(
receiverEnv,
"count timeSeries root.db.**",
"count(timeseries),",
Collections.singleton("0,"));

try (final Connection connection = senderEnv.getConnection();
final Statement statement = connection.createStatement()) {
statement.execute("alter pipe a2b modify source ('history.enable'='true')");
} catch (final SQLException e) {
fail(e.getMessage());
}

TestUtils.assertDataEventuallyOnEnv(
receiverEnv,
"count timeSeries root.db.**",
"count(timeseries),",
Collections.singleton("1,"));
}
}
8 changes: 7 additions & 1 deletion .../main/java/org/apache/iotdb/confignode/procedure/impl/pipe/task/AlterPipeProcedureV2.java
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -21,6 +21,7 @@

import org.apache.iotdb.common.rpc.thrift.TConsensusGroupType;
import org.apache.iotdb.common.rpc.thrift.TSStatus;
import org.apache.iotdb.commons.consensus.index.impl.MinimumProgressIndex;
import org.apache.iotdb.commons.pipe.agent.task.PipeTaskAgent;
import org.apache.iotdb.commons.pipe.agent.task.meta.PipeMeta;
import org.apache.iotdb.commons.pipe.agent.task.meta.PipeRuntimeMeta;
Expand DownExpand Up@@ -209,7 +210,12 @@ public void executeFromCalculateInfoForTask(final ConfigNodeProcedureEnv env) {
updatedConsensusGroupIdToTaskMetaMap.put(
regionGroupId.getId(),
new PipeTaskMeta(
currentPipeTaskMeta.getProgressIndex(),
PipeTaskAgent.isRealtimeOnlyPipe(
currentPipeStaticMeta.getSourceParameters())
&& !PipeTaskAgent.isRealtimeOnlyPipe(
updatedPipeStaticMeta.getSourceParameters())
? MinimumProgressIndex.INSTANCE
: currentPipeTaskMeta.getProgressIndex(),
PipeTaskMeta.isNewlyAdded(currentPipeTaskMeta.getLeaderNodeId())
&& !(!PipeTaskAgent.isHistoryOnlyPipe(
currentPipeStaticMeta.getSourceParameters())
Expand Down
Loading