Skip to content

Pipe: Fixed the bug that separated historical pipe may not include mod on deletion & The pipe without data.insert may be wrongly separated by pipe and transfer data - #17346

Merged
jt2594838 merged 4 commits into
masterfrom
fix-historical-default
Mar 25, 2026

Conversation

@Caideyipi

Copy link
Copy Markdown
Collaborator

Description

As the title said.


This PR has:

  • been self-reviewed.
    • concurrent read
    • concurrent write
    • concurrent read and write
  • added documentation for new or modified features or behaviors.
  • added Javadocs for most classes and all non-trivial methods.
  • added or updated version, license, or notice information
  • added comments explaining the "why" and the intent of the code wherever would not be obvious
    for an unfamiliar reader.
  • added unit tests or modified existing tests to cover new code paths, ensuring the threshold
    for code coverage.
  • added integration tests.
  • been tested in a test IoTDB cluster.

Key changed/added classes (or packages if there are too many classes) in this PR

@jt2594838jt2594838 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Better to add a test

@sonarqubecloud

Copy link
Copy Markdown

Quality Gate FailedQuality Gate failed

Failed conditions
5.5% Duplication on New Code (required ≤ 5%)

See analysis details on SonarQube Cloud

@codecov

codecovBot commented Mar 25, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 0% with 21 lines in your changes missing coverage. Please review.
✅ Project coverage is 39.73%. Comparing base (5a83067) to head (682337f).
⚠️ Report is 5 commits behind head on master.

Files with missing linesPatch %Lines
...ion/config/executor/ClusterConfigTaskExecutor.java0.00%18 Missing ⚠️
...otdb/db/pipe/agent/task/PipeDataNodeTaskAgent.java0.00%3 Missing ⚠️
Additional details and impacted files
@@ Coverage Diff @@## master #17346 +/- ##
============================================
- Coverage 39.75% 39.73% -0.02% 
Complexity 312 312 ============================================
Files 5127 5127 Lines 346243 346277 +34 Branches 44085 44096 +11 ============================================
- Hits 137661 137609 -52 - Misses 208582 208668 +86 

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@jt2594838
jt2594838 merged commit 355a872 into masterMar 25, 2026
28 of 30 checks passed
@jt2594838
jt2594838 deleted the fix-historical-default branch March 25, 2026 09:44
Caideyipi added a commit to Caideyipi/iotdb that referenced this pull request Apr 27, 2026
…d on deletion & The pipe without data.insert may be wrongly separated by pipe and transfer data (apache#17346)
* fix
* fix
* f
jt2594838 pushed a commit that referenced this pull request Jun 9, 2026
* Pipe: Fixed the bug that separated historical pipe may not include mod on deletion & The pipe without data.insert may be wrongly separated by pipe and transfer data (#17346)
* fix
* fix
* f
(cherry picked from commit 355a872)
* Pipe: Made the historical pipe split auto dropped after completion (#17295)
* snapshot
* may-comp
* auto
(cherry picked from commit 9bfe0b0)
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@Caideyipi@jt2594838