Uh oh!
There was an error while loading. Please reload this page.
enhance cppclient tsblock deserialize validation - #17464
Merged
Merged
Conversation
This reverts commit 34b8de4.
jt2594838
approved these changes
Apr 14, 2026
HTHou
commented
Apr 14, 2026
Contributor
you can rebase the branch to fix the CI |
Uh oh!
There was an error while loading. Please reload this page.
jt2594838 pushed a commit
that referenced
this pull request
Apr 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Harden C++ TsBlock deserialization: add bounds checks to
MyStringBufferreads; validate counts and minimum header size inTsBlock::deserialize; reject negative TEXT lengths inBinaryArrayColumnDecoder. Add one Catch2 test for a truncated TsBlock payload. On Windows, use a custom testmainwithWSAStartup/WSACleanupand release the globalSessionbefore exit soctestgets a normal exit code.Files:
Common.cpp,TsBlock.cpp,ColumnDecoder.cpp,sessionIT.cpp,main.cpp