Skip to content

[To dev/1.3] Optimize the configuration logic of dn_thrift_max_frame_size - #17603

Merged
jt2594838 merged 3 commits into
dev/1.3from
codex/cherry-pick-16724-dev-1.3
May 6, 2026
Merged

[To dev/1.3] Optimize the configuration logic of dn_thrift_max_frame_size#17603
jt2594838 merged 3 commits into
dev/1.3from
codex/cherry-pick-16724-dev-1.3

Conversation

@HTHou

@HTHouHTHou commented May 6, 2026

Copy link
Copy Markdown
Contributor

Summary

Cherry-pick the changes from #16724 onto dev/1.3.

This brings over the optimized dn_thrift_max_frame_size configuration logic, including automatic default calculation from JVM max memory and preserving user-configured positive values.

Notes

Validation

./mvnw -pl iotdb-core/datanode -am -DskipTests -Dspotless.check.skip=true -Dcheckstyle.skip=true compile

@HTHouHTHou changed the title [codex] Cherry-pick PR #16724 to dev/1.3Cherry-pick Optimize the configuration logic of dn_thrift_max_frame_size to dev/1.3May 6, 2026
@HTHou
HTHou marked this pull request as ready for review May 6, 2026 06:50
@sonarqubecloud

Copy link
Copy Markdown

@HTHouHTHou changed the title Cherry-pick Optimize the configuration logic of dn_thrift_max_frame_size to dev/1.3[To dev/1.3] Optimize the configuration logic of dn_thrift_max_frame_sizeMay 6, 2026
@codecov

codecovBot commented May 6, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 82.22222% with 8 lines in your changes missing coverage. Please review.
✅ Project coverage is 41.62%. Comparing base (04e6684) to head (e0f4498).

Files with missing linesPatch %Lines
.../org/apache/iotdb/rpc/TElasticFramedTransport.java82.05%7 Missing ⚠️
...e/iotdb/rpc/TCompressedElasticFramedTransport.java0.00%1 Missing ⚠️
Additional details and impacted files
@@ Coverage Diff @@## dev/1.3 #17603 +/- ##
=============================================
- Coverage 41.62% 41.62% -0.01% 
Complexity 234 234 =============================================
Files 3610 3610 Lines 238026 238054 +28 Branches 28892 28896 +4 =============================================
+ Hits 99086 99091 +5 - Misses 138940 138963 +23 

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@jt2594838
jt2594838 merged commit 5b569a5 into dev/1.3May 6, 2026
19 of 20 checks passed
@jt2594838
jt2594838 deleted the codex/cherry-pick-16724-dev-1.3 branch May 6, 2026 09:36
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@HTHou@jt2594838