Uh oh!
There was an error while loading. Please reload this page.
Respect pre-set env vars and add cgroup memory detection in env scripts - #17765
Conversation
There was a problem hiding this comment.
Thanks for tackling this — JVM auto-sizing in containers reading host memory is a real and well-known footgun, and the cgroup v1/v2 dual handling here is the right shape. A few inline suggestions below; nothing blocking. Two file-level notes:
- No automated tests. Cgroup-gated shell behavior is awkward to unit-test, but a small harness that parameterizes the cgroup mount point (default
/sys/fs/cgroup) and runs the function against fixture files would catch regressions cheaply. Acceptable to skip given the PR description confirms manual cluster verification. - Duplication. The same ~17-line block is copy-pasted across
confignode-env.shanddatanode-env.sh. The existingcalculate_memory_sizes()is already duplicated in both files, so this is consistent with the current style — but a follow-up that sources a shared helper fromscripts/conf/iotdb-common.shwould reduce drift.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
CRZbulabula
commented
Jun 16, 2026
The two failing This PR only touches shell/bat scripts (no Java), but the two failures are in a Java pipe test — Root cause: the failing workflow run ( Fix: rebase this branch onto the latest |
04a3d9d to
064cd50CompareMileaRobertStefan
commented
Jun 26, 2026
@CRZbulabula Can we rerun the pipeline now? |
064cd50 to
7e8d1c7CompareUh oh!
There was an error while loading. Please reload this page.
Description
Adds cgroup v1/v2 memory detection.
This PR has:
for an unfamiliar reader.
for code coverage.