Skip to content

[KYUUBI #3527][SPARK][FOLLOWUP] spark.kubernetes.executorEnv should be spark.executorEnv - #3591

Closed
zwangsheng wants to merge 1 commit into
apache:masterfrom
zwangsheng:follow/SPARK_USER_NAME
Closed

[KYUUBI #3527][SPARK][FOLLOWUP] spark.kubernetes.executorEnv should be spark.executorEnv#3591
zwangsheng wants to merge 1 commit into
apache:masterfrom
zwangsheng:follow/SPARK_USER_NAME

Conversation

@zwangsheng

Copy link
Copy Markdown
Contributor

Why are the changes needed?

Fix bug in #3527
Modify spark.kubernetes.executorEnv to spark.executorEnv

How was this patch tested?

  • Add some test cases that check the changes thoroughly including negative and positive cases if possible

  • Add screenshots for manual tests if appropriate

  • Run test locally before make a pull request

  • Unit Test

@pan3793pan3793 changed the title [FOLLOW UP][SPARK] Modify spark.kubernetes.executorEnv to spark.executorEnv[KYUUBI #3527][SPARK][FOLLOWUP] spark.kubernetes.executorEnv should be spark.executorEnvOct 8, 2022
@codecov-commenter

Copy link
Copy Markdown

Codecov Report

Merging #3591 (7254fe9) into master (612a82e) will decrease coverage by 0.05%.
The diff coverage is 100.00%.

@@ Coverage Diff @@## master #3591 +/- ##
============================================
- Coverage 51.81% 51.75% -0.06% 
Complexity 13 13 ============================================
Files 483 483 Lines 26998 26998 Branches 3769 3769 ============================================
- Hits 13988 13974 -14 - Misses 11653 11662 +9 - Partials 1357 1362 +5 
Impacted FilesCoverage Δ
...ache/kyuubi/engine/spark/SparkProcessBuilder.scala86.66% <100.00%> (ø)
.../kyuubi/server/mysql/constant/MySQLErrorCode.scala13.84% <0.00%> (-6.16%)⬇️
...ache/kyuubi/server/mysql/MySQLCommandHandler.scala75.00% <0.00%> (-4.55%)⬇️
...ache/kyuubi/server/mysql/MySQLGenericPackets.scala76.59% <0.00%> (-2.13%)⬇️
...ain/scala/org/apache/kyuubi/engine/EngineRef.scala72.26% <0.00%> (-0.85%)⬇️
...yuubi/server/metadata/jdbc/JDBCMetadataStore.scala89.27% <0.00%> (-0.70%)⬇️
...he/kyuubi/ha/client/etcd/EtcdDiscoveryClient.scala66.25% <0.00%> (-0.63%)⬇️
...a/org/apache/kyuubi/service/TFrontendService.scala91.17% <0.00%> (-0.30%)⬇️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@pan3793pan3793 added this to the v1.6.1 milestone Oct 8, 2022
@pan3793

Copy link
Copy Markdown
Member

Thanks, merging to master/1.6

pan3793 pushed a commit that referenced this pull request Oct 8, 2022
…e spark.executorEnv
### _Why are the changes needed?_
Fix bug in #3527
Modify `spark.kubernetes.executorEnv` to `spark.executorEnv`
### _How was this patch tested?_
- [ ] Add some test cases that check the changes thoroughly including negative and positive cases if possible
- [ ] Add screenshots for manual tests if appropriate
- [ ] [Run test](https://kyuubi.apache.org/docs/latest/develop_tools/testing.html#running-tests) locally before make a pull request
- [x] Unit Test
Closes#3591 from zwangsheng/follow/SPARK_USER_NAME.
Closes#35277254fe9 [zwangsheng] fix executorEnv
Authored-by: zwangsheng <2213335496@qq.com>
Signed-off-by: Cheng Pan <chengpan@apache.org>
(cherry picked from commit fb6516a)
Signed-off-by: Cheng Pan <chengpan@apache.org>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@zwangsheng@codecov-commenter@pan3793