Skip to content

[DEPS] Bump Hadoop 3.3.1 - #757

Closed
pan3793 wants to merge 1 commit into
apache:masterfrom
pan3793:hadoop-3.3
Closed

[DEPS] Bump Hadoop 3.3.1#757
pan3793 wants to merge 1 commit into
apache:masterfrom
pan3793:hadoop-3.3

Conversation

@pan3793

@pan3793pan3793 commented Jul 5, 2021

Copy link
Copy Markdown
Member

Why are the changes needed?

Spark 3.2.0 is out, which bundles Hadoop 3.3.1 shaded client in default. apache/spark#30135

The test failed when using Hadoop 3.3.1 client connects to Yarn Mini Cluster 3.2.2

Cause: java.lang.RuntimeException: org.apache.kyuubi.KyuubiSQLException:java.lang.ClassCastException: org.apache.hadoop.yarn.proto.YarnServiceProtos$GetClusterMetricsRequestProto cannot be cast to org.apache.hadoop.shaded.com.google.protobuf.Message
at org.apache.hadoop.ipc.ProtobufRpcEngine$Invoker.invoke(ProtobufRpcEngine.java:233)
at org.apache.hadoop.ipc.ProtobufRpcEngine$Invoker.invoke(ProtobufRpcEngine.java:123)
at com.sun.proxy.$Proxy12.getClusterMetrics(Unknown Source)
at org.apache.hadoop.yarn.api.impl.pb.client.ApplicationClientProtocolPBClientImpl.getClusterMetrics(ApplicationClientProtocolPBClientImpl.java:271)
at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
at java.lang.reflect.Method.invoke(Method.java:498)
at org.apache.hadoop.io.retry.RetryInvocationHandler.invokeMethod(RetryInvocationHandler.java:422)
at org.apache.hadoop.io.retry.RetryInvocationHandler$Call.invokeMethod(RetryInvocationHandler.java:165)
at org.apache.hadoop.io.retry.RetryInvocationHandler$Call.invoke(RetryInvocationHandler.java:157)
at org.apache.hadoop.io.retry.RetryInvocationHandler$Call.invokeOnce(RetryInvocationHandler.java:95)
at org.apache.hadoop.io.retry.RetryInvocationHandler.invoke(RetryInvocationHandler.java:359)
at com.sun.proxy.$Proxy13.getClusterMetrics(Unknown Source)
at org.apache.hadoop.yarn.client.api.impl.YarnClientImpl.getYarnClusterMetrics(YarnClientImpl.java:638)
at org.apache.spark.deploy.yarn.Client.$anonfun$submitApplication$1(Client.scala:179)
at org.apache.spark.internal.Logging.logInfo(Logging.scala:57)
at org.apache.spark.internal.Logging.logInfo$(Logging.scala:56)
at org.apache.spark.deploy.yarn.Client.logInfo(Client.scala:65)
at org.apache.spark.deploy.yarn.Client.submitApplication(Client.scala:179)
at org.apache.spark.scheduler.cluster.YarnClientSchedulerBackend.start(YarnClientSchedulerBackend.scala:62)
at org.apache.spark.scheduler.TaskSchedulerImpl.start(TaskSchedulerImpl.scala:220)
at org.apache.spark.SparkContext.<init>(SparkContext.scala:581)
at org.apache.spark.SparkContext$.getOrCreate(SparkContext.scala:2690)
at org.apache.spark.sql.SparkSession$Builder.$anonfun$getOrCreate$2(SparkSession.scala:949)
at scala.Option.getOrElse(Option.scala:189)
at org.apache.spark.sql.SparkSession$Builder.getOrCreate(SparkSession.scala:943)
at org.apache.kyuubi.engine.spark.SparkSQLEngine$.createSpark(SparkSQLEngine.scala:103)
at org.apache.kyuubi.engine.spark.SparkSQLEngine$.main(SparkSQLEngine.scala:155)
at org.apache.kyuubi.engine.spark.SparkSQLEngine.main(SparkSQLEngine.scala)
at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
at java.lang.reflect.Method.invoke(Method.java:498)
at org.apache.spark.deploy.JavaMainApplication.start(SparkApplication.scala:52)
at org.apache.spark.deploy.SparkSubmit.org$apache$spark$deploy$SparkSubmit$$runMain(SparkSubmit.scala:955)
at org.apache.spark.deploy.SparkSubmit$$anon$1.run(SparkSubmit.scala:165)
at org.apache.spark.deploy.SparkSubmit$$anon$1.run(SparkSubmit.scala:163)
at java.security.AccessController.doPrivileged(Native Method)
at javax.security.auth.Subject.doAs(Subject.java:422)
at org.apache.hadoop.security.UserGroupInformation.doAs(UserGroupInformation.java:1878)
at org.apache.spark.deploy.SparkSubmit.doRunMain$1(SparkSubmit.scala:163)
at org.apache.spark.deploy.SparkSubmit.submit(SparkSubmit.scala:203)
at org.apache.spark.deploy.SparkSubmit.doSubmit(SparkSubmit.scala:90)
at org.apache.spark.deploy.SparkSubmit$$anon$2.doSubmit(SparkSubmit.scala:1043)
at org.apache.spark.deploy.SparkSubmit$.main(SparkSubmit.scala:1052)
at org.apache.spark.deploy.SparkSubmit.main(SparkSubmit.scala)

How was this patch tested?

  • Add some test cases that check the changes thoroughly including negative and positive cases if possible

  • Add screenshots for manual tests if appropriate

  • Run test locally before make a pull request

@yaooqinn

Copy link
Copy Markdown
Member

only for miniyarn

@codecov-commenter

codecov-commenter commented Jul 5, 2021

Copy link
Copy Markdown

Codecov Report

Merging #757 (dfca351) into master (5c5d43b) will not change coverage.
The diff coverage is n/a.

❗ Current head dfca351 differs from pull request most recent head c669509. Consider uploading reports for the commit c669509 to get more accurate results
Impacted file tree graph

@@ Coverage Diff @@## master #757 +/- ##
======================================
Coverage 0.00% 0.00% ======================================
Files 122 122 Lines 4749 4749 Branches 576 576 ======================================
Misses 4749 4749 

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5c5d43b...c669509. Read the comment docs.

@pan3793

Copy link
Copy Markdown
MemberAuthor

I didn't see benefits of Hadoop 3.3.1 :(

@pan3793

Copy link
Copy Markdown
MemberAuthor

@pan3793pan3793 changed the title [WIP] [DEPS] Bump Hadoop 3.3.1[DEPS] Bump Hadoop 3.3.1Oct 19, 2021
@pan3793

Copy link
Copy Markdown
MemberAuthor

cc @zhouyifan279, would you please check if this upgrade breaks the Hive/Kerberos related functions?

@pan3793pan3793 self-assigned this Oct 19, 2021
@pan3793pan3793 added this to the v1.4.0 milestone Oct 19, 2021
@pan3793pan3793 mentioned this pull request Oct 19, 2021
14 tasks
@codecov-commenter

codecov-commenter commented Oct 19, 2021

Copy link
Copy Markdown

Codecov Report

Merging #757 (e88937e) into master (f4094d6) will not change coverage.
The diff coverage is n/a.

❗ Current head e88937e differs from pull request most recent head 7ec9313. Consider uploading reports for the commit 7ec9313 to get more accurate results
Impacted file tree graph

@@ Coverage Diff @@## master #757 +/- ##
=========================================
Coverage 73.10% 73.10% Complexity 41 41 =========================================
Files 175 175 Lines 6848 6848 Branches 835 835 =========================================
Hits 5006 5006 Misses 1441 1441 Partials 401 401 

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f4094d6...7ec9313. Read the comment docs.

@ulysses-you

Copy link
Copy Markdown
Contributor

thanks, merged to master

@pan3793
pan3793 deleted the hadoop-3.3 branch October 19, 2021 04:40
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

@pan3793@yaooqinn@codecov-commenter@ulysses-you