Skip to content

Remove unavailable vendors - #2061

Open
SamuelMarks wants to merge 2 commits into
apache:trunkfrom
SamuelMarks:remove-old-0
Open

Remove unavailable vendors#2061
SamuelMarks wants to merge 2 commits into
apache:trunkfrom
SamuelMarks:remove-old-0

Conversation

@SamuelMarks

@SamuelMarksSamuelMarks commented Mar 19, 2025

Copy link
Copy Markdown
Contributor

Remove unavailable vendors

Description

Closes#2057

EDIT: Also removed the associated documentation and sorted vendors.

Status

  • done, ready for review

Checklist (tick everything that applies)

CopilotAI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This pull request removes multiple vendor integrations (drivers, tests, fixtures, and documentation) for vendors that appear to be unavailable, and reorders various provider registries / generated support matrices accordingly.

Changes:

  • Removed AuroraObjects (storage) and AuroraDNS (DNS) drivers and their associated tests/fixtures/docs/examples.
  • Removed AuroraCompute and InternetSolutions (compute) drivers and their associated tests/docs/examples.
  • Updated provider registries / constants and edited generated “supported providers/methods” documentation tables.

Reviewed changes

Copilot reviewed 46 out of 50 changed files in this pull request and generated 6 comments.

Show a summary per file
FileDescription
libcloud/test/storage/test_aurora.pyRemoves AuroraObjects storage driver tests.
libcloud/test/secrets.py-distRemoves AuroraDNS test secret parameters.
libcloud/test/dns/test_auroradns.pyRemoves AuroraDNS driver test suite.
libcloud/test/dns/fixtures/auroradns/zone_list.jsonRemoves AuroraDNS test fixture.
libcloud/test/dns/fixtures/auroradns/zone_example_com.jsonRemoves AuroraDNS test fixture.
libcloud/test/dns/fixtures/auroradns/zone_example_com_records.jsonRemoves AuroraDNS test fixture.
libcloud/test/dns/fixtures/auroradns/zone_example_com_record_localhost.jsonRemoves AuroraDNS test fixture.
libcloud/test/dns/fixtures/auroradns/zone_example_com_health_checks.jsonRemoves AuroraDNS test fixture.
libcloud/test/dns/fixtures/auroradns/zone_example_com_health_check.jsonRemoves AuroraDNS test fixture.
libcloud/test/dns/fixtures/auroradns/zone_create.jsonRemoves AuroraDNS test fixture.
libcloud/test/compute/test_internetsolutions.pyRemoves InternetSolutions compute driver tests.
libcloud/test/compute/test_auroracompute.pyRemoves AuroraCompute compute driver tests.
libcloud/storage/types.pyRemoves AuroraObjects storage provider constant and reorders provider constants/docs.
libcloud/storage/providers.pyRemoves AuroraObjects driver registration.
libcloud/storage/drivers/auroraobjects.pyRemoves AuroraObjects storage driver implementation.
libcloud/dns/types.pyRemoves AuroraDNS DNS provider constant.
libcloud/dns/providers.pyRemoves AuroraDNS driver registration and reorders DNS driver registry.
libcloud/dns/drivers/auroradns.pyRemoves AuroraDNS driver implementation.
libcloud/compute/types.pyRemoves AuroraCompute / InternetSolutions provider constants and reorders compute provider constants.
libcloud/compute/providers.pyRemoves AuroraCompute / InternetSolutions driver registrations and reorders compute driver registry.
libcloud/compute/drivers/internetsolutions.pyRemoves InternetSolutions compute driver implementation.
libcloud/compute/drivers/auroracompute.pyRemoves AuroraCompute compute driver implementation.
libcloud/compute/drivers/init.pyUpdates exported compute driver modules list.
docs/storage/drivers/auroraobjects.rstRemoves AuroraObjects storage driver documentation page.
docs/examples/storage/auroraobjects/instantiate.pyRemoves AuroraObjects storage example.
docs/examples/storage/auroraobjects/init.pyExample package marker file (present in PR file list).
docs/examples/dns/auroradns/instantiate_driver.pyRemoves AuroraDNS example.
docs/examples/dns/auroradns/health_checks.pyRemoves AuroraDNS example.
docs/examples/dns/auroradns/enable_disable_record.pyRemoves AuroraDNS example.
docs/examples/dns/auroradns/init.pyExample package marker file (present in PR file list).
docs/examples/compute/internetsolutions/instantiate_driver.pyRemoves InternetSolutions compute example.
docs/examples/compute/internetsolutions/init.pyExample package marker file (present in PR file list).
docs/examples/compute/auroracompute/instantiate_driver.pyRemoves AuroraCompute compute example.
docs/examples/compute/auroracompute/instantiate_driver_region.pyRemoves AuroraCompute region example.
docs/examples/compute/auroracompute/create_node.pyRemoves AuroraCompute create-node example.
docs/examples/compute/auroracompute/init.pyExample package marker file (present in PR file list).
docs/dns/drivers/auroradns.rstRemoves AuroraDNS documentation page.
docs/dns/_supported_providers.rstRemoves AuroraDNS from DNS supported-providers matrix and reorders rows.
docs/dns/_supported_methods.rstRemoves AuroraDNS from DNS supported-methods matrix and reorders rows.
docs/compute/drivers/internetsolutions.rstRemoves InternetSolutions documentation page.
docs/compute/drivers/dimensiondata.rstRemoves DimensionData compute documentation page.
docs/compute/drivers/auroracompute.rstRemoves AuroraCompute documentation page.
docs/compute/_supported_providers.rstReorders compute supported-providers matrix (still contains stale entries).
docs/compute/_supported_methods_main.rstReorders compute supported-methods matrix (still contains stale entries).
docs/compute/_supported_methods_key_pair_management.rstReorders compute supported-methods matrix (still contains stale entries).
docs/compute/_supported_methods_image_management.rstReorders compute supported-methods matrix (still contains stale entries).
docs/compute/_supported_methods_block_storage.rstReorders compute supported-methods matrix (still contains stale entries).
docs/backup/drivers/dimensiondata.rstRemoves DimensionData backup documentation page.
docs/backup/_supported_providers.rstRemoves DimensionData backup entry from supported-providers matrix.
docs/backup/_supported_methods.rstRemoves DimensionData backup entry from supported-methods matrix.
Comments suppressed due to low confidence (2)

libcloud/compute/drivers/init.py:26

  • dimensiondata was removed from libcloud.compute.drivers.__all__, but the DimensionData compute driver is still registered via Provider.DIMENSIONDATA in libcloud.compute.providers.DRIVERS. This makes from libcloud.compute.drivers import dimensiondata fail and creates an inconsistent public surface. Either re-add dimensiondata to __all__ or complete the DimensionData removal (provider constant + driver + docs) so the API is consistent.
__all__ = [
"abiquo",
"brightbox",
"dummy",
"ec2",
"cloudsigma",
"gce",

docs/compute/_supported_providers.rst:40

  • PCextreme AuroraCompute is still listed here and links to /compute/drivers/auroracompute, but the AuroraCompute driver and its doc page are removed in this PR. This row should be removed (or the driver/doc restored) to avoid stale docs and broken links.
`PCextreme AuroraCompute`_ :doc:`Click </compute/drivers/auroracompute>` AURORACOMPUTE single region driver :mod:`libcloud.compute.drivers.auroracompute` :class:`AuroraComputeNodeDriver`

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment on lines +41 to 46
Provider.CLOUDSIGMA: ("libcloud.compute.drivers.cloudsigma", "CloudSigmaNodeDriver"),
Provider.CLOUDSTACK: ("libcloud.compute.drivers.cloudstack", "CloudStackNodeDriver"),
Provider.DIGITAL_OCEAN: ("libcloud.compute.drivers.digitalocean", "DigitalOceanNodeDriver"),
Provider.DIMENSIONDATA: ("libcloud.compute.drivers.dimensiondata", "DimensionDataNodeDriver"),
Provider.DUMMY: ("libcloud.compute.drivers.dummy", "DummyNodeDriver"),
Provider.EC2: ("libcloud.compute.drivers.ec2", "EC2NodeDriver"),
`CloudStack`_ :doc:`Click </compute/drivers/cloudstack>` CLOUDSTACK single region driver :mod:`libcloud.compute.drivers.cloudstack` :class:`CloudStackNodeDriver`
`Cloudscale`_ :doc:`Click </compute/drivers/cloudscale>` CLOUDSCALE single region driver :mod:`libcloud.compute.drivers.cloudscale` :class:`CloudscaleNodeDriver`
`DigitalOcean`_ :doc:`Click </compute/drivers/digital_ocean>` DIGITAL_OCEAN single region driver :mod:`libcloud.compute.drivers.digitalocean` :class:`DigitalOceanNodeDriver`
`DimensionData`_ :doc:`Click </compute/drivers/dimensiondata>` DIMENSIONDATA single region driver :mod:`libcloud.compute.drivers.dimensiondata` :class:`DimensionDataNodeDriver`
`Outscale INC`_ yes yes yes yes yes yes yes yes yes
`Outscale SAS`_ yes yes yes yes yes yes yes yes yes
`Ovh`_ yes yes no yes no no yes yes yes
`PCextreme AuroraCompute`_ yes yes yes yes no no yes yes yes
`Outscale INC`_ yes yes yes yes no yes
`Outscale SAS`_ yes yes yes yes no yes
`Ovh`_ yes yes no yes no yes
`PCextreme AuroraCompute`_ yes yes yes yes no yes
`Outscale INC`_ yes yes yes yes yes yes yes
`Outscale SAS`_ yes yes yes yes yes yes yes
`Ovh`_ yes yes yes yes yes yes yes
`PCextreme AuroraCompute`_ yes yes yes yes yes no yes
@@ -6,15 +6,13 @@ Provider list images get image create image delete image c
`Abiquo`_ yes no no no no
`Aliyun ECS`_ yes yes yes yes yes
`PCextreme AuroraCompute`_ yes no no no no
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Remove unavailable cloud vendors: auroracompute; InternetSolutions; dimension data

2 participants

@SamuelMarks