Uh oh!
There was an error while loading. Please reload this page.
Add OVH VPS compute driver support - #2127
Open
ciekawy wants to merge 4 commits into
Open
Conversation
OVH VPS is a separate product line from Public Cloud that uses the proprietary /vps/ API. This adds 7 extension methods to OvhNodeDriver: ex_list_vps, ex_get_vps, ex_reboot_vps, ex_start_vps, ex_stop_vps, ex_rebuild_vps, and ex_list_vps_images. Includes unit tests with mock fixtures and updated documentation.
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@## trunk #2127 +/- ##
==========================================
+ Coverage 83.34% 83.36% +0.02%
==========================================
Files 351 351 Lines 81202 81312 +110 Branches 8721 8725 +4 ==========================================
+ Hits 67676 67781 +105 - Misses 10736 10739 +3 - Partials 2790 2792 +2
🚀 New features to boost your workflow:
|
Contributor
There was a problem hiding this comment.
Pull request overview
Adds OVH VPS (Virtual Private Server) management support to the existing OVH compute driver by introducing provider-specific ex_* methods which target OVH’s /vps/ REST API (distinct from the Public Cloud /cloud/project/ endpoints).
Changes:
- Extend
OvhNodeDriverwith VPS operations (ex_list_vps,ex_get_vps, start/stop/reboot, rebuild, and image listing) plus internal conversion helpers and a VPS→NodeStatemapping. - Add unit tests and mock HTTP handlers/fixtures covering the new VPS endpoints.
- Document VPS usage in the OVH driver documentation.
Reviewed changes
Copilot reviewed 10 out of 10 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| libcloud/compute/drivers/ovh.py | Adds VPS extension methods, state mapping, and object conversion helpers. |
| libcloud/test/compute/test_ovh.py | Adds mock handlers and test cases validating the new VPS APIs and state mapping. |
| libcloud/test/compute/fixtures/ovh/vps_get.json | Fixture for GET /vps (VPS name list). |
| libcloud/test/compute/fixtures/ovh/vps_get_detail.json | Fixture for GET /vps/{name} (VPS detail payload). |
| libcloud/test/compute/fixtures/ovh/vps_reboot_post.json | Fixture for POST /vps/{name}/reboot response. |
| libcloud/test/compute/fixtures/ovh/vps_start_post.json | Fixture for POST /vps/{name}/start response. |
| libcloud/test/compute/fixtures/ovh/vps_stop_post.json | Fixture for POST /vps/{name}/stop response. |
| libcloud/test/compute/fixtures/ovh/vps_rebuild_post.json | Fixture for POST /vps/{name}/rebuild response. |
| libcloud/test/compute/fixtures/ovh/vps_images_available_get.json | Fixture for GET /vps/{name}/images/available response. |
| docs/compute/drivers/ovh.rst | Documents VPS support and provides example usage for the new methods. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Add OVH VPS (Virtual Private Server) management support to the existing OVH compute driver.
OVH VPS is a separate product line from OVH Public Cloud instances. It uses the proprietary
/vps/REST API instead of the/cloud/project/OpenStack-based endpoints. Currently, no existing infrastructure tool (Terraform, Ansible, Libcloud) provides VPS management — only the raw OVH Python SDK can do it.This PR extends
OvhNodeDriverwith 7ex_-prefixed extension methods (following Libcloud convention for provider-specific functionality):ex_list_vps()GET /vpsex_get_vps(name)GET /vps/{name}Nodeobjectex_reboot_vps(name)POST /vps/{name}/rebootex_start_vps(name)POST /vps/{name}/startex_stop_vps(name)POST /vps/{name}/stopex_rebuild_vps(name, image_id, ssh_key)POST /vps/{name}/rebuildex_list_vps_images(name)GET /vps/{name}/images/availableAdditionally includes
_to_vps_node()and_to_vps_images()internal converters and aVPS_STATE_MAPfor mapping VPS-specific states toNodeState.Changes
libcloud/compute/drivers/ovh.py— 7 new public methods + 2 internal converters + state map (~150 lines)libcloud/test/compute/test_ovh.py— 10 new test cases for all VPS methodslibcloud/test/compute/fixtures/ovh/vps_*.json— 7 JSON mock fixturesdocs/compute/drivers/ovh.rst— VPS usage documentation with code examplesDesign Decisions
OvhConnectionworks as-is for/vps/endpointsex_prefix convention: VPS methods are provider-specific extensions, not standard Libcloud compute interfacevps-12345678.vps.ovh.net) as the primary identifier, which becomes theNode.idex_project_idrequired: VPS endpoints don't need a cloud project ID, but the constructor still requires one for Public Cloud compatibilityTest Plan