Uh oh!
There was an error while loading. Please reload this page.
fix(docs): collapse three org-level security placeholder names into one - #1133
Open
AmirF194 wants to merge 1 commit into
Open
fix(docs): collapse three org-level security placeholder names into one#1133AmirF194 wants to merge 1 commit into
AmirF194 wants to merge 1 commit into
Conversation
The org-level advisory-admin security address had three names in the tree: <security-team-list> in github-advisory.md, <asf-security-list> (twice) in AGENTS.md, and the bare config path security_inbox.foundation_security_address in the placeholder table, which had no row for it at all. AGENTS.md also baked an ASF-specific name into a framework whose placeholder mechanism exists precisely to keep adopting projects out of that vocabulary. Register <foundation-security-list>, sourced from security_inbox.foundation_security_address, and use it at all three call sites. The distinct project-level <security-list> is untouched, since the two addresses are deliberately different in github-advisory.md's own delivery instructions. Fixesapache#1057 Generated-by: Claude Code (Sonnet 5)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
<security-team-list>,<asf-security-list>, and the baresecurity_inbox.foundation_security_addressconfig path) and none was registered in the placeholder table.<asf-security-list>also bakes an ASF-specific name into a framework whose placeholder mechanism exists to keep adopting projects vendor-neutral.<foundation-security-list>, and uses it at all three call sites. The distinct project-level<security-list>is untouched, sincegithub-advisory.md's own delivery instructions deliberately address the two lists separately.Type of change
.claude/skills/<name>/) - eval fixtures updated belowtools/<system>/*.md)tools/*/withpyproject.toml)docs/,README.md,CONTRIBUTING.md)projects/_template/)prek, workflows, validators)Test plan
prek run --all-filesnot available in this environment (nouv/prek); ran the individual hooks by hand instead:tools/dev/check-placeholders.sh,npx markdownlint-cli2andtyposon both changed files, and thedoctoccheck (no TOC change needed;skills/**is excluded from the doctoc hook andAGENTS.md's TOC is unaffected by a text-only edit). All clean.PYTHONPATH=tools/skill-and-tool-validator/src python3 -c "from skill_and_tool_validator import main; main()"(the same entry pointuv run skill-and-tool-validatecalls) reports the same 29 pre-existing soft warnings before and after this change, none on the touched files.tools/*/package.RFC-AI-0004 compliance
<asf-security-list>) with an org-neutral one, matching<governance-body>and<project-stage>Linked issues
Fixes#1057
Notes for reviewers (optional)
Followed the naming this issue itself suggests, matching the config key:
<foundation-security-list>rather than<org-security-list>.projects/_template/project.mdalready documentssecurity_inbox.foundation_security_addressas org-level and inherited ("Do not declare it here"), so no change was needed there.