Skip to content

fix(skill-evals): repoint version-consistency suite at renumbered Step 8 - #830

Merged
potiuk merged 1 commit into
apache:mainfrom
justinmclean:verify-rc-version-consistency-eval-step8
Jul 12, 2026
Merged

fix(skill-evals): repoint version-consistency suite at renumbered Step 8#830
potiuk merged 1 commit into
apache:mainfrom
justinmclean:verify-rc-version-consistency-eval-step8

Conversation

@justinmclean

Copy link
Copy Markdown
Member

Summary

PR #829 inserted "Step 7 — Source-tree integrity" into the release-verify-rc skill, bumping "Version string consistency" from Step 7 to Step 8. The eval fixture still referenced "## Step 7 — Version string consistency", which no longer exists in SKILL.md, so load_step_config raised ValueError and aborted the entire eval run (all step-configs load up front).

Rename step-7-version-consistency -> step-8-version-consistency and update the step-config heading, the output-spec title, and the README suite table and grading rules to Step 8.

Generated-by: Claude (Claude Opus 4.8)

Type of change

  • Skill change (.claude/skills/<name>/) — eval fixtures updated below
  • Tool / bridge contract (tools/<system>/*.md)
  • Python package (tools/*/ with pyproject.toml)
  • Groovy reference impl
  • Cross-cutting (RFC, AGENTS.md, sandbox, privacy-LLM)
  • Documentation (docs/, README.md, CONTRIBUTING.md)
  • Project template (projects/_template/)
  • CI / dev loop (prek, workflows, validators)
  • Other:

Test plan

  • prek run --all-files passes
  • For Python packages touched: uv run pytest / ruff check / mypy passes
  • For Groovy bridges touched: command-line invocation tested end-to-end
  • For skill changes: eval suite passes for the affected skill
    (PYTHONPATH=tools/skill-evals/src python3 -m skill_evals.runner tools/skill-evals/evals/<skill>/)
  • For skill behaviour changes: a new or updated eval fixture is included in this PR
    (a regression test for the bug fixed / the behaviour added — see CONTRIBUTING.md)
  • Other:

PR apache#829 inserted "Step 7 — Source-tree integrity" into the release-verify-rc
skill, bumping "Version string consistency" from Step 7 to Step 8. The eval
fixture still referenced "## Step 7 — Version string consistency", which no
longer exists in SKILL.md, so load_step_config raised ValueError and aborted
the entire eval run (all step-configs load up front).

Rename step-7-version-consistency -> step-8-version-consistency and update the
step-config heading, the output-spec title, and the README suite table and
grading rules to Step 8.

Generated-by: Claude (Claude Opus 4.8)
@justinmclean justinmclean self-assigned this Jul 12, 2026
@potiuk
potiuk merged commit 20546b8 into apache:main Jul 12, 2026
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants