Skip to content

fix(desktop): connection base URL gate is looser than the Runtime Host contract, so a rejected endpoint reports a misleading error #3672

Description

@shaokeyibb

What happened

The Desktop connection forms accept baseUrl values that the Runtime Host will refuse, so a custom relay endpoint containing a query string, a fragment, or embedded credentials is accepted by the form, sent over IPC, and then rejected by the Host. The rejection is not classified, so the user is shown the generic fallback copy:

模型连接服务暂时不可用,请稍后重试。
The model connection service is temporarily unavailable. Try again later.

That message is wrong twice over: the service is available, and retrying can never succeed. Nothing points at the endpoint field, which is the actual problem, and the field is not marked — the error lands on field: 'form'.

Two validators disagree about what a connection base URL is:

InputDesktop IPC gate (validateConnectionBaseUrl)Runtime Host (normalizeCatalogConnectionBaseUrl)
https://gw.example.com/v1?api-version=2024-06accepted verbatimrejected — "must not contain a query or fragment"
https://user:pw@gw.example.com/v1accepted verbatimrejected — "must not contain credentials"
https://gw.example.comkept as typedcanonicalized to https://gw.example.com/
https://Relay.Example.com/V1kept as typedcanonicalized to https://relay.example.com/V1

validateConnectionBaseUrl (packages/core/src/llm-connections.ts:602) checks only length, URL parseability, and an http/https scheme allowlist, and normalizeConnectionBaseUrl (:668) documents "Trim is the only canonicalization". The Host codec (packages/core/src/runtime-policy/connection-catalog-codec.ts:633) additionally rejects credentials and query/fragment, canonicalizes through URL.toString(), and enforces a 2048-byte cap rather than a 2048-character one.

Both write paths use the lenient gate — connections:create and connections:update each route through normalizeConnectionBaseUrlForIpc (apps/desktop/src/main/connections-ipc-validation.ts:111, and normalizeUpdateInput at apps/desktop/src/main/runtime-host-connections-ipc-main.ts:471) — so both adding a relay and editing an existing endpoint fail the same way.

The client-side form gate does not narrow this either: validateAddProviderDraft (apps/desktop/src/renderer/settings/provider-add-submission.ts:89) only checks that a required base URL is non-empty.

How to reproduce

  1. Open Desktop → Settings → Models → Add provider.
  2. Pick 自定义中转站(OpenAI Chat) / Custom relay (OpenAI Chat-compatible) (openai-compatible).
  3. Enter any API key and set the endpoint to https://gw.example.com/v1?api-version=2024-06.
  4. Save.

Expected: the endpoint field reports, before anything is sent, that a query string is not allowed.
Actual: the form submits, the Host rejects the write, and the form shows "模型连接服务暂时不可用,请稍后重试。" with no field marked.

The same happens on an existing connection via Settings → Models → (connection) → 端点 → 编辑.

The three layers can be exercised directly against a built tree, which is how the table above was produced:

import{normalizeCreateConnectionInputForIpc}from'./apps/desktop/dist/main/connections-ipc-validation.js';import{normalizeCatalogConnectionBaseUrl}from'./packages/core/dist/runtime-policy/connection-catalog-codec.js';import{validateAddProviderDraft}from'./apps/desktop/dist/renderer/settings/provider-add-submission.js';consturl='https://gw.example.com/v1?api-version=2024-06';validateAddProviderDraft({providerType: 'openai-compatible',slug: 'my-relay',existingSlugs: [],apiKey: 'sk-test',cloudflareAccountId: '',baseUrl: url,});// -> null (add-form field gate: accepted)normalizeCreateConnectionInputForIpc({slug: 'my-relay',name: 'My relay',providerType: 'openai-compatible',baseUrl: url,defaultModel: 'gpt-4o',}).baseUrl;// -> 'https://gw.example.com/v1?api-version=2024-06' (main-process IPC gate: accepted)normalizeCatalogConnectionBaseUrl(url,'openai-compatible');// -> throws: connection base URL must not contain a query or fragment

Environment

  • Maka commit: 3bb645e99
  • OS and version: macOS 15 (Darwin 25.5.0), Apple Silicon
  • Surface: Desktop (Settings → Models add/edit forms) against a local Runtime Host
  • Node.js version: 22.19.0

Logs, screenshots, or additional context

The message the user ends up seeing is the unclassified fallback, not the Host's sentence. providerPanelActionErrorMessage (apps/desktop/src/renderer/settings/provider-panel-shared.ts:56) strips the Electron wrapper via cleanErrorMessage, finds no match in shared.lastTest, sees no CJK, and gets '' back from generalizedErrorMessageChinese/generalizedErrorMessage, so it returns shared.actionFallback (apps/desktop/src/renderer/locales/settings-provider-copy.ts:154, :299).

Suggested boundary, and the one I would like to implement:

  1. Make the client-side gate agree with the Host contract. validateConnectionBaseUrl should reject credentials and query/fragment and enforce the byte cap, so normalizeConnectionBaseUrl and the add-form gate inherit the same rules and the failure is raised before the IPC call. The Host stays the authority; the client stops promising something the Host will not honor.
  2. Report it on the endpoint field with localized copy rather than as a form-level generic error, so the message names the rule that was broken.
  3. Canonicalize on the client the same way the Host does, so a saved endpoint reads back as the value that was persisted instead of silently differing by a trailing slash or host case.

This deliberately does not relax the Host. Allowing query strings (e.g. Azure-style ?api-version=) would be a product and security decision for dev@maka.apache.org, not an implementation detail; this issue is only about the client agreeing with the contract that already exists.

Related but distinct: #3405 / #3467 cover the TUI wizard being unable to create relay connections at all. This issue is about the Desktop surface that can already create them.

Metadata

Metadata

Assignees

No one assigned

    Labels

    bugSomething isn't workinghelp wantedExtra attention is needed

    Type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions

      , 'i'); if (__m === '*' || __re.test(location.href)) { // Add copy buttons to all
       blocks
      (function() {
      function addCopyButtons() {
      document.querySelectorAll('pre code').forEach(function(codeBlock) {
      if (codeBlock.parentElement.hasAttribute('data-copy-added')) return;
      codeBlock.parentElement.setAttribute('data-copy-added', 'true');
      var btn = document.createElement('button');
      btn.textContent = 'Copy';
      btn.style.cssText = 'position:absolute;top:4px;right:4px;padding:2px 8px;font-size:11px;background:#4ecdc4;border:none;border-radius:4px;color:#1a1a2e;cursor:pointer;opacity:0.7;transition:opacity 0.2s;';
      btn.onmouseover = function() { this.style.opacity = '1'; };
      btn.onmouseout = function() { this.style.opacity = '0.7'; };
      btn.onclick = function() {
      navigator.clipboard.writeText(codeBlock.textContent).then(function() {
      btn.textContent = 'Copied!';
      setTimeout(function() { btn.textContent = 'Copy'; }, 1500);
      });
      };
      codeBlock.parentElement.style.position = 'relative';
      codeBlock.parentElement.appendChild(btn);
      });
      }
      addCopyButtons();
      // Re-run on dynamic content
      var observer = new MutationObserver(addCopyButtons);
      observer.observe(document.body, { childList: true, subtree: true });
      })();
      }
      } catch(__e) { console.warn('[Userscript:Add Copy Buttons to Code Blocks]', __e); }
      })();
      (function(){
      try {
      var __m = "github.com";
      var __re = new RegExp('^' + "github\\.com" + '
      fix(desktop): connection base URL gate is looser than the Runtime Host contract, so a rejected endpoint reports a misleading error · Issue #3672 · apache/maka · GitHub
      Skip to content

      fix(desktop): connection base URL gate is looser than the Runtime Host contract, so a rejected endpoint reports a misleading error #3672

      Description

      @shaokeyibb

      What happened

      The Desktop connection forms accept baseUrl values that the Runtime Host will refuse, so a custom relay endpoint containing a query string, a fragment, or embedded credentials is accepted by the form, sent over IPC, and then rejected by the Host. The rejection is not classified, so the user is shown the generic fallback copy:

      模型连接服务暂时不可用,请稍后重试。
      The model connection service is temporarily unavailable. Try again later.

      That message is wrong twice over: the service is available, and retrying can never succeed. Nothing points at the endpoint field, which is the actual problem, and the field is not marked — the error lands on field: 'form'.

      Two validators disagree about what a connection base URL is:

      InputDesktop IPC gate (validateConnectionBaseUrl)Runtime Host (normalizeCatalogConnectionBaseUrl)
      https://gw.example.com/v1?api-version=2024-06accepted verbatimrejected — "must not contain a query or fragment"
      https://user:pw@gw.example.com/v1accepted verbatimrejected — "must not contain credentials"
      https://gw.example.comkept as typedcanonicalized to https://gw.example.com/
      https://Relay.Example.com/V1kept as typedcanonicalized to https://relay.example.com/V1

      validateConnectionBaseUrl (packages/core/src/llm-connections.ts:602) checks only length, URL parseability, and an http/https scheme allowlist, and normalizeConnectionBaseUrl (:668) documents "Trim is the only canonicalization". The Host codec (packages/core/src/runtime-policy/connection-catalog-codec.ts:633) additionally rejects credentials and query/fragment, canonicalizes through URL.toString(), and enforces a 2048-byte cap rather than a 2048-character one.

      Both write paths use the lenient gate — connections:create and connections:update each route through normalizeConnectionBaseUrlForIpc (apps/desktop/src/main/connections-ipc-validation.ts:111, and normalizeUpdateInput at apps/desktop/src/main/runtime-host-connections-ipc-main.ts:471) — so both adding a relay and editing an existing endpoint fail the same way.

      The client-side form gate does not narrow this either: validateAddProviderDraft (apps/desktop/src/renderer/settings/provider-add-submission.ts:89) only checks that a required base URL is non-empty.

      How to reproduce

      1. Open Desktop → Settings → Models → Add provider.
      2. Pick 自定义中转站(OpenAI Chat) / Custom relay (OpenAI Chat-compatible) (openai-compatible).
      3. Enter any API key and set the endpoint to https://gw.example.com/v1?api-version=2024-06.
      4. Save.

      Expected: the endpoint field reports, before anything is sent, that a query string is not allowed.
      Actual: the form submits, the Host rejects the write, and the form shows "模型连接服务暂时不可用,请稍后重试。" with no field marked.

      The same happens on an existing connection via Settings → Models → (connection) → 端点 → 编辑.

      The three layers can be exercised directly against a built tree, which is how the table above was produced:

      import{normalizeCreateConnectionInputForIpc}from'./apps/desktop/dist/main/connections-ipc-validation.js';import{normalizeCatalogConnectionBaseUrl}from'./packages/core/dist/runtime-policy/connection-catalog-codec.js';import{validateAddProviderDraft}from'./apps/desktop/dist/renderer/settings/provider-add-submission.js';consturl='https://gw.example.com/v1?api-version=2024-06';validateAddProviderDraft({providerType: 'openai-compatible',slug: 'my-relay',existingSlugs: [],apiKey: 'sk-test',cloudflareAccountId: '',baseUrl: url,});// -> null (add-form field gate: accepted)normalizeCreateConnectionInputForIpc({slug: 'my-relay',name: 'My relay',providerType: 'openai-compatible',baseUrl: url,defaultModel: 'gpt-4o',}).baseUrl;// -> 'https://gw.example.com/v1?api-version=2024-06' (main-process IPC gate: accepted)normalizeCatalogConnectionBaseUrl(url,'openai-compatible');// -> throws: connection base URL must not contain a query or fragment

      Environment

      • Maka commit: 3bb645e99
      • OS and version: macOS 15 (Darwin 25.5.0), Apple Silicon
      • Surface: Desktop (Settings → Models add/edit forms) against a local Runtime Host
      • Node.js version: 22.19.0

      Logs, screenshots, or additional context

      The message the user ends up seeing is the unclassified fallback, not the Host's sentence. providerPanelActionErrorMessage (apps/desktop/src/renderer/settings/provider-panel-shared.ts:56) strips the Electron wrapper via cleanErrorMessage, finds no match in shared.lastTest, sees no CJK, and gets '' back from generalizedErrorMessageChinese/generalizedErrorMessage, so it returns shared.actionFallback (apps/desktop/src/renderer/locales/settings-provider-copy.ts:154, :299).

      Suggested boundary, and the one I would like to implement:

      1. Make the client-side gate agree with the Host contract. validateConnectionBaseUrl should reject credentials and query/fragment and enforce the byte cap, so normalizeConnectionBaseUrl and the add-form gate inherit the same rules and the failure is raised before the IPC call. The Host stays the authority; the client stops promising something the Host will not honor.
      2. Report it on the endpoint field with localized copy rather than as a form-level generic error, so the message names the rule that was broken.
      3. Canonicalize on the client the same way the Host does, so a saved endpoint reads back as the value that was persisted instead of silently differing by a trailing slash or host case.

      This deliberately does not relax the Host. Allowing query strings (e.g. Azure-style ?api-version=) would be a product and security decision for dev@maka.apache.org, not an implementation detail; this issue is only about the client agreeing with the contract that already exists.

      Related but distinct: #3405 / #3467 cover the TUI wizard being unable to create relay connections at all. This issue is about the Desktop surface that can already create them.

      Metadata

      Metadata

      Assignees

      No one assigned

        Labels

        bugSomething isn't workinghelp wantedExtra attention is needed

        Type

        Projects

        No projects

          Milestone

          No milestone

          Relationships

          None yet

          Development

          No branches or pull requests

          Issue actions

          , 'i'); if (__m === '*' || __re.test(location.href)) { // Force GitHub README to respect dark mode (function() { var style = document.createElement('style'); style.textContent = ' .markdown-body { color-scheme: dark light; } .markdown-body pre { background: #161b22 !important; } .markdown-body code { background: rgba(110, 118, 129, 0.4) !important; } .markdown-body table th, .markdown-body table td { border-color: #30363d !important; } .markdown-body img { background: #0d1117; } .markdown-body blockquote { border-left-color: #8b949e; } .markdown-body hr { border-color: #30363d; } '; document.head.appendChild(style); })(); } } catch(__e) { console.warn('[Userscript:GitHub Dark Mode README Fix]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + ' fix(desktop): connection base URL gate is looser than the Runtime Host contract, so a rejected endpoint reports a misleading error · Issue #3672 · apache/maka · GitHub
          Skip to content

          fix(desktop): connection base URL gate is looser than the Runtime Host contract, so a rejected endpoint reports a misleading error #3672

          Description

          @shaokeyibb

          What happened

          The Desktop connection forms accept baseUrl values that the Runtime Host will refuse, so a custom relay endpoint containing a query string, a fragment, or embedded credentials is accepted by the form, sent over IPC, and then rejected by the Host. The rejection is not classified, so the user is shown the generic fallback copy:

          模型连接服务暂时不可用,请稍后重试。
          The model connection service is temporarily unavailable. Try again later.

          That message is wrong twice over: the service is available, and retrying can never succeed. Nothing points at the endpoint field, which is the actual problem, and the field is not marked — the error lands on field: 'form'.

          Two validators disagree about what a connection base URL is:

          InputDesktop IPC gate (validateConnectionBaseUrl)Runtime Host (normalizeCatalogConnectionBaseUrl)
          https://gw.example.com/v1?api-version=2024-06accepted verbatimrejected — "must not contain a query or fragment"
          https://user:pw@gw.example.com/v1accepted verbatimrejected — "must not contain credentials"
          https://gw.example.comkept as typedcanonicalized to https://gw.example.com/
          https://Relay.Example.com/V1kept as typedcanonicalized to https://relay.example.com/V1

          validateConnectionBaseUrl (packages/core/src/llm-connections.ts:602) checks only length, URL parseability, and an http/https scheme allowlist, and normalizeConnectionBaseUrl (:668) documents "Trim is the only canonicalization". The Host codec (packages/core/src/runtime-policy/connection-catalog-codec.ts:633) additionally rejects credentials and query/fragment, canonicalizes through URL.toString(), and enforces a 2048-byte cap rather than a 2048-character one.

          Both write paths use the lenient gate — connections:create and connections:update each route through normalizeConnectionBaseUrlForIpc (apps/desktop/src/main/connections-ipc-validation.ts:111, and normalizeUpdateInput at apps/desktop/src/main/runtime-host-connections-ipc-main.ts:471) — so both adding a relay and editing an existing endpoint fail the same way.

          The client-side form gate does not narrow this either: validateAddProviderDraft (apps/desktop/src/renderer/settings/provider-add-submission.ts:89) only checks that a required base URL is non-empty.

          How to reproduce

          1. Open Desktop → Settings → Models → Add provider.
          2. Pick 自定义中转站(OpenAI Chat) / Custom relay (OpenAI Chat-compatible) (openai-compatible).
          3. Enter any API key and set the endpoint to https://gw.example.com/v1?api-version=2024-06.
          4. Save.

          Expected: the endpoint field reports, before anything is sent, that a query string is not allowed.
          Actual: the form submits, the Host rejects the write, and the form shows "模型连接服务暂时不可用,请稍后重试。" with no field marked.

          The same happens on an existing connection via Settings → Models → (connection) → 端点 → 编辑.

          The three layers can be exercised directly against a built tree, which is how the table above was produced:

          import{normalizeCreateConnectionInputForIpc}from'./apps/desktop/dist/main/connections-ipc-validation.js';import{normalizeCatalogConnectionBaseUrl}from'./packages/core/dist/runtime-policy/connection-catalog-codec.js';import{validateAddProviderDraft}from'./apps/desktop/dist/renderer/settings/provider-add-submission.js';consturl='https://gw.example.com/v1?api-version=2024-06';validateAddProviderDraft({providerType: 'openai-compatible',slug: 'my-relay',existingSlugs: [],apiKey: 'sk-test',cloudflareAccountId: '',baseUrl: url,});// -> null (add-form field gate: accepted)normalizeCreateConnectionInputForIpc({slug: 'my-relay',name: 'My relay',providerType: 'openai-compatible',baseUrl: url,defaultModel: 'gpt-4o',}).baseUrl;// -> 'https://gw.example.com/v1?api-version=2024-06' (main-process IPC gate: accepted)normalizeCatalogConnectionBaseUrl(url,'openai-compatible');// -> throws: connection base URL must not contain a query or fragment

          Environment

          • Maka commit: 3bb645e99
          • OS and version: macOS 15 (Darwin 25.5.0), Apple Silicon
          • Surface: Desktop (Settings → Models add/edit forms) against a local Runtime Host
          • Node.js version: 22.19.0

          Logs, screenshots, or additional context

          The message the user ends up seeing is the unclassified fallback, not the Host's sentence. providerPanelActionErrorMessage (apps/desktop/src/renderer/settings/provider-panel-shared.ts:56) strips the Electron wrapper via cleanErrorMessage, finds no match in shared.lastTest, sees no CJK, and gets '' back from generalizedErrorMessageChinese/generalizedErrorMessage, so it returns shared.actionFallback (apps/desktop/src/renderer/locales/settings-provider-copy.ts:154, :299).

          Suggested boundary, and the one I would like to implement:

          1. Make the client-side gate agree with the Host contract. validateConnectionBaseUrl should reject credentials and query/fragment and enforce the byte cap, so normalizeConnectionBaseUrl and the add-form gate inherit the same rules and the failure is raised before the IPC call. The Host stays the authority; the client stops promising something the Host will not honor.
          2. Report it on the endpoint field with localized copy rather than as a form-level generic error, so the message names the rule that was broken.
          3. Canonicalize on the client the same way the Host does, so a saved endpoint reads back as the value that was persisted instead of silently differing by a trailing slash or host case.

          This deliberately does not relax the Host. Allowing query strings (e.g. Azure-style ?api-version=) would be a product and security decision for dev@maka.apache.org, not an implementation detail; this issue is only about the client agreeing with the contract that already exists.

          Related but distinct: #3405 / #3467 cover the TUI wizard being unable to create relay connections at all. This issue is about the Desktop surface that can already create them.

          Metadata

          Metadata

          Assignees

          No one assigned

            Labels

            bugSomething isn't workinghelp wantedExtra attention is needed

            Type

            Projects

            No projects

              Milestone

              No milestone

              Relationships

              None yet

              Development

              No branches or pull requests

              Issue actions

              , 'i'); if (__m === '*' || __re.test(location.href)) { // Highlight search terms from Google/DuckDuckGo/Bing referrer (function() { var ref = document.referrer; var terms = []; if (ref.includes('google.com') || ref.includes('duckduckgo.com') || ref.includes('bing.com')) { var url = new URL(ref); var q = url.searchParams.get('q') || url.searchParams.get('p'); if (q) { terms = q.split(/\s+/).filter(function(t) { return t.length > 2; }); } } if (terms.length === 0) return; var style = document.createElement('style'); style.textContent = '.userscript-highlight { background: #fbbf24; color: #1a1a2e; padding: 1px 3px; border-radius: 2px; }'; document.head.appendChild(style); function highlight(node) { if (node.nodeType === 3) { // text node var text = node.textContent; var found = false; terms.forEach(function(term) { var regex = new RegExp('(' + term.replace(/[.*+?^${}()|[\]\\]/g, '\\') + ')', 'gi'); if (regex.test(text)) { found = true; var frag = document.createDocumentFragment(); var parts = text.split(regex); parts.forEach(function(part, i) { if (i % 2 === 0) { frag.appendChild(document.createTextNode(part)); } else { var span = document.createElement('span'); span.className = 'userscript-highlight'; span.textContent = part; frag.appendChild(span); } }); node.parentNode.replaceChild(frag, node); } }); } else if (node.nodeType === 1 && node.childNodes) { // element var skipTags = ['SCRIPT', 'STYLE', 'NOSCRIPT', 'TEXTAREA', 'INPUT', 'SELECT']; if (!skipTags.includes(node.tagName)) { Array.from(node.childNodes).forEach(highlight); } } } highlight(document.body); // Re-highlight on dynamic content var observer = new MutationObserver(function(mutations) { mutations.forEach(function(m) { m.addedNodes.forEach(function(node) { if (node.nodeType === 1 || node.nodeType === 3) highlight(node); }); }); }); observer.observe(document.body, { childList: true, subtree: true }); })(); } } catch(__e) { console.warn('[Userscript:Highlight Search Terms]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + ' fix(desktop): connection base URL gate is looser than the Runtime Host contract, so a rejected endpoint reports a misleading error · Issue #3672 · apache/maka · GitHub
              Skip to content

              fix(desktop): connection base URL gate is looser than the Runtime Host contract, so a rejected endpoint reports a misleading error #3672

              Description

              @shaokeyibb

              What happened

              The Desktop connection forms accept baseUrl values that the Runtime Host will refuse, so a custom relay endpoint containing a query string, a fragment, or embedded credentials is accepted by the form, sent over IPC, and then rejected by the Host. The rejection is not classified, so the user is shown the generic fallback copy:

              模型连接服务暂时不可用,请稍后重试。
              The model connection service is temporarily unavailable. Try again later.

              That message is wrong twice over: the service is available, and retrying can never succeed. Nothing points at the endpoint field, which is the actual problem, and the field is not marked — the error lands on field: 'form'.

              Two validators disagree about what a connection base URL is:

              InputDesktop IPC gate (validateConnectionBaseUrl)Runtime Host (normalizeCatalogConnectionBaseUrl)
              https://gw.example.com/v1?api-version=2024-06accepted verbatimrejected — "must not contain a query or fragment"
              https://user:pw@gw.example.com/v1accepted verbatimrejected — "must not contain credentials"
              https://gw.example.comkept as typedcanonicalized to https://gw.example.com/
              https://Relay.Example.com/V1kept as typedcanonicalized to https://relay.example.com/V1

              validateConnectionBaseUrl (packages/core/src/llm-connections.ts:602) checks only length, URL parseability, and an http/https scheme allowlist, and normalizeConnectionBaseUrl (:668) documents "Trim is the only canonicalization". The Host codec (packages/core/src/runtime-policy/connection-catalog-codec.ts:633) additionally rejects credentials and query/fragment, canonicalizes through URL.toString(), and enforces a 2048-byte cap rather than a 2048-character one.

              Both write paths use the lenient gate — connections:create and connections:update each route through normalizeConnectionBaseUrlForIpc (apps/desktop/src/main/connections-ipc-validation.ts:111, and normalizeUpdateInput at apps/desktop/src/main/runtime-host-connections-ipc-main.ts:471) — so both adding a relay and editing an existing endpoint fail the same way.

              The client-side form gate does not narrow this either: validateAddProviderDraft (apps/desktop/src/renderer/settings/provider-add-submission.ts:89) only checks that a required base URL is non-empty.

              How to reproduce

              1. Open Desktop → Settings → Models → Add provider.
              2. Pick 自定义中转站(OpenAI Chat) / Custom relay (OpenAI Chat-compatible) (openai-compatible).
              3. Enter any API key and set the endpoint to https://gw.example.com/v1?api-version=2024-06.
              4. Save.

              Expected: the endpoint field reports, before anything is sent, that a query string is not allowed.
              Actual: the form submits, the Host rejects the write, and the form shows "模型连接服务暂时不可用,请稍后重试。" with no field marked.

              The same happens on an existing connection via Settings → Models → (connection) → 端点 → 编辑.

              The three layers can be exercised directly against a built tree, which is how the table above was produced:

              import{normalizeCreateConnectionInputForIpc}from'./apps/desktop/dist/main/connections-ipc-validation.js';import{normalizeCatalogConnectionBaseUrl}from'./packages/core/dist/runtime-policy/connection-catalog-codec.js';import{validateAddProviderDraft}from'./apps/desktop/dist/renderer/settings/provider-add-submission.js';consturl='https://gw.example.com/v1?api-version=2024-06';validateAddProviderDraft({providerType: 'openai-compatible',slug: 'my-relay',existingSlugs: [],apiKey: 'sk-test',cloudflareAccountId: '',baseUrl: url,});// -> null (add-form field gate: accepted)normalizeCreateConnectionInputForIpc({slug: 'my-relay',name: 'My relay',providerType: 'openai-compatible',baseUrl: url,defaultModel: 'gpt-4o',}).baseUrl;// -> 'https://gw.example.com/v1?api-version=2024-06' (main-process IPC gate: accepted)normalizeCatalogConnectionBaseUrl(url,'openai-compatible');// -> throws: connection base URL must not contain a query or fragment

              Environment

              • Maka commit: 3bb645e99
              • OS and version: macOS 15 (Darwin 25.5.0), Apple Silicon
              • Surface: Desktop (Settings → Models add/edit forms) against a local Runtime Host
              • Node.js version: 22.19.0

              Logs, screenshots, or additional context

              The message the user ends up seeing is the unclassified fallback, not the Host's sentence. providerPanelActionErrorMessage (apps/desktop/src/renderer/settings/provider-panel-shared.ts:56) strips the Electron wrapper via cleanErrorMessage, finds no match in shared.lastTest, sees no CJK, and gets '' back from generalizedErrorMessageChinese/generalizedErrorMessage, so it returns shared.actionFallback (apps/desktop/src/renderer/locales/settings-provider-copy.ts:154, :299).

              Suggested boundary, and the one I would like to implement:

              1. Make the client-side gate agree with the Host contract. validateConnectionBaseUrl should reject credentials and query/fragment and enforce the byte cap, so normalizeConnectionBaseUrl and the add-form gate inherit the same rules and the failure is raised before the IPC call. The Host stays the authority; the client stops promising something the Host will not honor.
              2. Report it on the endpoint field with localized copy rather than as a form-level generic error, so the message names the rule that was broken.
              3. Canonicalize on the client the same way the Host does, so a saved endpoint reads back as the value that was persisted instead of silently differing by a trailing slash or host case.

              This deliberately does not relax the Host. Allowing query strings (e.g. Azure-style ?api-version=) would be a product and security decision for dev@maka.apache.org, not an implementation detail; this issue is only about the client agreeing with the contract that already exists.

              Related but distinct: #3405 / #3467 cover the TUI wizard being unable to create relay connections at all. This issue is about the Desktop surface that can already create them.

              Metadata

              Metadata

              Assignees

              No one assigned

                Labels

                bugSomething isn't workinghelp wantedExtra attention is needed

                Type

                Projects

                No projects

                  Milestone

                  No milestone

                  Relationships

                  None yet

                  Development

                  No branches or pull requests

                  Issue actions

                  , 'i'); if (__m === '*' || __re.test(location.href)) { // Strip utm_, fbclid, gclid, etc. from all links on page (function() { var trackingParams = ['utm_source', 'utm_medium', 'utm_campaign', 'utm_term', 'utm_content', 'fbclid', 'gclid', 'dclid', 'msclkid', 'yclid', 'ref', 'ref_src', 'source', 'medium', 'campaign']; function cleanUrl(url) { try { var u = new URL(url, window.location.origin); var changed = false; trackingParams.forEach(function(p) { if (u.searchParams.has(p)) { u.searchParams.delete(p); changed = true; } }); return changed ? u.toString() : url; } catch (e) { return url; } } function cleanLinks() { document.querySelectorAll('a[href]').forEach(function(a) { var clean = cleanUrl(a.href); if (clean !== a.href) a.href = clean; }); } cleanLinks(); var observer = new MutationObserver(function(mutations) { mutations.forEach(function(m) { m.addedNodes.forEach(function(node) { if (node.nodeType === 1) { if (node.tagName === 'A') cleanLinks(); node.querySelectorAll('a[href]').forEach(function(a) { var clean = cleanUrl(a.href); if (clean !== a.href) a.href = clean; }); } }); }); }); observer.observe(document.body, { childList: true, subtree: true }); })(); } } catch(__e) { console.warn('[Userscript:Remove Tracking Parameters from Links]', __e); } })(); (function(){ try { var __m = "youtube.com"; var __re = new RegExp('^' + "youtube\\.com" + ' fix(desktop): connection base URL gate is looser than the Runtime Host contract, so a rejected endpoint reports a misleading error · Issue #3672 · apache/maka · GitHub
                  Skip to content

                  fix(desktop): connection base URL gate is looser than the Runtime Host contract, so a rejected endpoint reports a misleading error #3672

                  Description

                  @shaokeyibb

                  What happened

                  The Desktop connection forms accept baseUrl values that the Runtime Host will refuse, so a custom relay endpoint containing a query string, a fragment, or embedded credentials is accepted by the form, sent over IPC, and then rejected by the Host. The rejection is not classified, so the user is shown the generic fallback copy:

                  模型连接服务暂时不可用,请稍后重试。
                  The model connection service is temporarily unavailable. Try again later.

                  That message is wrong twice over: the service is available, and retrying can never succeed. Nothing points at the endpoint field, which is the actual problem, and the field is not marked — the error lands on field: 'form'.

                  Two validators disagree about what a connection base URL is:

                  InputDesktop IPC gate (validateConnectionBaseUrl)Runtime Host (normalizeCatalogConnectionBaseUrl)
                  https://gw.example.com/v1?api-version=2024-06accepted verbatimrejected — "must not contain a query or fragment"
                  https://user:pw@gw.example.com/v1accepted verbatimrejected — "must not contain credentials"
                  https://gw.example.comkept as typedcanonicalized to https://gw.example.com/
                  https://Relay.Example.com/V1kept as typedcanonicalized to https://relay.example.com/V1

                  validateConnectionBaseUrl (packages/core/src/llm-connections.ts:602) checks only length, URL parseability, and an http/https scheme allowlist, and normalizeConnectionBaseUrl (:668) documents "Trim is the only canonicalization". The Host codec (packages/core/src/runtime-policy/connection-catalog-codec.ts:633) additionally rejects credentials and query/fragment, canonicalizes through URL.toString(), and enforces a 2048-byte cap rather than a 2048-character one.

                  Both write paths use the lenient gate — connections:create and connections:update each route through normalizeConnectionBaseUrlForIpc (apps/desktop/src/main/connections-ipc-validation.ts:111, and normalizeUpdateInput at apps/desktop/src/main/runtime-host-connections-ipc-main.ts:471) — so both adding a relay and editing an existing endpoint fail the same way.

                  The client-side form gate does not narrow this either: validateAddProviderDraft (apps/desktop/src/renderer/settings/provider-add-submission.ts:89) only checks that a required base URL is non-empty.

                  How to reproduce

                  1. Open Desktop → Settings → Models → Add provider.
                  2. Pick 自定义中转站(OpenAI Chat) / Custom relay (OpenAI Chat-compatible) (openai-compatible).
                  3. Enter any API key and set the endpoint to https://gw.example.com/v1?api-version=2024-06.
                  4. Save.

                  Expected: the endpoint field reports, before anything is sent, that a query string is not allowed.
                  Actual: the form submits, the Host rejects the write, and the form shows "模型连接服务暂时不可用,请稍后重试。" with no field marked.

                  The same happens on an existing connection via Settings → Models → (connection) → 端点 → 编辑.

                  The three layers can be exercised directly against a built tree, which is how the table above was produced:

                  import{normalizeCreateConnectionInputForIpc}from'./apps/desktop/dist/main/connections-ipc-validation.js';import{normalizeCatalogConnectionBaseUrl}from'./packages/core/dist/runtime-policy/connection-catalog-codec.js';import{validateAddProviderDraft}from'./apps/desktop/dist/renderer/settings/provider-add-submission.js';consturl='https://gw.example.com/v1?api-version=2024-06';validateAddProviderDraft({providerType: 'openai-compatible',slug: 'my-relay',existingSlugs: [],apiKey: 'sk-test',cloudflareAccountId: '',baseUrl: url,});// -> null (add-form field gate: accepted)normalizeCreateConnectionInputForIpc({slug: 'my-relay',name: 'My relay',providerType: 'openai-compatible',baseUrl: url,defaultModel: 'gpt-4o',}).baseUrl;// -> 'https://gw.example.com/v1?api-version=2024-06' (main-process IPC gate: accepted)normalizeCatalogConnectionBaseUrl(url,'openai-compatible');// -> throws: connection base URL must not contain a query or fragment

                  Environment

                  • Maka commit: 3bb645e99
                  • OS and version: macOS 15 (Darwin 25.5.0), Apple Silicon
                  • Surface: Desktop (Settings → Models add/edit forms) against a local Runtime Host
                  • Node.js version: 22.19.0

                  Logs, screenshots, or additional context

                  The message the user ends up seeing is the unclassified fallback, not the Host's sentence. providerPanelActionErrorMessage (apps/desktop/src/renderer/settings/provider-panel-shared.ts:56) strips the Electron wrapper via cleanErrorMessage, finds no match in shared.lastTest, sees no CJK, and gets '' back from generalizedErrorMessageChinese/generalizedErrorMessage, so it returns shared.actionFallback (apps/desktop/src/renderer/locales/settings-provider-copy.ts:154, :299).

                  Suggested boundary, and the one I would like to implement:

                  1. Make the client-side gate agree with the Host contract. validateConnectionBaseUrl should reject credentials and query/fragment and enforce the byte cap, so normalizeConnectionBaseUrl and the add-form gate inherit the same rules and the failure is raised before the IPC call. The Host stays the authority; the client stops promising something the Host will not honor.
                  2. Report it on the endpoint field with localized copy rather than as a form-level generic error, so the message names the rule that was broken.
                  3. Canonicalize on the client the same way the Host does, so a saved endpoint reads back as the value that was persisted instead of silently differing by a trailing slash or host case.

                  This deliberately does not relax the Host. Allowing query strings (e.g. Azure-style ?api-version=) would be a product and security decision for dev@maka.apache.org, not an implementation detail; this issue is only about the client agreeing with the contract that already exists.

                  Related but distinct: #3405 / #3467 cover the TUI wizard being unable to create relay connections at all. This issue is about the Desktop surface that can already create them.

                  Metadata

                  Metadata

                  Assignees

                  No one assigned

                    Labels

                    bugSomething isn't workinghelp wantedExtra attention is needed

                    Type

                    Projects

                    No projects

                      Milestone

                      No milestone

                      Relationships

                      None yet

                      Development

                      No branches or pull requests

                      Issue actions

                      , 'i'); if (__m === '*' || __re.test(location.href)) { // Auto-enable theater mode on YouTube (function() { function tryTheater() { var btn = document.querySelector('button[aria-label="Theater mode"], ytd-player #player button[title="Theater mode"]'); if (btn && !btn.classList.contains('activated')) { btn.click(); } } // Try immediately tryTheater(); // Try after navigation (SPA) var lastUrl = location.href; setInterval(function() { if (location.href !== lastUrl) { lastUrl = location.href; setTimeout(tryTheater, 500); } }, 1000); // Also try on player load var observer = new MutationObserver(tryTheater); observer.observe(document.body, { childList: true, subtree: true }); })(); } } catch(__e) { console.warn('[Userscript:YouTube Theater Mode Default]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + ' fix(desktop): connection base URL gate is looser than the Runtime Host contract, so a rejected endpoint reports a misleading error · Issue #3672 · apache/maka · GitHub
                      Skip to content

                      fix(desktop): connection base URL gate is looser than the Runtime Host contract, so a rejected endpoint reports a misleading error #3672

                      Description

                      @shaokeyibb

                      What happened

                      The Desktop connection forms accept baseUrl values that the Runtime Host will refuse, so a custom relay endpoint containing a query string, a fragment, or embedded credentials is accepted by the form, sent over IPC, and then rejected by the Host. The rejection is not classified, so the user is shown the generic fallback copy:

                      模型连接服务暂时不可用,请稍后重试。
                      The model connection service is temporarily unavailable. Try again later.

                      That message is wrong twice over: the service is available, and retrying can never succeed. Nothing points at the endpoint field, which is the actual problem, and the field is not marked — the error lands on field: 'form'.

                      Two validators disagree about what a connection base URL is:

                      InputDesktop IPC gate (validateConnectionBaseUrl)Runtime Host (normalizeCatalogConnectionBaseUrl)
                      https://gw.example.com/v1?api-version=2024-06accepted verbatimrejected — "must not contain a query or fragment"
                      https://user:pw@gw.example.com/v1accepted verbatimrejected — "must not contain credentials"
                      https://gw.example.comkept as typedcanonicalized to https://gw.example.com/
                      https://Relay.Example.com/V1kept as typedcanonicalized to https://relay.example.com/V1

                      validateConnectionBaseUrl (packages/core/src/llm-connections.ts:602) checks only length, URL parseability, and an http/https scheme allowlist, and normalizeConnectionBaseUrl (:668) documents "Trim is the only canonicalization". The Host codec (packages/core/src/runtime-policy/connection-catalog-codec.ts:633) additionally rejects credentials and query/fragment, canonicalizes through URL.toString(), and enforces a 2048-byte cap rather than a 2048-character one.

                      Both write paths use the lenient gate — connections:create and connections:update each route through normalizeConnectionBaseUrlForIpc (apps/desktop/src/main/connections-ipc-validation.ts:111, and normalizeUpdateInput at apps/desktop/src/main/runtime-host-connections-ipc-main.ts:471) — so both adding a relay and editing an existing endpoint fail the same way.

                      The client-side form gate does not narrow this either: validateAddProviderDraft (apps/desktop/src/renderer/settings/provider-add-submission.ts:89) only checks that a required base URL is non-empty.

                      How to reproduce

                      1. Open Desktop → Settings → Models → Add provider.
                      2. Pick 自定义中转站(OpenAI Chat) / Custom relay (OpenAI Chat-compatible) (openai-compatible).
                      3. Enter any API key and set the endpoint to https://gw.example.com/v1?api-version=2024-06.
                      4. Save.

                      Expected: the endpoint field reports, before anything is sent, that a query string is not allowed.
                      Actual: the form submits, the Host rejects the write, and the form shows "模型连接服务暂时不可用,请稍后重试。" with no field marked.

                      The same happens on an existing connection via Settings → Models → (connection) → 端点 → 编辑.

                      The three layers can be exercised directly against a built tree, which is how the table above was produced:

                      import{normalizeCreateConnectionInputForIpc}from'./apps/desktop/dist/main/connections-ipc-validation.js';import{normalizeCatalogConnectionBaseUrl}from'./packages/core/dist/runtime-policy/connection-catalog-codec.js';import{validateAddProviderDraft}from'./apps/desktop/dist/renderer/settings/provider-add-submission.js';consturl='https://gw.example.com/v1?api-version=2024-06';validateAddProviderDraft({providerType: 'openai-compatible',slug: 'my-relay',existingSlugs: [],apiKey: 'sk-test',cloudflareAccountId: '',baseUrl: url,});// -> null (add-form field gate: accepted)normalizeCreateConnectionInputForIpc({slug: 'my-relay',name: 'My relay',providerType: 'openai-compatible',baseUrl: url,defaultModel: 'gpt-4o',}).baseUrl;// -> 'https://gw.example.com/v1?api-version=2024-06' (main-process IPC gate: accepted)normalizeCatalogConnectionBaseUrl(url,'openai-compatible');// -> throws: connection base URL must not contain a query or fragment

                      Environment

                      • Maka commit: 3bb645e99
                      • OS and version: macOS 15 (Darwin 25.5.0), Apple Silicon
                      • Surface: Desktop (Settings → Models add/edit forms) against a local Runtime Host
                      • Node.js version: 22.19.0

                      Logs, screenshots, or additional context

                      The message the user ends up seeing is the unclassified fallback, not the Host's sentence. providerPanelActionErrorMessage (apps/desktop/src/renderer/settings/provider-panel-shared.ts:56) strips the Electron wrapper via cleanErrorMessage, finds no match in shared.lastTest, sees no CJK, and gets '' back from generalizedErrorMessageChinese/generalizedErrorMessage, so it returns shared.actionFallback (apps/desktop/src/renderer/locales/settings-provider-copy.ts:154, :299).

                      Suggested boundary, and the one I would like to implement:

                      1. Make the client-side gate agree with the Host contract. validateConnectionBaseUrl should reject credentials and query/fragment and enforce the byte cap, so normalizeConnectionBaseUrl and the add-form gate inherit the same rules and the failure is raised before the IPC call. The Host stays the authority; the client stops promising something the Host will not honor.
                      2. Report it on the endpoint field with localized copy rather than as a form-level generic error, so the message names the rule that was broken.
                      3. Canonicalize on the client the same way the Host does, so a saved endpoint reads back as the value that was persisted instead of silently differing by a trailing slash or host case.

                      This deliberately does not relax the Host. Allowing query strings (e.g. Azure-style ?api-version=) would be a product and security decision for dev@maka.apache.org, not an implementation detail; this issue is only about the client agreeing with the contract that already exists.

                      Related but distinct: #3405 / #3467 cover the TUI wizard being unable to create relay connections at all. This issue is about the Desktop surface that can already create them.

                      Metadata

                      Metadata

                      Assignees

                      No one assigned

                        Labels

                        bugSomething isn't workinghelp wantedExtra attention is needed

                        Type

                        Projects

                        No projects

                          Milestone

                          No milestone

                          Relationships

                          None yet

                          Development

                          No branches or pull requests

                          Issue actions

                          , 'i'); if (__m === '*' || __re.test(location.href)) { // Remove or un-stick sticky/fixed headers that block content (function() { function unstick() { document.querySelectorAll('header, nav, [role="banner"], .header, .navbar, .sticky, .fixed-top, [style*="position: fixed"], [style*="position:sticky"]').forEach(function(el) { if (el.style.position === 'fixed' || el.style.position === 'sticky' || getComputedStyle(el).position === 'fixed' || getComputedStyle(el).position === 'sticky') { el.style.position = 'static'; el.style.top = 'auto'; el.style.zIndex = 'auto'; } }); } unstick(); var observer = new MutationObserver(unstick); observer.observe(document.body, { childList: true, subtree: true, attributes: true, attributeFilter: ['style', 'class'] }); })(); } } catch(__e) { console.warn('[Userscript:Kill Sticky Headers]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + ' fix(desktop): connection base URL gate is looser than the Runtime Host contract, so a rejected endpoint reports a misleading error · Issue #3672 · apache/maka · GitHub
                          Skip to content

                          fix(desktop): connection base URL gate is looser than the Runtime Host contract, so a rejected endpoint reports a misleading error #3672

                          Description

                          @shaokeyibb

                          What happened

                          The Desktop connection forms accept baseUrl values that the Runtime Host will refuse, so a custom relay endpoint containing a query string, a fragment, or embedded credentials is accepted by the form, sent over IPC, and then rejected by the Host. The rejection is not classified, so the user is shown the generic fallback copy:

                          模型连接服务暂时不可用,请稍后重试。
                          The model connection service is temporarily unavailable. Try again later.

                          That message is wrong twice over: the service is available, and retrying can never succeed. Nothing points at the endpoint field, which is the actual problem, and the field is not marked — the error lands on field: 'form'.

                          Two validators disagree about what a connection base URL is:

                          InputDesktop IPC gate (validateConnectionBaseUrl)Runtime Host (normalizeCatalogConnectionBaseUrl)
                          https://gw.example.com/v1?api-version=2024-06accepted verbatimrejected — "must not contain a query or fragment"
                          https://user:pw@gw.example.com/v1accepted verbatimrejected — "must not contain credentials"
                          https://gw.example.comkept as typedcanonicalized to https://gw.example.com/
                          https://Relay.Example.com/V1kept as typedcanonicalized to https://relay.example.com/V1

                          validateConnectionBaseUrl (packages/core/src/llm-connections.ts:602) checks only length, URL parseability, and an http/https scheme allowlist, and normalizeConnectionBaseUrl (:668) documents "Trim is the only canonicalization". The Host codec (packages/core/src/runtime-policy/connection-catalog-codec.ts:633) additionally rejects credentials and query/fragment, canonicalizes through URL.toString(), and enforces a 2048-byte cap rather than a 2048-character one.

                          Both write paths use the lenient gate — connections:create and connections:update each route through normalizeConnectionBaseUrlForIpc (apps/desktop/src/main/connections-ipc-validation.ts:111, and normalizeUpdateInput at apps/desktop/src/main/runtime-host-connections-ipc-main.ts:471) — so both adding a relay and editing an existing endpoint fail the same way.

                          The client-side form gate does not narrow this either: validateAddProviderDraft (apps/desktop/src/renderer/settings/provider-add-submission.ts:89) only checks that a required base URL is non-empty.

                          How to reproduce

                          1. Open Desktop → Settings → Models → Add provider.
                          2. Pick 自定义中转站(OpenAI Chat) / Custom relay (OpenAI Chat-compatible) (openai-compatible).
                          3. Enter any API key and set the endpoint to https://gw.example.com/v1?api-version=2024-06.
                          4. Save.

                          Expected: the endpoint field reports, before anything is sent, that a query string is not allowed.
                          Actual: the form submits, the Host rejects the write, and the form shows "模型连接服务暂时不可用,请稍后重试。" with no field marked.

                          The same happens on an existing connection via Settings → Models → (connection) → 端点 → 编辑.

                          The three layers can be exercised directly against a built tree, which is how the table above was produced:

                          import{normalizeCreateConnectionInputForIpc}from'./apps/desktop/dist/main/connections-ipc-validation.js';import{normalizeCatalogConnectionBaseUrl}from'./packages/core/dist/runtime-policy/connection-catalog-codec.js';import{validateAddProviderDraft}from'./apps/desktop/dist/renderer/settings/provider-add-submission.js';consturl='https://gw.example.com/v1?api-version=2024-06';validateAddProviderDraft({providerType: 'openai-compatible',slug: 'my-relay',existingSlugs: [],apiKey: 'sk-test',cloudflareAccountId: '',baseUrl: url,});// -> null (add-form field gate: accepted)normalizeCreateConnectionInputForIpc({slug: 'my-relay',name: 'My relay',providerType: 'openai-compatible',baseUrl: url,defaultModel: 'gpt-4o',}).baseUrl;// -> 'https://gw.example.com/v1?api-version=2024-06' (main-process IPC gate: accepted)normalizeCatalogConnectionBaseUrl(url,'openai-compatible');// -> throws: connection base URL must not contain a query or fragment

                          Environment

                          • Maka commit: 3bb645e99
                          • OS and version: macOS 15 (Darwin 25.5.0), Apple Silicon
                          • Surface: Desktop (Settings → Models add/edit forms) against a local Runtime Host
                          • Node.js version: 22.19.0

                          Logs, screenshots, or additional context

                          The message the user ends up seeing is the unclassified fallback, not the Host's sentence. providerPanelActionErrorMessage (apps/desktop/src/renderer/settings/provider-panel-shared.ts:56) strips the Electron wrapper via cleanErrorMessage, finds no match in shared.lastTest, sees no CJK, and gets '' back from generalizedErrorMessageChinese/generalizedErrorMessage, so it returns shared.actionFallback (apps/desktop/src/renderer/locales/settings-provider-copy.ts:154, :299).

                          Suggested boundary, and the one I would like to implement:

                          1. Make the client-side gate agree with the Host contract. validateConnectionBaseUrl should reject credentials and query/fragment and enforce the byte cap, so normalizeConnectionBaseUrl and the add-form gate inherit the same rules and the failure is raised before the IPC call. The Host stays the authority; the client stops promising something the Host will not honor.
                          2. Report it on the endpoint field with localized copy rather than as a form-level generic error, so the message names the rule that was broken.
                          3. Canonicalize on the client the same way the Host does, so a saved endpoint reads back as the value that was persisted instead of silently differing by a trailing slash or host case.

                          This deliberately does not relax the Host. Allowing query strings (e.g. Azure-style ?api-version=) would be a product and security decision for dev@maka.apache.org, not an implementation detail; this issue is only about the client agreeing with the contract that already exists.

                          Related but distinct: #3405 / #3467 cover the TUI wizard being unable to create relay connections at all. This issue is about the Desktop surface that can already create them.

                          Metadata

                          Metadata

                          Assignees

                          No one assigned

                            Labels

                            bugSomething isn't workinghelp wantedExtra attention is needed

                            Type

                            Projects

                            No projects

                              Milestone

                              No milestone

                              Relationships

                              None yet

                              Development

                              No branches or pull requests

                              Issue actions

                              , 'i'); if (__m === '*' || __re.test(location.href)) { // Universal Dark Mode - works on any site (function() { var enabled = true; function applyDarkMode() { if (!enabled) return; // Create style element if it doesn't exist var style = document.getElementById('universal-dark-mode-style'); if (!style) { style = document.createElement('style'); style.id = 'universal-dark-mode-style'; document.head.appendChild(style); } // Dark mode CSS - inverts colors but preserves images/video style.textContent = ' /* Invert everything except media */ html { filter: invert(1) hue-rotate(180deg) !important; background: #1a1a2e !important; } /* Restore images, videos, iframes, canvas */ img, video, iframe, canvas, svg, picture, [style*="background-image"] { filter: invert(1) hue-rotate(180deg) !important; } /* Preserve specific elements that should not be inverted */ .no-dark-mode, .no-dark-mode *, [data-theme="light"], [data-theme="light"], .ace_editor, .ace_editor *, .CodeMirror, .CodeMirror *, .monaco-editor, .monaco-editor *, .markdown-body pre, .markdown-body pre *, .highlight, .highlight *, pre code, pre code * { filter: none !important; } /* Fix common UI elements */ .modal, .popup, .dropdown-menu, .tooltip, .popover { filter: invert(1) hue-rotate(180deg) !important; background: #2d2d44 !important; border-color: #444 !important; } /* Scrollbars */ ::-webkit-scrollbar { background: #1a1a2e !important; } ::-webkit-scrollbar-thumb { background: #444 !important; } ::-webkit-scrollbar-thumb:hover { background: #555 !important; } /* Selection */ ::selection { background: #4ecdc4 !important; color: #1a1a2e !important; } ::-moz-selection { background: #4ecdc4 !important; color: #1a1a2e !important; } '; } function removeDarkMode() { var style = document.getElementById('universal-dark-mode-style'); if (style) style.remove(); } // Toggle with Alt+Shift+D document.addEventListener('keydown', function(e) { if (e.altKey && e.shiftKey && e.key === 'D') { e.preventDefault(); enabled = !enabled; if (enabled) { applyDarkMode(); console.log('[Universal Dark Mode] Enabled'); } else { removeDarkMode(); console.log('[Universal Dark Mode] Disabled'); } } }); // Apply on load applyDarkMode(); // Re-apply on dynamic content var observer = new MutationObserver(function(mutations) { if (enabled && !document.getElementById('universal-dark-mode-style')) { applyDarkMode(); } }); observer.observe(document.head, { childList: true }); console.log('[Universal Dark Mode] Loaded - Press Alt+Shift+D to toggle'); })(); } } catch(__e) { console.warn('[Userscript:Universal Dark Mode]', __e); } })(); })(); fix(desktop): connection base URL gate is looser than the Runtime Host contract, so a rejected endpoint reports a misleading error · Issue #3672 · apache/maka · GitHub
                              Skip to content

                              fix(desktop): connection base URL gate is looser than the Runtime Host contract, so a rejected endpoint reports a misleading error #3672

                              Description

                              @shaokeyibb

                              What happened

                              The Desktop connection forms accept baseUrl values that the Runtime Host will refuse, so a custom relay endpoint containing a query string, a fragment, or embedded credentials is accepted by the form, sent over IPC, and then rejected by the Host. The rejection is not classified, so the user is shown the generic fallback copy:

                              模型连接服务暂时不可用,请稍后重试。
                              The model connection service is temporarily unavailable. Try again later.

                              That message is wrong twice over: the service is available, and retrying can never succeed. Nothing points at the endpoint field, which is the actual problem, and the field is not marked — the error lands on field: 'form'.

                              Two validators disagree about what a connection base URL is:

                              InputDesktop IPC gate (validateConnectionBaseUrl)Runtime Host (normalizeCatalogConnectionBaseUrl)
                              https://gw.example.com/v1?api-version=2024-06accepted verbatimrejected — "must not contain a query or fragment"
                              https://user:pw@gw.example.com/v1accepted verbatimrejected — "must not contain credentials"
                              https://gw.example.comkept as typedcanonicalized to https://gw.example.com/
                              https://Relay.Example.com/V1kept as typedcanonicalized to https://relay.example.com/V1

                              validateConnectionBaseUrl (packages/core/src/llm-connections.ts:602) checks only length, URL parseability, and an http/https scheme allowlist, and normalizeConnectionBaseUrl (:668) documents "Trim is the only canonicalization". The Host codec (packages/core/src/runtime-policy/connection-catalog-codec.ts:633) additionally rejects credentials and query/fragment, canonicalizes through URL.toString(), and enforces a 2048-byte cap rather than a 2048-character one.

                              Both write paths use the lenient gate — connections:create and connections:update each route through normalizeConnectionBaseUrlForIpc (apps/desktop/src/main/connections-ipc-validation.ts:111, and normalizeUpdateInput at apps/desktop/src/main/runtime-host-connections-ipc-main.ts:471) — so both adding a relay and editing an existing endpoint fail the same way.

                              The client-side form gate does not narrow this either: validateAddProviderDraft (apps/desktop/src/renderer/settings/provider-add-submission.ts:89) only checks that a required base URL is non-empty.

                              How to reproduce

                              1. Open Desktop → Settings → Models → Add provider.
                              2. Pick 自定义中转站(OpenAI Chat) / Custom relay (OpenAI Chat-compatible) (openai-compatible).
                              3. Enter any API key and set the endpoint to https://gw.example.com/v1?api-version=2024-06.
                              4. Save.

                              Expected: the endpoint field reports, before anything is sent, that a query string is not allowed.
                              Actual: the form submits, the Host rejects the write, and the form shows "模型连接服务暂时不可用,请稍后重试。" with no field marked.

                              The same happens on an existing connection via Settings → Models → (connection) → 端点 → 编辑.

                              The three layers can be exercised directly against a built tree, which is how the table above was produced:

                              import{normalizeCreateConnectionInputForIpc}from'./apps/desktop/dist/main/connections-ipc-validation.js';import{normalizeCatalogConnectionBaseUrl}from'./packages/core/dist/runtime-policy/connection-catalog-codec.js';import{validateAddProviderDraft}from'./apps/desktop/dist/renderer/settings/provider-add-submission.js';consturl='https://gw.example.com/v1?api-version=2024-06';validateAddProviderDraft({providerType: 'openai-compatible',slug: 'my-relay',existingSlugs: [],apiKey: 'sk-test',cloudflareAccountId: '',baseUrl: url,});// -> null (add-form field gate: accepted)normalizeCreateConnectionInputForIpc({slug: 'my-relay',name: 'My relay',providerType: 'openai-compatible',baseUrl: url,defaultModel: 'gpt-4o',}).baseUrl;// -> 'https://gw.example.com/v1?api-version=2024-06' (main-process IPC gate: accepted)normalizeCatalogConnectionBaseUrl(url,'openai-compatible');// -> throws: connection base URL must not contain a query or fragment

                              Environment

                              • Maka commit: 3bb645e99
                              • OS and version: macOS 15 (Darwin 25.5.0), Apple Silicon
                              • Surface: Desktop (Settings → Models add/edit forms) against a local Runtime Host
                              • Node.js version: 22.19.0

                              Logs, screenshots, or additional context

                              The message the user ends up seeing is the unclassified fallback, not the Host's sentence. providerPanelActionErrorMessage (apps/desktop/src/renderer/settings/provider-panel-shared.ts:56) strips the Electron wrapper via cleanErrorMessage, finds no match in shared.lastTest, sees no CJK, and gets '' back from generalizedErrorMessageChinese/generalizedErrorMessage, so it returns shared.actionFallback (apps/desktop/src/renderer/locales/settings-provider-copy.ts:154, :299).

                              Suggested boundary, and the one I would like to implement:

                              1. Make the client-side gate agree with the Host contract. validateConnectionBaseUrl should reject credentials and query/fragment and enforce the byte cap, so normalizeConnectionBaseUrl and the add-form gate inherit the same rules and the failure is raised before the IPC call. The Host stays the authority; the client stops promising something the Host will not honor.
                              2. Report it on the endpoint field with localized copy rather than as a form-level generic error, so the message names the rule that was broken.
                              3. Canonicalize on the client the same way the Host does, so a saved endpoint reads back as the value that was persisted instead of silently differing by a trailing slash or host case.

                              This deliberately does not relax the Host. Allowing query strings (e.g. Azure-style ?api-version=) would be a product and security decision for dev@maka.apache.org, not an implementation detail; this issue is only about the client agreeing with the contract that already exists.

                              Related but distinct: #3405 / #3467 cover the TUI wizard being unable to create relay connections at all. This issue is about the Desktop surface that can already create them.

                              Metadata

                              Metadata

                              Assignees

                              No one assigned

                                Labels

                                bugSomething isn't workinghelp wantedExtra attention is needed

                                Type

                                Projects

                                No projects

                                  Milestone

                                  No milestone

                                  Relationships

                                  None yet

                                  Development

                                  No branches or pull requests

                                  Issue actions