Uh oh!
There was an error while loading. Please reload this page.
fix(runtime): project user question requests - #1002
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
RuntimeEvent reads rejected completed runs containing an action-only
userQuestionRequest, even though the matchingAskUserQuestionfunction call and response already own the legacy transcript rows.Recognize the request as supported live interaction state without creating an additional
StoredMessage. Add a complete function call → question request → function response → terminal regression test.Verification
npm --workspace @maka/runtime testRuntimeReadModelRoot cause
AiSdkFlowbegan writingactions.userQuestionRequest, butprojectRuntimeEventsToStoredMessages()did not classify that action as supported. Because the event intentionally has no message content, it fell through tounsupported_event, causing the read model to reject the entire session.