feat(desktop): localize conversations, sessions, and tools by Mingqwqqaq · Pull Request #1194 · apache/maka

Mingqwqqaq · 2026-07-18T08:41:16Z

Summary

move the complete fake-backend conversation journey into typed zh/en catalogs across @maka/ui and desktop presentation helpers
localize empty/composer states, messages, permissions, sessions, tool activity, errors, timestamps, counts, and accessibility copy through the existing reactive UI locale
preserve user/model/tool/path/command/generated content verbatim while preventing English catalogs from silently falling back to Chinese
keep session refresh/subscription callbacks on the current runtime locale and localize model/attachment/session failure paths
sync the stale workbar E2E contract with fix(shell): unmount the workbar toggle where no workbar exists #1186 (the unavailable toggle is unmounted, not disabled)

Boundary

This is PR 3 of #1052: conversation, session, and tool surfaces.

personalization.uiLocale remains the single persisted preference
the resolved locale remains the single React/Intl authority
auto -> zh remains unchanged until the PR 4 completion gate
remaining specialized desktop surfaces, Follow system resolution, and the final bilingual E2E matrix remain PR 4
user content, model output, tool-owned payloads, brands, code, commands, paths, and generated content are not translated

Verification

Linux ext4 checkout, Node 24.18.0:

npm run lint
npm run build
npm run typecheck
npx knip --workspace apps/desktop
npx knip --workspace packages/ui
npm run build:test
Linux sandbox smoke: 5/5
npm run test:dist: all workspaces passed; desktop 2701/2701
localized conversation/tool focused suites: 15/15
workbar E2E contract: passed in isolation
alignment audit: all fixtures clean

Local WSL/Xvfb runs throttle requestAnimationFrame to ~2 seconds in the two long-scroll geometry tests. The same two timeouts reproduce on unmodified upstream main with identical 31.6k DOM height, 19 steps, 38 frames, and ~31 second deadline; GitHub's hosted E2E job remains the authoritative gate.

Part of #1052.

…ion-session-localization

…ion-session-localization # Conflicts: # apps/desktop/e2e/session-workbar.spec.ts

Astro-Han

Approved. Two non-blocking localization follow-ups:

In the English permission prompt, the stale-request age combines localized wrapper copy with the Chinese-only formatPermissionRequestWait(), so a request older than two minutes renders text such as Waiting for 6 分钟. The duration formatter should become locale-aware.
Collapsed session groups still wrap counts in hard-coded full-width parentheses, producing English labels such as Archived（3）. Moving the count format into the catalog would keep typography locale-correct.

Neither issue blocks this PR. The catalog ownership, reactive locale wiring, and focused coverage look good.

…ion-session-localization # Conflicts: # packages/ui/src/tool-activity/agent-preview.tsx

Astryx expands the pill only when new messages arrived, so the label reads as a notice rather than an action — but the copy this replaced (apache#1194's `jumpLatest`, dropped by apache#1795) said 跳到最新消息, and keeping the wording users already know beats a semantically tidier rename. Co-Authored-By: Claude <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Ac5rv6WUKWtMZgQb5QPN16

* fix(ui): localize the Astryx chrome adopted since #1795 #1795 moved the chat surfaces onto Astryx ChatLayout and deleted the `label={copy.jumpLatest}` that fed Maka's own scroll-to-bottom button, but never registered the replacement `@astryx.*` keys. Astryx ships no zh catalog, so the pill has been reading "New messages" in a Chinese UI ever since — and the same gap covers every other Astryx surface adopted without its copy. Audited all 219 shipped Astryx keys against the components Maka actually renders (JSX usage, not imports — the barrel re-export makes every component look reachable). 79 rendered keys had no override; this adds them, reusing existing entries where the string is identical rather than duplicating (form.clear, primitives.close/loading, selectPlaceholder). Excluded as dead config per this file's own rule: dateInput.dialogLabel and dateInput.placeholder — DateTimeInput references neither, and no standalone DateInput is rendered. The guard test listed `chat` as a surface Maka does not render, which is what let the regression through; it now guards lightbox only, and a new test pins the chat chrome. Co-Authored-By: Claude <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Ac5rv6WUKWtMZgQb5QPN16 * fix(ui): keep 跳到最新消息 for the scroll-to-bottom pill Astryx expands the pill only when new messages arrived, so the label reads as a notice rather than an action — but the copy this replaced (#1194's `jumpLatest`, dropped by #1795) said 跳到最新消息, and keeping the wording users already know beats a semantically tidier rename. Co-Authored-By: Claude <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Ac5rv6WUKWtMZgQb5QPN16 * test(ui): assert the pinned chat overrides exist before checking them `messages[key] ?? ''` coalesced a deleted override to the empty string, which holds no Latin letters and satisfied the translation check on its own — so the loop caught an English value but not a removed key. Verified both ways: deleting the send override now fails with 'missing override', and reverting its copy to English fails with 'untranslated'. Co-Authored-By: Claude <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Ac5rv6WUKWtMZgQb5QPN16 * fix(ui): localize the Lightbox reached via useLightbox The dead-config guard's surviving entry was as stale as the one #1795 invalidated: chat-turn.tsx opens image previews through useLightbox, which renders Astryx's Lightbox — with four English strings — while a JSX-tag scan for <Lightbox> reports the component unrendered. Add the four overrides (close reuses primitives.close) and retire the ban-list guard entirely: a list keyed to "what we render today" rots silently, and both of its entries had. Live surfaces are pinned by presence tests instead. Co-Authored-By: Claude <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Ac5rv6WUKWtMZgQb5QPN16 * test(e2e): match the quote token remove button by its localized name The token remove button read 'Remove {label}' only because Astryx's Token had no zh override; now that @astryx.token.remove is localized the accessible name is 移除…, and the /^Remove / locator times out. The spec already addresses every other control by its Chinese name. Co-Authored-By: Claude <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Ac5rv6WUKWtMZgQb5QPN16 * fix(ui): address review — off-barrel Astryx copy, localize #642 fallback Review findings on #2202, all verified before fixing: - The astryx catalogue expanded SharedUiCopy, which `export *`s through the package barrel — violating the README's off-barrel convention for symbols with no cross-package consumer. It now lives in astryx-copy.ts, deliberately unexported. - The en mirror existed only as a diffable reference and was never applied (astryxMessageOverrides returns undefined for en); dropped rather than left to drift against upstream. - `a` renamed to `astryx`; duplicated presence/Latin-letter assertions extracted into assertChineseAstryxOverrides. - P1: the #642 streaming fallback rendered a bare ChatMessage, which resolves Astryx's shipped 'Message from {sender}' — an English aria-label in a Chinese tree. It now reuses LocalizedChatMessage with the same assistantAriaLabel as the TurnView path. The regression test pins the exact trigger: wait indicators with zero turns — passing a liveTurn instead projects a real turn and takes the localized path, which is how the first draft of the test passed against the bug. Co-Authored-By: Claude <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Ac5rv6WUKWtMZgQb5QPN16 * fix(ui): prune dead overrides, sweep the whole zh map in tests Maintainer review on #2202, each claim verified before acting: - chatSendButton.send/stop: ChatComposerInput never renders ChatSendButton — composer.tsx supplies its own send button. Pruned; the pinned test now anchors on chatToolCalls.error instead. - appShell.mobileNavigation: gated on shouldShowAutoToggle, and Maka passes breakpoint 'none' + hasToggle false. Pruned. - table.noData / table.filter.* / tableFiltering.filterByColumn: the usage table mounts only the rowHeader plugin and renders EmptyState before Table when rows are empty. Pruned. - New whole-map sweep: every override must target a key Astryx ships, hold no Latin outside {…}, and carry the same top-level ICU arguments as the en default — depth-aware extraction, since plural branch text ({result}) reads like an argument to a naive regex and would flag every zh string that drops an inapplicable plural. - Presence-helper comment reworded: the check reads the override map directly, so a deleted entry yields '' here; at runtime the same miss falls back to Astryx's shipped en catalog. Sweep red-validated both ways: a misspelled key fails membership, an English value fails the Latin check. Co-Authored-By: Claude <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Ac5rv6WUKWtMZgQb5QPN16 --------- Co-authored-by: Claude <noreply@anthropic.com>

Mingqwqqaq · 2026-07-18T08:41:16Z

Summary

move the complete fake-backend conversation journey into typed zh/en catalogs across @maka/ui and desktop presentation helpers
localize empty/composer states, messages, permissions, sessions, tool activity, errors, timestamps, counts, and accessibility copy through the existing reactive UI locale
preserve user/model/tool/path/command/generated content verbatim while preventing English catalogs from silently falling back to Chinese
keep session refresh/subscription callbacks on the current runtime locale and localize model/attachment/session failure paths
sync the stale workbar E2E contract with fix(shell): unmount the workbar toggle where no workbar exists #1186 (the unavailable toggle is unmounted, not disabled)

Boundary

This is PR 3 of #1052: conversation, session, and tool surfaces.

personalization.uiLocale remains the single persisted preference
the resolved locale remains the single React/Intl authority
auto -> zh remains unchanged until the PR 4 completion gate
remaining specialized desktop surfaces, Follow system resolution, and the final bilingual E2E matrix remain PR 4
user content, model output, tool-owned payloads, brands, code, commands, paths, and generated content are not translated

Verification

Linux ext4 checkout, Node 24.18.0:

npm run lint
npm run build
npm run typecheck
npx knip --workspace apps/desktop
npx knip --workspace packages/ui
npm run build:test
Linux sandbox smoke: 5/5
npm run test:dist: all workspaces passed; desktop 2701/2701
localized conversation/tool focused suites: 15/15
workbar E2E contract: passed in isolation
alignment audit: all fixtures clean

Local WSL/Xvfb runs throttle requestAnimationFrame to ~2 seconds in the two long-scroll geometry tests. The same two timeouts reproduce on unmodified upstream main with identical 31.6k DOM height, 19 steps, 38 frames, and ~31 second deadline; GitHub's hosted E2E job remains the authoritative gate.

Part of #1052.

…ion-session-localization

…ion-session-localization # Conflicts: # apps/desktop/e2e/session-workbar.spec.ts

Astro-Han

Approved. Two non-blocking localization follow-ups:

In the English permission prompt, the stale-request age combines localized wrapper copy with the Chinese-only formatPermissionRequestWait(), so a request older than two minutes renders text such as Waiting for 6 分钟. The duration formatter should become locale-aware.
Collapsed session groups still wrap counts in hard-coded full-width parentheses, producing English labels such as Archived（3）. Moving the count format into the catalog would keep typography locale-correct.

Neither issue blocks this PR. The catalog ownership, reactive locale wiring, and focused coverage look good.

…ion-session-localization # Conflicts: # packages/ui/src/tool-activity/agent-preview.tsx

Astryx expands the pill only when new messages arrived, so the label reads as a notice rather than an action — but the copy this replaced (apache#1194's `jumpLatest`, dropped by apache#1795) said 跳到最新消息, and keeping the wording users already know beats a semantically tidier rename. Co-Authored-By: Claude <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Ac5rv6WUKWtMZgQb5QPN16

* fix(ui): localize the Astryx chrome adopted since #1795 #1795 moved the chat surfaces onto Astryx ChatLayout and deleted the `label={copy.jumpLatest}` that fed Maka's own scroll-to-bottom button, but never registered the replacement `@astryx.*` keys. Astryx ships no zh catalog, so the pill has been reading "New messages" in a Chinese UI ever since — and the same gap covers every other Astryx surface adopted without its copy. Audited all 219 shipped Astryx keys against the components Maka actually renders (JSX usage, not imports — the barrel re-export makes every component look reachable). 79 rendered keys had no override; this adds them, reusing existing entries where the string is identical rather than duplicating (form.clear, primitives.close/loading, selectPlaceholder). Excluded as dead config per this file's own rule: dateInput.dialogLabel and dateInput.placeholder — DateTimeInput references neither, and no standalone DateInput is rendered. The guard test listed `chat` as a surface Maka does not render, which is what let the regression through; it now guards lightbox only, and a new test pins the chat chrome. Co-Authored-By: Claude <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Ac5rv6WUKWtMZgQb5QPN16 * fix(ui): keep 跳到最新消息 for the scroll-to-bottom pill Astryx expands the pill only when new messages arrived, so the label reads as a notice rather than an action — but the copy this replaced (#1194's `jumpLatest`, dropped by #1795) said 跳到最新消息, and keeping the wording users already know beats a semantically tidier rename. Co-Authored-By: Claude <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Ac5rv6WUKWtMZgQb5QPN16 * test(ui): assert the pinned chat overrides exist before checking them `messages[key] ?? ''` coalesced a deleted override to the empty string, which holds no Latin letters and satisfied the translation check on its own — so the loop caught an English value but not a removed key. Verified both ways: deleting the send override now fails with 'missing override', and reverting its copy to English fails with 'untranslated'. Co-Authored-By: Claude <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Ac5rv6WUKWtMZgQb5QPN16 * fix(ui): localize the Lightbox reached via useLightbox The dead-config guard's surviving entry was as stale as the one #1795 invalidated: chat-turn.tsx opens image previews through useLightbox, which renders Astryx's Lightbox — with four English strings — while a JSX-tag scan for <Lightbox> reports the component unrendered. Add the four overrides (close reuses primitives.close) and retire the ban-list guard entirely: a list keyed to "what we render today" rots silently, and both of its entries had. Live surfaces are pinned by presence tests instead. Co-Authored-By: Claude <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Ac5rv6WUKWtMZgQb5QPN16 * test(e2e): match the quote token remove button by its localized name The token remove button read 'Remove {label}' only because Astryx's Token had no zh override; now that @astryx.token.remove is localized the accessible name is 移除…, and the /^Remove / locator times out. The spec already addresses every other control by its Chinese name. Co-Authored-By: Claude <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Ac5rv6WUKWtMZgQb5QPN16 * fix(ui): address review — off-barrel Astryx copy, localize #642 fallback Review findings on #2202, all verified before fixing: - The astryx catalogue expanded SharedUiCopy, which `export *`s through the package barrel — violating the README's off-barrel convention for symbols with no cross-package consumer. It now lives in astryx-copy.ts, deliberately unexported. - The en mirror existed only as a diffable reference and was never applied (astryxMessageOverrides returns undefined for en); dropped rather than left to drift against upstream. - `a` renamed to `astryx`; duplicated presence/Latin-letter assertions extracted into assertChineseAstryxOverrides. - P1: the #642 streaming fallback rendered a bare ChatMessage, which resolves Astryx's shipped 'Message from {sender}' — an English aria-label in a Chinese tree. It now reuses LocalizedChatMessage with the same assistantAriaLabel as the TurnView path. The regression test pins the exact trigger: wait indicators with zero turns — passing a liveTurn instead projects a real turn and takes the localized path, which is how the first draft of the test passed against the bug. Co-Authored-By: Claude <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Ac5rv6WUKWtMZgQb5QPN16 * fix(ui): prune dead overrides, sweep the whole zh map in tests Maintainer review on #2202, each claim verified before acting: - chatSendButton.send/stop: ChatComposerInput never renders ChatSendButton — composer.tsx supplies its own send button. Pruned; the pinned test now anchors on chatToolCalls.error instead. - appShell.mobileNavigation: gated on shouldShowAutoToggle, and Maka passes breakpoint 'none' + hasToggle false. Pruned. - table.noData / table.filter.* / tableFiltering.filterByColumn: the usage table mounts only the rowHeader plugin and renders EmptyState before Table when rows are empty. Pruned. - New whole-map sweep: every override must target a key Astryx ships, hold no Latin outside {…}, and carry the same top-level ICU arguments as the en default — depth-aware extraction, since plural branch text ({result}) reads like an argument to a naive regex and would flag every zh string that drops an inapplicable plural. - Presence-helper comment reworded: the check reads the override map directly, so a deleted entry yields '' here; at runtime the same miss falls back to Astryx's shipped en catalog. Sweep red-validated both ways: a misspelled key fails membership, an English value fails the Latin check. Co-Authored-By: Claude <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Ac5rv6WUKWtMZgQb5QPN16 --------- Co-authored-by: Claude <noreply@anthropic.com>

Mingqwqqaq · 2026-07-18T08:41:16Z

Summary

move the complete fake-backend conversation journey into typed zh/en catalogs across @maka/ui and desktop presentation helpers
localize empty/composer states, messages, permissions, sessions, tool activity, errors, timestamps, counts, and accessibility copy through the existing reactive UI locale
preserve user/model/tool/path/command/generated content verbatim while preventing English catalogs from silently falling back to Chinese
keep session refresh/subscription callbacks on the current runtime locale and localize model/attachment/session failure paths
sync the stale workbar E2E contract with fix(shell): unmount the workbar toggle where no workbar exists #1186 (the unavailable toggle is unmounted, not disabled)

Boundary

This is PR 3 of #1052: conversation, session, and tool surfaces.

personalization.uiLocale remains the single persisted preference
the resolved locale remains the single React/Intl authority
auto -> zh remains unchanged until the PR 4 completion gate
remaining specialized desktop surfaces, Follow system resolution, and the final bilingual E2E matrix remain PR 4
user content, model output, tool-owned payloads, brands, code, commands, paths, and generated content are not translated

Verification

Linux ext4 checkout, Node 24.18.0:

npm run lint
npm run build
npm run typecheck
npx knip --workspace apps/desktop
npx knip --workspace packages/ui
npm run build:test
Linux sandbox smoke: 5/5
npm run test:dist: all workspaces passed; desktop 2701/2701
localized conversation/tool focused suites: 15/15
workbar E2E contract: passed in isolation
alignment audit: all fixtures clean

Local WSL/Xvfb runs throttle requestAnimationFrame to ~2 seconds in the two long-scroll geometry tests. The same two timeouts reproduce on unmodified upstream main with identical 31.6k DOM height, 19 steps, 38 frames, and ~31 second deadline; GitHub's hosted E2E job remains the authoritative gate.

Part of #1052.

…ion-session-localization

…ion-session-localization # Conflicts: # apps/desktop/e2e/session-workbar.spec.ts

Astro-Han

Approved. Two non-blocking localization follow-ups:

In the English permission prompt, the stale-request age combines localized wrapper copy with the Chinese-only formatPermissionRequestWait(), so a request older than two minutes renders text such as Waiting for 6 分钟. The duration formatter should become locale-aware.
Collapsed session groups still wrap counts in hard-coded full-width parentheses, producing English labels such as Archived（3）. Moving the count format into the catalog would keep typography locale-correct.

Neither issue blocks this PR. The catalog ownership, reactive locale wiring, and focused coverage look good.

…ion-session-localization # Conflicts: # packages/ui/src/tool-activity/agent-preview.tsx

Astryx expands the pill only when new messages arrived, so the label reads as a notice rather than an action — but the copy this replaced (apache#1194's `jumpLatest`, dropped by apache#1795) said 跳到最新消息, and keeping the wording users already know beats a semantically tidier rename. Co-Authored-By: Claude <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Ac5rv6WUKWtMZgQb5QPN16

* fix(ui): localize the Astryx chrome adopted since #1795 #1795 moved the chat surfaces onto Astryx ChatLayout and deleted the `label={copy.jumpLatest}` that fed Maka's own scroll-to-bottom button, but never registered the replacement `@astryx.*` keys. Astryx ships no zh catalog, so the pill has been reading "New messages" in a Chinese UI ever since — and the same gap covers every other Astryx surface adopted without its copy. Audited all 219 shipped Astryx keys against the components Maka actually renders (JSX usage, not imports — the barrel re-export makes every component look reachable). 79 rendered keys had no override; this adds them, reusing existing entries where the string is identical rather than duplicating (form.clear, primitives.close/loading, selectPlaceholder). Excluded as dead config per this file's own rule: dateInput.dialogLabel and dateInput.placeholder — DateTimeInput references neither, and no standalone DateInput is rendered. The guard test listed `chat` as a surface Maka does not render, which is what let the regression through; it now guards lightbox only, and a new test pins the chat chrome. Co-Authored-By: Claude <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Ac5rv6WUKWtMZgQb5QPN16 * fix(ui): keep 跳到最新消息 for the scroll-to-bottom pill Astryx expands the pill only when new messages arrived, so the label reads as a notice rather than an action — but the copy this replaced (#1194's `jumpLatest`, dropped by #1795) said 跳到最新消息, and keeping the wording users already know beats a semantically tidier rename. Co-Authored-By: Claude <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Ac5rv6WUKWtMZgQb5QPN16 * test(ui): assert the pinned chat overrides exist before checking them `messages[key] ?? ''` coalesced a deleted override to the empty string, which holds no Latin letters and satisfied the translation check on its own — so the loop caught an English value but not a removed key. Verified both ways: deleting the send override now fails with 'missing override', and reverting its copy to English fails with 'untranslated'. Co-Authored-By: Claude <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Ac5rv6WUKWtMZgQb5QPN16 * fix(ui): localize the Lightbox reached via useLightbox The dead-config guard's surviving entry was as stale as the one #1795 invalidated: chat-turn.tsx opens image previews through useLightbox, which renders Astryx's Lightbox — with four English strings — while a JSX-tag scan for <Lightbox> reports the component unrendered. Add the four overrides (close reuses primitives.close) and retire the ban-list guard entirely: a list keyed to "what we render today" rots silently, and both of its entries had. Live surfaces are pinned by presence tests instead. Co-Authored-By: Claude <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Ac5rv6WUKWtMZgQb5QPN16 * test(e2e): match the quote token remove button by its localized name The token remove button read 'Remove {label}' only because Astryx's Token had no zh override; now that @astryx.token.remove is localized the accessible name is 移除…, and the /^Remove / locator times out. The spec already addresses every other control by its Chinese name. Co-Authored-By: Claude <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Ac5rv6WUKWtMZgQb5QPN16 * fix(ui): address review — off-barrel Astryx copy, localize #642 fallback Review findings on #2202, all verified before fixing: - The astryx catalogue expanded SharedUiCopy, which `export *`s through the package barrel — violating the README's off-barrel convention for symbols with no cross-package consumer. It now lives in astryx-copy.ts, deliberately unexported. - The en mirror existed only as a diffable reference and was never applied (astryxMessageOverrides returns undefined for en); dropped rather than left to drift against upstream. - `a` renamed to `astryx`; duplicated presence/Latin-letter assertions extracted into assertChineseAstryxOverrides. - P1: the #642 streaming fallback rendered a bare ChatMessage, which resolves Astryx's shipped 'Message from {sender}' — an English aria-label in a Chinese tree. It now reuses LocalizedChatMessage with the same assistantAriaLabel as the TurnView path. The regression test pins the exact trigger: wait indicators with zero turns — passing a liveTurn instead projects a real turn and takes the localized path, which is how the first draft of the test passed against the bug. Co-Authored-By: Claude <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Ac5rv6WUKWtMZgQb5QPN16 * fix(ui): prune dead overrides, sweep the whole zh map in tests Maintainer review on #2202, each claim verified before acting: - chatSendButton.send/stop: ChatComposerInput never renders ChatSendButton — composer.tsx supplies its own send button. Pruned; the pinned test now anchors on chatToolCalls.error instead. - appShell.mobileNavigation: gated on shouldShowAutoToggle, and Maka passes breakpoint 'none' + hasToggle false. Pruned. - table.noData / table.filter.* / tableFiltering.filterByColumn: the usage table mounts only the rowHeader plugin and renders EmptyState before Table when rows are empty. Pruned. - New whole-map sweep: every override must target a key Astryx ships, hold no Latin outside {…}, and carry the same top-level ICU arguments as the en default — depth-aware extraction, since plural branch text ({result}) reads like an argument to a naive regex and would flag every zh string that drops an inapplicable plural. - Presence-helper comment reworded: the check reads the override map directly, so a deleted entry yields '' here; at runtime the same miss falls back to Astryx's shipped en catalog. Sweep red-validated both ways: a misspelled key fails membership, an English value fails the Latin check. Co-Authored-By: Claude <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Ac5rv6WUKWtMZgQb5QPN16 --------- Co-authored-by: Claude <noreply@anthropic.com>

Mingqwqqaq · 2026-07-18T08:41:16Z

Summary

move the complete fake-backend conversation journey into typed zh/en catalogs across @maka/ui and desktop presentation helpers
localize empty/composer states, messages, permissions, sessions, tool activity, errors, timestamps, counts, and accessibility copy through the existing reactive UI locale
preserve user/model/tool/path/command/generated content verbatim while preventing English catalogs from silently falling back to Chinese
keep session refresh/subscription callbacks on the current runtime locale and localize model/attachment/session failure paths
sync the stale workbar E2E contract with fix(shell): unmount the workbar toggle where no workbar exists #1186 (the unavailable toggle is unmounted, not disabled)

Boundary

This is PR 3 of #1052: conversation, session, and tool surfaces.

personalization.uiLocale remains the single persisted preference
the resolved locale remains the single React/Intl authority
auto -> zh remains unchanged until the PR 4 completion gate
remaining specialized desktop surfaces, Follow system resolution, and the final bilingual E2E matrix remain PR 4
user content, model output, tool-owned payloads, brands, code, commands, paths, and generated content are not translated

Verification

Linux ext4 checkout, Node 24.18.0:

npm run lint
npm run build
npm run typecheck
npx knip --workspace apps/desktop
npx knip --workspace packages/ui
npm run build:test
Linux sandbox smoke: 5/5
npm run test:dist: all workspaces passed; desktop 2701/2701
localized conversation/tool focused suites: 15/15
workbar E2E contract: passed in isolation
alignment audit: all fixtures clean

Local WSL/Xvfb runs throttle requestAnimationFrame to ~2 seconds in the two long-scroll geometry tests. The same two timeouts reproduce on unmodified upstream main with identical 31.6k DOM height, 19 steps, 38 frames, and ~31 second deadline; GitHub's hosted E2E job remains the authoritative gate.

Part of #1052.

…ion-session-localization

…ion-session-localization # Conflicts: # apps/desktop/e2e/session-workbar.spec.ts

Astro-Han

Approved. Two non-blocking localization follow-ups:

In the English permission prompt, the stale-request age combines localized wrapper copy with the Chinese-only formatPermissionRequestWait(), so a request older than two minutes renders text such as Waiting for 6 分钟. The duration formatter should become locale-aware.
Collapsed session groups still wrap counts in hard-coded full-width parentheses, producing English labels such as Archived（3）. Moving the count format into the catalog would keep typography locale-correct.

Neither issue blocks this PR. The catalog ownership, reactive locale wiring, and focused coverage look good.

…ion-session-localization # Conflicts: # packages/ui/src/tool-activity/agent-preview.tsx

Astryx expands the pill only when new messages arrived, so the label reads as a notice rather than an action — but the copy this replaced (apache#1194's `jumpLatest`, dropped by apache#1795) said 跳到最新消息, and keeping the wording users already know beats a semantically tidier rename. Co-Authored-By: Claude <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Ac5rv6WUKWtMZgQb5QPN16

* fix(ui): localize the Astryx chrome adopted since #1795 #1795 moved the chat surfaces onto Astryx ChatLayout and deleted the `label={copy.jumpLatest}` that fed Maka's own scroll-to-bottom button, but never registered the replacement `@astryx.*` keys. Astryx ships no zh catalog, so the pill has been reading "New messages" in a Chinese UI ever since — and the same gap covers every other Astryx surface adopted without its copy. Audited all 219 shipped Astryx keys against the components Maka actually renders (JSX usage, not imports — the barrel re-export makes every component look reachable). 79 rendered keys had no override; this adds them, reusing existing entries where the string is identical rather than duplicating (form.clear, primitives.close/loading, selectPlaceholder). Excluded as dead config per this file's own rule: dateInput.dialogLabel and dateInput.placeholder — DateTimeInput references neither, and no standalone DateInput is rendered. The guard test listed `chat` as a surface Maka does not render, which is what let the regression through; it now guards lightbox only, and a new test pins the chat chrome. Co-Authored-By: Claude <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Ac5rv6WUKWtMZgQb5QPN16 * fix(ui): keep 跳到最新消息 for the scroll-to-bottom pill Astryx expands the pill only when new messages arrived, so the label reads as a notice rather than an action — but the copy this replaced (#1194's `jumpLatest`, dropped by #1795) said 跳到最新消息, and keeping the wording users already know beats a semantically tidier rename. Co-Authored-By: Claude <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Ac5rv6WUKWtMZgQb5QPN16 * test(ui): assert the pinned chat overrides exist before checking them `messages[key] ?? ''` coalesced a deleted override to the empty string, which holds no Latin letters and satisfied the translation check on its own — so the loop caught an English value but not a removed key. Verified both ways: deleting the send override now fails with 'missing override', and reverting its copy to English fails with 'untranslated'. Co-Authored-By: Claude <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Ac5rv6WUKWtMZgQb5QPN16 * fix(ui): localize the Lightbox reached via useLightbox The dead-config guard's surviving entry was as stale as the one #1795 invalidated: chat-turn.tsx opens image previews through useLightbox, which renders Astryx's Lightbox — with four English strings — while a JSX-tag scan for <Lightbox> reports the component unrendered. Add the four overrides (close reuses primitives.close) and retire the ban-list guard entirely: a list keyed to "what we render today" rots silently, and both of its entries had. Live surfaces are pinned by presence tests instead. Co-Authored-By: Claude <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Ac5rv6WUKWtMZgQb5QPN16 * test(e2e): match the quote token remove button by its localized name The token remove button read 'Remove {label}' only because Astryx's Token had no zh override; now that @astryx.token.remove is localized the accessible name is 移除…, and the /^Remove / locator times out. The spec already addresses every other control by its Chinese name. Co-Authored-By: Claude <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Ac5rv6WUKWtMZgQb5QPN16 * fix(ui): address review — off-barrel Astryx copy, localize #642 fallback Review findings on #2202, all verified before fixing: - The astryx catalogue expanded SharedUiCopy, which `export *`s through the package barrel — violating the README's off-barrel convention for symbols with no cross-package consumer. It now lives in astryx-copy.ts, deliberately unexported. - The en mirror existed only as a diffable reference and was never applied (astryxMessageOverrides returns undefined for en); dropped rather than left to drift against upstream. - `a` renamed to `astryx`; duplicated presence/Latin-letter assertions extracted into assertChineseAstryxOverrides. - P1: the #642 streaming fallback rendered a bare ChatMessage, which resolves Astryx's shipped 'Message from {sender}' — an English aria-label in a Chinese tree. It now reuses LocalizedChatMessage with the same assistantAriaLabel as the TurnView path. The regression test pins the exact trigger: wait indicators with zero turns — passing a liveTurn instead projects a real turn and takes the localized path, which is how the first draft of the test passed against the bug. Co-Authored-By: Claude <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Ac5rv6WUKWtMZgQb5QPN16 * fix(ui): prune dead overrides, sweep the whole zh map in tests Maintainer review on #2202, each claim verified before acting: - chatSendButton.send/stop: ChatComposerInput never renders ChatSendButton — composer.tsx supplies its own send button. Pruned; the pinned test now anchors on chatToolCalls.error instead. - appShell.mobileNavigation: gated on shouldShowAutoToggle, and Maka passes breakpoint 'none' + hasToggle false. Pruned. - table.noData / table.filter.* / tableFiltering.filterByColumn: the usage table mounts only the rowHeader plugin and renders EmptyState before Table when rows are empty. Pruned. - New whole-map sweep: every override must target a key Astryx ships, hold no Latin outside {…}, and carry the same top-level ICU arguments as the en default — depth-aware extraction, since plural branch text ({result}) reads like an argument to a naive regex and would flag every zh string that drops an inapplicable plural. - Presence-helper comment reworded: the check reads the override map directly, so a deleted entry yields '' here; at runtime the same miss falls back to Astryx's shipped en catalog. Sweep red-validated both ways: a misspelled key fails membership, an English value fails the Latin check. Co-Authored-By: Claude <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Ac5rv6WUKWtMZgQb5QPN16 --------- Co-authored-by: Claude <noreply@anthropic.com>

Mingqwqqaq · 2026-07-18T08:41:16Z

Summary

move the complete fake-backend conversation journey into typed zh/en catalogs across @maka/ui and desktop presentation helpers
localize empty/composer states, messages, permissions, sessions, tool activity, errors, timestamps, counts, and accessibility copy through the existing reactive UI locale
preserve user/model/tool/path/command/generated content verbatim while preventing English catalogs from silently falling back to Chinese
keep session refresh/subscription callbacks on the current runtime locale and localize model/attachment/session failure paths
sync the stale workbar E2E contract with fix(shell): unmount the workbar toggle where no workbar exists #1186 (the unavailable toggle is unmounted, not disabled)

Boundary

This is PR 3 of #1052: conversation, session, and tool surfaces.

personalization.uiLocale remains the single persisted preference
the resolved locale remains the single React/Intl authority
auto -> zh remains unchanged until the PR 4 completion gate
remaining specialized desktop surfaces, Follow system resolution, and the final bilingual E2E matrix remain PR 4
user content, model output, tool-owned payloads, brands, code, commands, paths, and generated content are not translated

Verification

Linux ext4 checkout, Node 24.18.0:

npm run lint
npm run build
npm run typecheck
npx knip --workspace apps/desktop
npx knip --workspace packages/ui
npm run build:test
Linux sandbox smoke: 5/5
npm run test:dist: all workspaces passed; desktop 2701/2701
localized conversation/tool focused suites: 15/15
workbar E2E contract: passed in isolation
alignment audit: all fixtures clean

Local WSL/Xvfb runs throttle requestAnimationFrame to ~2 seconds in the two long-scroll geometry tests. The same two timeouts reproduce on unmodified upstream main with identical 31.6k DOM height, 19 steps, 38 frames, and ~31 second deadline; GitHub's hosted E2E job remains the authoritative gate.

Part of #1052.

…ion-session-localization

…ion-session-localization # Conflicts: # apps/desktop/e2e/session-workbar.spec.ts

Astro-Han

Approved. Two non-blocking localization follow-ups:

In the English permission prompt, the stale-request age combines localized wrapper copy with the Chinese-only formatPermissionRequestWait(), so a request older than two minutes renders text such as Waiting for 6 分钟. The duration formatter should become locale-aware.
Collapsed session groups still wrap counts in hard-coded full-width parentheses, producing English labels such as Archived（3）. Moving the count format into the catalog would keep typography locale-correct.

Neither issue blocks this PR. The catalog ownership, reactive locale wiring, and focused coverage look good.

…ion-session-localization # Conflicts: # packages/ui/src/tool-activity/agent-preview.tsx

Astryx expands the pill only when new messages arrived, so the label reads as a notice rather than an action — but the copy this replaced (apache#1194's `jumpLatest`, dropped by apache#1795) said 跳到最新消息, and keeping the wording users already know beats a semantically tidier rename. Co-Authored-By: Claude <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Ac5rv6WUKWtMZgQb5QPN16

* fix(ui): localize the Astryx chrome adopted since #1795 #1795 moved the chat surfaces onto Astryx ChatLayout and deleted the `label={copy.jumpLatest}` that fed Maka's own scroll-to-bottom button, but never registered the replacement `@astryx.*` keys. Astryx ships no zh catalog, so the pill has been reading "New messages" in a Chinese UI ever since — and the same gap covers every other Astryx surface adopted without its copy. Audited all 219 shipped Astryx keys against the components Maka actually renders (JSX usage, not imports — the barrel re-export makes every component look reachable). 79 rendered keys had no override; this adds them, reusing existing entries where the string is identical rather than duplicating (form.clear, primitives.close/loading, selectPlaceholder). Excluded as dead config per this file's own rule: dateInput.dialogLabel and dateInput.placeholder — DateTimeInput references neither, and no standalone DateInput is rendered. The guard test listed `chat` as a surface Maka does not render, which is what let the regression through; it now guards lightbox only, and a new test pins the chat chrome. Co-Authored-By: Claude <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Ac5rv6WUKWtMZgQb5QPN16 * fix(ui): keep 跳到最新消息 for the scroll-to-bottom pill Astryx expands the pill only when new messages arrived, so the label reads as a notice rather than an action — but the copy this replaced (#1194's `jumpLatest`, dropped by #1795) said 跳到最新消息, and keeping the wording users already know beats a semantically tidier rename. Co-Authored-By: Claude <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Ac5rv6WUKWtMZgQb5QPN16 * test(ui): assert the pinned chat overrides exist before checking them `messages[key] ?? ''` coalesced a deleted override to the empty string, which holds no Latin letters and satisfied the translation check on its own — so the loop caught an English value but not a removed key. Verified both ways: deleting the send override now fails with 'missing override', and reverting its copy to English fails with 'untranslated'. Co-Authored-By: Claude <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Ac5rv6WUKWtMZgQb5QPN16 * fix(ui): localize the Lightbox reached via useLightbox The dead-config guard's surviving entry was as stale as the one #1795 invalidated: chat-turn.tsx opens image previews through useLightbox, which renders Astryx's Lightbox — with four English strings — while a JSX-tag scan for <Lightbox> reports the component unrendered. Add the four overrides (close reuses primitives.close) and retire the ban-list guard entirely: a list keyed to "what we render today" rots silently, and both of its entries had. Live surfaces are pinned by presence tests instead. Co-Authored-By: Claude <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Ac5rv6WUKWtMZgQb5QPN16 * test(e2e): match the quote token remove button by its localized name The token remove button read 'Remove {label}' only because Astryx's Token had no zh override; now that @astryx.token.remove is localized the accessible name is 移除…, and the /^Remove / locator times out. The spec already addresses every other control by its Chinese name. Co-Authored-By: Claude <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Ac5rv6WUKWtMZgQb5QPN16 * fix(ui): address review — off-barrel Astryx copy, localize #642 fallback Review findings on #2202, all verified before fixing: - The astryx catalogue expanded SharedUiCopy, which `export *`s through the package barrel — violating the README's off-barrel convention for symbols with no cross-package consumer. It now lives in astryx-copy.ts, deliberately unexported. - The en mirror existed only as a diffable reference and was never applied (astryxMessageOverrides returns undefined for en); dropped rather than left to drift against upstream. - `a` renamed to `astryx`; duplicated presence/Latin-letter assertions extracted into assertChineseAstryxOverrides. - P1: the #642 streaming fallback rendered a bare ChatMessage, which resolves Astryx's shipped 'Message from {sender}' — an English aria-label in a Chinese tree. It now reuses LocalizedChatMessage with the same assistantAriaLabel as the TurnView path. The regression test pins the exact trigger: wait indicators with zero turns — passing a liveTurn instead projects a real turn and takes the localized path, which is how the first draft of the test passed against the bug. Co-Authored-By: Claude <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Ac5rv6WUKWtMZgQb5QPN16 * fix(ui): prune dead overrides, sweep the whole zh map in tests Maintainer review on #2202, each claim verified before acting: - chatSendButton.send/stop: ChatComposerInput never renders ChatSendButton — composer.tsx supplies its own send button. Pruned; the pinned test now anchors on chatToolCalls.error instead. - appShell.mobileNavigation: gated on shouldShowAutoToggle, and Maka passes breakpoint 'none' + hasToggle false. Pruned. - table.noData / table.filter.* / tableFiltering.filterByColumn: the usage table mounts only the rowHeader plugin and renders EmptyState before Table when rows are empty. Pruned. - New whole-map sweep: every override must target a key Astryx ships, hold no Latin outside {…}, and carry the same top-level ICU arguments as the en default — depth-aware extraction, since plural branch text ({result}) reads like an argument to a naive regex and would flag every zh string that drops an inapplicable plural. - Presence-helper comment reworded: the check reads the override map directly, so a deleted entry yields '' here; at runtime the same miss falls back to Astryx's shipped en catalog. Sweep red-validated both ways: a misspelled key fails membership, an English value fails the Latin check. Co-Authored-By: Claude <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Ac5rv6WUKWtMZgQb5QPN16 --------- Co-authored-by: Claude <noreply@anthropic.com>

Mingqwqqaq · 2026-07-18T08:41:16Z

Summary

move the complete fake-backend conversation journey into typed zh/en catalogs across @maka/ui and desktop presentation helpers
localize empty/composer states, messages, permissions, sessions, tool activity, errors, timestamps, counts, and accessibility copy through the existing reactive UI locale
preserve user/model/tool/path/command/generated content verbatim while preventing English catalogs from silently falling back to Chinese
keep session refresh/subscription callbacks on the current runtime locale and localize model/attachment/session failure paths
sync the stale workbar E2E contract with fix(shell): unmount the workbar toggle where no workbar exists #1186 (the unavailable toggle is unmounted, not disabled)

Boundary

This is PR 3 of #1052: conversation, session, and tool surfaces.

personalization.uiLocale remains the single persisted preference
the resolved locale remains the single React/Intl authority
auto -> zh remains unchanged until the PR 4 completion gate
remaining specialized desktop surfaces, Follow system resolution, and the final bilingual E2E matrix remain PR 4
user content, model output, tool-owned payloads, brands, code, commands, paths, and generated content are not translated

Verification

Linux ext4 checkout, Node 24.18.0:

npm run lint
npm run build
npm run typecheck
npx knip --workspace apps/desktop
npx knip --workspace packages/ui
npm run build:test
Linux sandbox smoke: 5/5
npm run test:dist: all workspaces passed; desktop 2701/2701
localized conversation/tool focused suites: 15/15
workbar E2E contract: passed in isolation
alignment audit: all fixtures clean

Local WSL/Xvfb runs throttle requestAnimationFrame to ~2 seconds in the two long-scroll geometry tests. The same two timeouts reproduce on unmodified upstream main with identical 31.6k DOM height, 19 steps, 38 frames, and ~31 second deadline; GitHub's hosted E2E job remains the authoritative gate.

Part of #1052.

…ion-session-localization

…ion-session-localization # Conflicts: # apps/desktop/e2e/session-workbar.spec.ts

Astro-Han

Approved. Two non-blocking localization follow-ups:

In the English permission prompt, the stale-request age combines localized wrapper copy with the Chinese-only formatPermissionRequestWait(), so a request older than two minutes renders text such as Waiting for 6 分钟. The duration formatter should become locale-aware.
Collapsed session groups still wrap counts in hard-coded full-width parentheses, producing English labels such as Archived（3）. Moving the count format into the catalog would keep typography locale-correct.

Neither issue blocks this PR. The catalog ownership, reactive locale wiring, and focused coverage look good.

…ion-session-localization # Conflicts: # packages/ui/src/tool-activity/agent-preview.tsx

Astryx expands the pill only when new messages arrived, so the label reads as a notice rather than an action — but the copy this replaced (apache#1194's `jumpLatest`, dropped by apache#1795) said 跳到最新消息, and keeping the wording users already know beats a semantically tidier rename. Co-Authored-By: Claude <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Ac5rv6WUKWtMZgQb5QPN16

* fix(ui): localize the Astryx chrome adopted since #1795 #1795 moved the chat surfaces onto Astryx ChatLayout and deleted the `label={copy.jumpLatest}` that fed Maka's own scroll-to-bottom button, but never registered the replacement `@astryx.*` keys. Astryx ships no zh catalog, so the pill has been reading "New messages" in a Chinese UI ever since — and the same gap covers every other Astryx surface adopted without its copy. Audited all 219 shipped Astryx keys against the components Maka actually renders (JSX usage, not imports — the barrel re-export makes every component look reachable). 79 rendered keys had no override; this adds them, reusing existing entries where the string is identical rather than duplicating (form.clear, primitives.close/loading, selectPlaceholder). Excluded as dead config per this file's own rule: dateInput.dialogLabel and dateInput.placeholder — DateTimeInput references neither, and no standalone DateInput is rendered. The guard test listed `chat` as a surface Maka does not render, which is what let the regression through; it now guards lightbox only, and a new test pins the chat chrome. Co-Authored-By: Claude <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Ac5rv6WUKWtMZgQb5QPN16 * fix(ui): keep 跳到最新消息 for the scroll-to-bottom pill Astryx expands the pill only when new messages arrived, so the label reads as a notice rather than an action — but the copy this replaced (#1194's `jumpLatest`, dropped by #1795) said 跳到最新消息, and keeping the wording users already know beats a semantically tidier rename. Co-Authored-By: Claude <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Ac5rv6WUKWtMZgQb5QPN16 * test(ui): assert the pinned chat overrides exist before checking them `messages[key] ?? ''` coalesced a deleted override to the empty string, which holds no Latin letters and satisfied the translation check on its own — so the loop caught an English value but not a removed key. Verified both ways: deleting the send override now fails with 'missing override', and reverting its copy to English fails with 'untranslated'. Co-Authored-By: Claude <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Ac5rv6WUKWtMZgQb5QPN16 * fix(ui): localize the Lightbox reached via useLightbox The dead-config guard's surviving entry was as stale as the one #1795 invalidated: chat-turn.tsx opens image previews through useLightbox, which renders Astryx's Lightbox — with four English strings — while a JSX-tag scan for <Lightbox> reports the component unrendered. Add the four overrides (close reuses primitives.close) and retire the ban-list guard entirely: a list keyed to "what we render today" rots silently, and both of its entries had. Live surfaces are pinned by presence tests instead. Co-Authored-By: Claude <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Ac5rv6WUKWtMZgQb5QPN16 * test(e2e): match the quote token remove button by its localized name The token remove button read 'Remove {label}' only because Astryx's Token had no zh override; now that @astryx.token.remove is localized the accessible name is 移除…, and the /^Remove / locator times out. The spec already addresses every other control by its Chinese name. Co-Authored-By: Claude <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Ac5rv6WUKWtMZgQb5QPN16 * fix(ui): address review — off-barrel Astryx copy, localize #642 fallback Review findings on #2202, all verified before fixing: - The astryx catalogue expanded SharedUiCopy, which `export *`s through the package barrel — violating the README's off-barrel convention for symbols with no cross-package consumer. It now lives in astryx-copy.ts, deliberately unexported. - The en mirror existed only as a diffable reference and was never applied (astryxMessageOverrides returns undefined for en); dropped rather than left to drift against upstream. - `a` renamed to `astryx`; duplicated presence/Latin-letter assertions extracted into assertChineseAstryxOverrides. - P1: the #642 streaming fallback rendered a bare ChatMessage, which resolves Astryx's shipped 'Message from {sender}' — an English aria-label in a Chinese tree. It now reuses LocalizedChatMessage with the same assistantAriaLabel as the TurnView path. The regression test pins the exact trigger: wait indicators with zero turns — passing a liveTurn instead projects a real turn and takes the localized path, which is how the first draft of the test passed against the bug. Co-Authored-By: Claude <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Ac5rv6WUKWtMZgQb5QPN16 * fix(ui): prune dead overrides, sweep the whole zh map in tests Maintainer review on #2202, each claim verified before acting: - chatSendButton.send/stop: ChatComposerInput never renders ChatSendButton — composer.tsx supplies its own send button. Pruned; the pinned test now anchors on chatToolCalls.error instead. - appShell.mobileNavigation: gated on shouldShowAutoToggle, and Maka passes breakpoint 'none' + hasToggle false. Pruned. - table.noData / table.filter.* / tableFiltering.filterByColumn: the usage table mounts only the rowHeader plugin and renders EmptyState before Table when rows are empty. Pruned. - New whole-map sweep: every override must target a key Astryx ships, hold no Latin outside {…}, and carry the same top-level ICU arguments as the en default — depth-aware extraction, since plural branch text ({result}) reads like an argument to a naive regex and would flag every zh string that drops an inapplicable plural. - Presence-helper comment reworded: the check reads the override map directly, so a deleted entry yields '' here; at runtime the same miss falls back to Astryx's shipped en catalog. Sweep red-validated both ways: a misspelled key fails membership, an English value fails the Latin check. Co-Authored-By: Claude <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Ac5rv6WUKWtMZgQb5QPN16 --------- Co-authored-by: Claude <noreply@anthropic.com>

Mingqwqqaq · 2026-07-18T08:41:16Z

Summary

move the complete fake-backend conversation journey into typed zh/en catalogs across @maka/ui and desktop presentation helpers
localize empty/composer states, messages, permissions, sessions, tool activity, errors, timestamps, counts, and accessibility copy through the existing reactive UI locale
preserve user/model/tool/path/command/generated content verbatim while preventing English catalogs from silently falling back to Chinese
keep session refresh/subscription callbacks on the current runtime locale and localize model/attachment/session failure paths
sync the stale workbar E2E contract with fix(shell): unmount the workbar toggle where no workbar exists #1186 (the unavailable toggle is unmounted, not disabled)

Boundary

This is PR 3 of #1052: conversation, session, and tool surfaces.

personalization.uiLocale remains the single persisted preference
the resolved locale remains the single React/Intl authority
auto -> zh remains unchanged until the PR 4 completion gate
remaining specialized desktop surfaces, Follow system resolution, and the final bilingual E2E matrix remain PR 4
user content, model output, tool-owned payloads, brands, code, commands, paths, and generated content are not translated

Verification

Linux ext4 checkout, Node 24.18.0:

npm run lint
npm run build
npm run typecheck
npx knip --workspace apps/desktop
npx knip --workspace packages/ui
npm run build:test
Linux sandbox smoke: 5/5
npm run test:dist: all workspaces passed; desktop 2701/2701
localized conversation/tool focused suites: 15/15
workbar E2E contract: passed in isolation
alignment audit: all fixtures clean

Local WSL/Xvfb runs throttle requestAnimationFrame to ~2 seconds in the two long-scroll geometry tests. The same two timeouts reproduce on unmodified upstream main with identical 31.6k DOM height, 19 steps, 38 frames, and ~31 second deadline; GitHub's hosted E2E job remains the authoritative gate.

Part of #1052.

…ion-session-localization

…ion-session-localization # Conflicts: # apps/desktop/e2e/session-workbar.spec.ts

Astro-Han

Approved. Two non-blocking localization follow-ups:

In the English permission prompt, the stale-request age combines localized wrapper copy with the Chinese-only formatPermissionRequestWait(), so a request older than two minutes renders text such as Waiting for 6 分钟. The duration formatter should become locale-aware.
Collapsed session groups still wrap counts in hard-coded full-width parentheses, producing English labels such as Archived（3）. Moving the count format into the catalog would keep typography locale-correct.

Neither issue blocks this PR. The catalog ownership, reactive locale wiring, and focused coverage look good.

…ion-session-localization # Conflicts: # packages/ui/src/tool-activity/agent-preview.tsx

Astryx expands the pill only when new messages arrived, so the label reads as a notice rather than an action — but the copy this replaced (apache#1194's `jumpLatest`, dropped by apache#1795) said 跳到最新消息, and keeping the wording users already know beats a semantically tidier rename. Co-Authored-By: Claude <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Ac5rv6WUKWtMZgQb5QPN16

* fix(ui): localize the Astryx chrome adopted since #1795 #1795 moved the chat surfaces onto Astryx ChatLayout and deleted the `label={copy.jumpLatest}` that fed Maka's own scroll-to-bottom button, but never registered the replacement `@astryx.*` keys. Astryx ships no zh catalog, so the pill has been reading "New messages" in a Chinese UI ever since — and the same gap covers every other Astryx surface adopted without its copy. Audited all 219 shipped Astryx keys against the components Maka actually renders (JSX usage, not imports — the barrel re-export makes every component look reachable). 79 rendered keys had no override; this adds them, reusing existing entries where the string is identical rather than duplicating (form.clear, primitives.close/loading, selectPlaceholder). Excluded as dead config per this file's own rule: dateInput.dialogLabel and dateInput.placeholder — DateTimeInput references neither, and no standalone DateInput is rendered. The guard test listed `chat` as a surface Maka does not render, which is what let the regression through; it now guards lightbox only, and a new test pins the chat chrome. Co-Authored-By: Claude <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Ac5rv6WUKWtMZgQb5QPN16 * fix(ui): keep 跳到最新消息 for the scroll-to-bottom pill Astryx expands the pill only when new messages arrived, so the label reads as a notice rather than an action — but the copy this replaced (#1194's `jumpLatest`, dropped by #1795) said 跳到最新消息, and keeping the wording users already know beats a semantically tidier rename. Co-Authored-By: Claude <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Ac5rv6WUKWtMZgQb5QPN16 * test(ui): assert the pinned chat overrides exist before checking them `messages[key] ?? ''` coalesced a deleted override to the empty string, which holds no Latin letters and satisfied the translation check on its own — so the loop caught an English value but not a removed key. Verified both ways: deleting the send override now fails with 'missing override', and reverting its copy to English fails with 'untranslated'. Co-Authored-By: Claude <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Ac5rv6WUKWtMZgQb5QPN16 * fix(ui): localize the Lightbox reached via useLightbox The dead-config guard's surviving entry was as stale as the one #1795 invalidated: chat-turn.tsx opens image previews through useLightbox, which renders Astryx's Lightbox — with four English strings — while a JSX-tag scan for <Lightbox> reports the component unrendered. Add the four overrides (close reuses primitives.close) and retire the ban-list guard entirely: a list keyed to "what we render today" rots silently, and both of its entries had. Live surfaces are pinned by presence tests instead. Co-Authored-By: Claude <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Ac5rv6WUKWtMZgQb5QPN16 * test(e2e): match the quote token remove button by its localized name The token remove button read 'Remove {label}' only because Astryx's Token had no zh override; now that @astryx.token.remove is localized the accessible name is 移除…, and the /^Remove / locator times out. The spec already addresses every other control by its Chinese name. Co-Authored-By: Claude <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Ac5rv6WUKWtMZgQb5QPN16 * fix(ui): address review — off-barrel Astryx copy, localize #642 fallback Review findings on #2202, all verified before fixing: - The astryx catalogue expanded SharedUiCopy, which `export *`s through the package barrel — violating the README's off-barrel convention for symbols with no cross-package consumer. It now lives in astryx-copy.ts, deliberately unexported. - The en mirror existed only as a diffable reference and was never applied (astryxMessageOverrides returns undefined for en); dropped rather than left to drift against upstream. - `a` renamed to `astryx`; duplicated presence/Latin-letter assertions extracted into assertChineseAstryxOverrides. - P1: the #642 streaming fallback rendered a bare ChatMessage, which resolves Astryx's shipped 'Message from {sender}' — an English aria-label in a Chinese tree. It now reuses LocalizedChatMessage with the same assistantAriaLabel as the TurnView path. The regression test pins the exact trigger: wait indicators with zero turns — passing a liveTurn instead projects a real turn and takes the localized path, which is how the first draft of the test passed against the bug. Co-Authored-By: Claude <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Ac5rv6WUKWtMZgQb5QPN16 * fix(ui): prune dead overrides, sweep the whole zh map in tests Maintainer review on #2202, each claim verified before acting: - chatSendButton.send/stop: ChatComposerInput never renders ChatSendButton — composer.tsx supplies its own send button. Pruned; the pinned test now anchors on chatToolCalls.error instead. - appShell.mobileNavigation: gated on shouldShowAutoToggle, and Maka passes breakpoint 'none' + hasToggle false. Pruned. - table.noData / table.filter.* / tableFiltering.filterByColumn: the usage table mounts only the rowHeader plugin and renders EmptyState before Table when rows are empty. Pruned. - New whole-map sweep: every override must target a key Astryx ships, hold no Latin outside {…}, and carry the same top-level ICU arguments as the en default — depth-aware extraction, since plural branch text ({result}) reads like an argument to a naive regex and would flag every zh string that drops an inapplicable plural. - Presence-helper comment reworded: the check reads the override map directly, so a deleted entry yields '' here; at runtime the same miss falls back to Astryx's shipped en catalog. Sweep red-validated both ways: a misspelled key fails membership, an English value fails the Latin check. Co-Authored-By: Claude <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Ac5rv6WUKWtMZgQb5QPN16 --------- Co-authored-by: Claude <noreply@anthropic.com>

Mingqwqqaq · 2026-07-18T08:41:16Z

Summary

move the complete fake-backend conversation journey into typed zh/en catalogs across @maka/ui and desktop presentation helpers
localize empty/composer states, messages, permissions, sessions, tool activity, errors, timestamps, counts, and accessibility copy through the existing reactive UI locale
preserve user/model/tool/path/command/generated content verbatim while preventing English catalogs from silently falling back to Chinese
keep session refresh/subscription callbacks on the current runtime locale and localize model/attachment/session failure paths
sync the stale workbar E2E contract with fix(shell): unmount the workbar toggle where no workbar exists #1186 (the unavailable toggle is unmounted, not disabled)

Boundary

This is PR 3 of #1052: conversation, session, and tool surfaces.

personalization.uiLocale remains the single persisted preference
the resolved locale remains the single React/Intl authority
auto -> zh remains unchanged until the PR 4 completion gate
remaining specialized desktop surfaces, Follow system resolution, and the final bilingual E2E matrix remain PR 4
user content, model output, tool-owned payloads, brands, code, commands, paths, and generated content are not translated

Verification

Linux ext4 checkout, Node 24.18.0:

npm run lint
npm run build
npm run typecheck
npx knip --workspace apps/desktop
npx knip --workspace packages/ui
npm run build:test
Linux sandbox smoke: 5/5
npm run test:dist: all workspaces passed; desktop 2701/2701
localized conversation/tool focused suites: 15/15
workbar E2E contract: passed in isolation
alignment audit: all fixtures clean

Local WSL/Xvfb runs throttle requestAnimationFrame to ~2 seconds in the two long-scroll geometry tests. The same two timeouts reproduce on unmodified upstream main with identical 31.6k DOM height, 19 steps, 38 frames, and ~31 second deadline; GitHub's hosted E2E job remains the authoritative gate.

Part of #1052.

…ion-session-localization

…ion-session-localization # Conflicts: # apps/desktop/e2e/session-workbar.spec.ts

Astro-Han

Approved. Two non-blocking localization follow-ups:

In the English permission prompt, the stale-request age combines localized wrapper copy with the Chinese-only formatPermissionRequestWait(), so a request older than two minutes renders text such as Waiting for 6 分钟. The duration formatter should become locale-aware.
Collapsed session groups still wrap counts in hard-coded full-width parentheses, producing English labels such as Archived（3）. Moving the count format into the catalog would keep typography locale-correct.

Neither issue blocks this PR. The catalog ownership, reactive locale wiring, and focused coverage look good.

…ion-session-localization # Conflicts: # packages/ui/src/tool-activity/agent-preview.tsx

Astryx expands the pill only when new messages arrived, so the label reads as a notice rather than an action — but the copy this replaced (apache#1194's `jumpLatest`, dropped by apache#1795) said 跳到最新消息, and keeping the wording users already know beats a semantically tidier rename. Co-Authored-By: Claude <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Ac5rv6WUKWtMZgQb5QPN16

* fix(ui): localize the Astryx chrome adopted since #1795 #1795 moved the chat surfaces onto Astryx ChatLayout and deleted the `label={copy.jumpLatest}` that fed Maka's own scroll-to-bottom button, but never registered the replacement `@astryx.*` keys. Astryx ships no zh catalog, so the pill has been reading "New messages" in a Chinese UI ever since — and the same gap covers every other Astryx surface adopted without its copy. Audited all 219 shipped Astryx keys against the components Maka actually renders (JSX usage, not imports — the barrel re-export makes every component look reachable). 79 rendered keys had no override; this adds them, reusing existing entries where the string is identical rather than duplicating (form.clear, primitives.close/loading, selectPlaceholder). Excluded as dead config per this file's own rule: dateInput.dialogLabel and dateInput.placeholder — DateTimeInput references neither, and no standalone DateInput is rendered. The guard test listed `chat` as a surface Maka does not render, which is what let the regression through; it now guards lightbox only, and a new test pins the chat chrome. Co-Authored-By: Claude <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Ac5rv6WUKWtMZgQb5QPN16 * fix(ui): keep 跳到最新消息 for the scroll-to-bottom pill Astryx expands the pill only when new messages arrived, so the label reads as a notice rather than an action — but the copy this replaced (#1194's `jumpLatest`, dropped by #1795) said 跳到最新消息, and keeping the wording users already know beats a semantically tidier rename. Co-Authored-By: Claude <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Ac5rv6WUKWtMZgQb5QPN16 * test(ui): assert the pinned chat overrides exist before checking them `messages[key] ?? ''` coalesced a deleted override to the empty string, which holds no Latin letters and satisfied the translation check on its own — so the loop caught an English value but not a removed key. Verified both ways: deleting the send override now fails with 'missing override', and reverting its copy to English fails with 'untranslated'. Co-Authored-By: Claude <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Ac5rv6WUKWtMZgQb5QPN16 * fix(ui): localize the Lightbox reached via useLightbox The dead-config guard's surviving entry was as stale as the one #1795 invalidated: chat-turn.tsx opens image previews through useLightbox, which renders Astryx's Lightbox — with four English strings — while a JSX-tag scan for <Lightbox> reports the component unrendered. Add the four overrides (close reuses primitives.close) and retire the ban-list guard entirely: a list keyed to "what we render today" rots silently, and both of its entries had. Live surfaces are pinned by presence tests instead. Co-Authored-By: Claude <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Ac5rv6WUKWtMZgQb5QPN16 * test(e2e): match the quote token remove button by its localized name The token remove button read 'Remove {label}' only because Astryx's Token had no zh override; now that @astryx.token.remove is localized the accessible name is 移除…, and the /^Remove / locator times out. The spec already addresses every other control by its Chinese name. Co-Authored-By: Claude <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Ac5rv6WUKWtMZgQb5QPN16 * fix(ui): address review — off-barrel Astryx copy, localize #642 fallback Review findings on #2202, all verified before fixing: - The astryx catalogue expanded SharedUiCopy, which `export *`s through the package barrel — violating the README's off-barrel convention for symbols with no cross-package consumer. It now lives in astryx-copy.ts, deliberately unexported. - The en mirror existed only as a diffable reference and was never applied (astryxMessageOverrides returns undefined for en); dropped rather than left to drift against upstream. - `a` renamed to `astryx`; duplicated presence/Latin-letter assertions extracted into assertChineseAstryxOverrides. - P1: the #642 streaming fallback rendered a bare ChatMessage, which resolves Astryx's shipped 'Message from {sender}' — an English aria-label in a Chinese tree. It now reuses LocalizedChatMessage with the same assistantAriaLabel as the TurnView path. The regression test pins the exact trigger: wait indicators with zero turns — passing a liveTurn instead projects a real turn and takes the localized path, which is how the first draft of the test passed against the bug. Co-Authored-By: Claude <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Ac5rv6WUKWtMZgQb5QPN16 * fix(ui): prune dead overrides, sweep the whole zh map in tests Maintainer review on #2202, each claim verified before acting: - chatSendButton.send/stop: ChatComposerInput never renders ChatSendButton — composer.tsx supplies its own send button. Pruned; the pinned test now anchors on chatToolCalls.error instead. - appShell.mobileNavigation: gated on shouldShowAutoToggle, and Maka passes breakpoint 'none' + hasToggle false. Pruned. - table.noData / table.filter.* / tableFiltering.filterByColumn: the usage table mounts only the rowHeader plugin and renders EmptyState before Table when rows are empty. Pruned. - New whole-map sweep: every override must target a key Astryx ships, hold no Latin outside {…}, and carry the same top-level ICU arguments as the en default — depth-aware extraction, since plural branch text ({result}) reads like an argument to a naive regex and would flag every zh string that drops an inapplicable plural. - Presence-helper comment reworded: the check reads the override map directly, so a deleted entry yields '' here; at runtime the same miss falls back to Astryx's shipped en catalog. Sweep red-validated both ways: a misspelled key fails membership, an English value fails the Latin check. Co-Authored-By: Claude <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Ac5rv6WUKWtMZgQb5QPN16 --------- Co-authored-by: Claude <noreply@anthropic.com>

Mingqwqqaq added 9 commits July 18, 2026 14:20

docs: design conversation and session localization
bac853c

feat(ui): localize conversation and tool surfaces
5cd320b

feat(desktop): complete conversation journey localization
887b2ad

Merge remote-tracking branch 'upstream/main' into feat/1052-conversat…
de29937
…ion-session-localization

style(ui): normalize conversation source ending
9bcd7a9

test(desktop): align localized tool contracts
cb8d1a9

test(desktop): follow localized tool count copy
6cd874f

test(desktop): follow hidden workbar toggle contract
5ffb25c

Merge remote-tracking branch 'upstream/main' into feat/1052-conversat…
5d226e9
…ion-session-localization # Conflicts: # apps/desktop/e2e/session-workbar.spec.ts

Astro-Han approved these changes Jul 18, 2026
View reviewed changes

Merge remote-tracking branch 'upstream/main' into feat/1052-conversat…
90bda8b
…ion-session-localization # Conflicts: # packages/ui/src/tool-activity/agent-preview.tsx

Mingqwqqaq force-pushed the feat/1052-conversation-session-localization branch from a07353b to 90bda8bCompare July 18, 2026 14:53

docs: remove superpowers planning artifacts
53c944f

Astro-Han merged commit b2daec5 into apache:mainJul 18, 2026
3 checks passed

Mingqwqqaq mentioned this pull request Jul 19, 2026
fix(ui): localize permission waits and session counts #1230
Merged

Mingqwqqaq added 9 commits July 18, 2026 14:20

docs: design conversation and session localization
bac853c

feat(ui): localize conversation and tool surfaces
5cd320b

feat(desktop): complete conversation journey localization
887b2ad

Merge remote-tracking branch 'upstream/main' into feat/1052-conversat…
de29937
…ion-session-localization

style(ui): normalize conversation source ending
9bcd7a9

test(desktop): align localized tool contracts
cb8d1a9

test(desktop): follow localized tool count copy
6cd874f

test(desktop): follow hidden workbar toggle contract
5ffb25c

Merge remote-tracking branch 'upstream/main' into feat/1052-conversat…
5d226e9
…ion-session-localization # Conflicts: # apps/desktop/e2e/session-workbar.spec.ts

Astro-Han approved these changes Jul 18, 2026
View reviewed changes

Merge remote-tracking branch 'upstream/main' into feat/1052-conversat…
90bda8b
…ion-session-localization # Conflicts: # packages/ui/src/tool-activity/agent-preview.tsx

Mingqwqqaq force-pushed the feat/1052-conversation-session-localization branch from a07353b to 90bda8bCompare July 18, 2026 14:53

docs: remove superpowers planning artifacts
53c944f

Astro-Han merged commit b2daec5 into apache:mainJul 18, 2026
3 checks passed

Mingqwqqaq mentioned this pull request Jul 19, 2026
fix(ui): localize permission waits and session counts #1230
Merged

Mingqwqqaq added 9 commits July 18, 2026 14:20

docs: design conversation and session localization
bac853c

feat(ui): localize conversation and tool surfaces
5cd320b

feat(desktop): complete conversation journey localization
887b2ad

Merge remote-tracking branch 'upstream/main' into feat/1052-conversat…
de29937
…ion-session-localization

style(ui): normalize conversation source ending
9bcd7a9

test(desktop): align localized tool contracts
cb8d1a9

test(desktop): follow localized tool count copy
6cd874f

test(desktop): follow hidden workbar toggle contract
5ffb25c

Merge remote-tracking branch 'upstream/main' into feat/1052-conversat…
5d226e9
…ion-session-localization # Conflicts: # apps/desktop/e2e/session-workbar.spec.ts

Astro-Han approved these changes Jul 18, 2026
View reviewed changes

Merge remote-tracking branch 'upstream/main' into feat/1052-conversat…
90bda8b
…ion-session-localization # Conflicts: # packages/ui/src/tool-activity/agent-preview.tsx

Mingqwqqaq force-pushed the feat/1052-conversation-session-localization branch from a07353b to 90bda8bCompare July 18, 2026 14:53

docs: remove superpowers planning artifacts
53c944f

Astro-Han merged commit b2daec5 into apache:mainJul 18, 2026
3 checks passed

Mingqwqqaq mentioned this pull request Jul 19, 2026
fix(ui): localize permission waits and session counts #1230
Merged

Mingqwqqaq added 9 commits July 18, 2026 14:20

docs: design conversation and session localization
bac853c

feat(ui): localize conversation and tool surfaces
5cd320b

feat(desktop): complete conversation journey localization
887b2ad

Merge remote-tracking branch 'upstream/main' into feat/1052-conversat…
de29937
…ion-session-localization

style(ui): normalize conversation source ending
9bcd7a9

test(desktop): align localized tool contracts
cb8d1a9

test(desktop): follow localized tool count copy
6cd874f

test(desktop): follow hidden workbar toggle contract
5ffb25c

Merge remote-tracking branch 'upstream/main' into feat/1052-conversat…
5d226e9
…ion-session-localization # Conflicts: # apps/desktop/e2e/session-workbar.spec.ts

Astro-Han approved these changes Jul 18, 2026
View reviewed changes

Merge remote-tracking branch 'upstream/main' into feat/1052-conversat…
90bda8b
…ion-session-localization # Conflicts: # packages/ui/src/tool-activity/agent-preview.tsx

Mingqwqqaq force-pushed the feat/1052-conversation-session-localization branch from a07353b to 90bda8bCompare July 18, 2026 14:53

docs: remove superpowers planning artifacts
53c944f

Astro-Han merged commit b2daec5 into apache:mainJul 18, 2026
3 checks passed

Mingqwqqaq mentioned this pull request Jul 19, 2026
fix(ui): localize permission waits and session counts #1230
Merged

Mingqwqqaq added 9 commits July 18, 2026 14:20

docs: design conversation and session localization
bac853c

feat(ui): localize conversation and tool surfaces
5cd320b

feat(desktop): complete conversation journey localization
887b2ad

Merge remote-tracking branch 'upstream/main' into feat/1052-conversat…
de29937
…ion-session-localization

style(ui): normalize conversation source ending
9bcd7a9

test(desktop): align localized tool contracts
cb8d1a9

test(desktop): follow localized tool count copy
6cd874f

test(desktop): follow hidden workbar toggle contract
5ffb25c

Merge remote-tracking branch 'upstream/main' into feat/1052-conversat…
5d226e9
…ion-session-localization # Conflicts: # apps/desktop/e2e/session-workbar.spec.ts

Astro-Han approved these changes Jul 18, 2026
View reviewed changes

Merge remote-tracking branch 'upstream/main' into feat/1052-conversat…
90bda8b
…ion-session-localization # Conflicts: # packages/ui/src/tool-activity/agent-preview.tsx

Mingqwqqaq force-pushed the feat/1052-conversation-session-localization branch from a07353b to 90bda8bCompare July 18, 2026 14:53

docs: remove superpowers planning artifacts
53c944f

Astro-Han merged commit b2daec5 into apache:mainJul 18, 2026
3 checks passed

Mingqwqqaq mentioned this pull request Jul 19, 2026
fix(ui): localize permission waits and session counts #1230
Merged

Mingqwqqaq added 9 commits July 18, 2026 14:20

docs: design conversation and session localization
bac853c

feat(ui): localize conversation and tool surfaces
5cd320b

feat(desktop): complete conversation journey localization
887b2ad

Merge remote-tracking branch 'upstream/main' into feat/1052-conversat…
de29937
…ion-session-localization

style(ui): normalize conversation source ending
9bcd7a9

test(desktop): align localized tool contracts
cb8d1a9

test(desktop): follow localized tool count copy
6cd874f

test(desktop): follow hidden workbar toggle contract
5ffb25c

Merge remote-tracking branch 'upstream/main' into feat/1052-conversat…
5d226e9
…ion-session-localization # Conflicts: # apps/desktop/e2e/session-workbar.spec.ts

Astro-Han approved these changes Jul 18, 2026
View reviewed changes

Merge remote-tracking branch 'upstream/main' into feat/1052-conversat…
90bda8b
…ion-session-localization # Conflicts: # packages/ui/src/tool-activity/agent-preview.tsx

Mingqwqqaq force-pushed the feat/1052-conversation-session-localization branch from a07353b to 90bda8bCompare July 18, 2026 14:53

docs: remove superpowers planning artifacts
53c944f

Astro-Han merged commit b2daec5 into apache:mainJul 18, 2026
3 checks passed

Mingqwqqaq mentioned this pull request Jul 19, 2026
fix(ui): localize permission waits and session counts #1230
Merged

Mingqwqqaq added 9 commits July 18, 2026 14:20

docs: design conversation and session localization
bac853c

feat(ui): localize conversation and tool surfaces
5cd320b

feat(desktop): complete conversation journey localization
887b2ad

Merge remote-tracking branch 'upstream/main' into feat/1052-conversat…
de29937
…ion-session-localization

style(ui): normalize conversation source ending
9bcd7a9

test(desktop): align localized tool contracts
cb8d1a9

test(desktop): follow localized tool count copy
6cd874f

test(desktop): follow hidden workbar toggle contract
5ffb25c

Merge remote-tracking branch 'upstream/main' into feat/1052-conversat…
5d226e9
…ion-session-localization # Conflicts: # apps/desktop/e2e/session-workbar.spec.ts

Astro-Han approved these changes Jul 18, 2026
View reviewed changes

Merge remote-tracking branch 'upstream/main' into feat/1052-conversat…
90bda8b
…ion-session-localization # Conflicts: # packages/ui/src/tool-activity/agent-preview.tsx

Mingqwqqaq force-pushed the feat/1052-conversation-session-localization branch from a07353b to 90bda8bCompare July 18, 2026 14:53

docs: remove superpowers planning artifacts
53c944f

Astro-Han merged commit b2daec5 into apache:mainJul 18, 2026
3 checks passed

Mingqwqqaq mentioned this pull request Jul 19, 2026
fix(ui): localize permission waits and session counts #1230
Merged

Mingqwqqaq added 9 commits July 18, 2026 14:20

docs: design conversation and session localization
bac853c

feat(ui): localize conversation and tool surfaces
5cd320b

feat(desktop): complete conversation journey localization
887b2ad

Merge remote-tracking branch 'upstream/main' into feat/1052-conversat…
de29937
…ion-session-localization

style(ui): normalize conversation source ending
9bcd7a9

test(desktop): align localized tool contracts
cb8d1a9

test(desktop): follow localized tool count copy
6cd874f

test(desktop): follow hidden workbar toggle contract
5ffb25c

Merge remote-tracking branch 'upstream/main' into feat/1052-conversat…
5d226e9
…ion-session-localization # Conflicts: # apps/desktop/e2e/session-workbar.spec.ts

Astro-Han approved these changes Jul 18, 2026
View reviewed changes

Merge remote-tracking branch 'upstream/main' into feat/1052-conversat…
90bda8b
…ion-session-localization # Conflicts: # packages/ui/src/tool-activity/agent-preview.tsx

Mingqwqqaq force-pushed the feat/1052-conversation-session-localization branch from a07353b to 90bda8bCompare July 18, 2026 14:53

docs: remove superpowers planning artifacts
53c944f

Astro-Han merged commit b2daec5 into apache:mainJul 18, 2026
3 checks passed

Mingqwqqaq mentioned this pull request Jul 19, 2026
fix(ui): localize permission waits and session counts #1230
Merged

Uh oh!

Conversation

Mingqwqqaq commented Jul 18, 2026

Summary

Boundary

Verification

Uh oh!

Astro-Han left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Uh oh!

Conversation

Mingqwqqaq commented Jul 18, 2026

Summary

Boundary

Verification

Uh oh!

Astro-Han left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Uh oh!

Conversation

Mingqwqqaq commented Jul 18, 2026

Summary

Boundary

Verification

Uh oh!

Astro-Han left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Uh oh!

Conversation

Mingqwqqaq commented Jul 18, 2026

Summary

Boundary

Verification

Uh oh!

Astro-Han left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Uh oh!

Conversation

Mingqwqqaq commented Jul 18, 2026

Summary