Uh oh!
There was an error while loading. Please reload this page.
Add RuntimeEvent read model projection - #12
Merged
likun666661 merged 1 commit intoJun 15, 2026
Conversation
jackwener pushed a commit
that referenced
this pull request
Jun 21, 2026
…model Add RuntimeEvent read model projection
jackwener pushed a commit
that referenced
this pull request
Jun 21, 2026
…model Add RuntimeEvent read model projection
jackwener pushed a commit
that referenced
this pull request
Jun 21, 2026
…model Add RuntimeEvent read model projection
jackwener pushed a commit
that referenced
this pull request
Jun 21, 2026
…model Add RuntimeEvent read model projection
This was referenced Aug 26, 2026
liuxiaocs7 added a commit
to liuxiaocs7/maka
that referenced
this pull request
Aug 29, 2026
Replaces the legacy usage:pricing:{list,put,reset} path (and the
UsageStats.pricing read model) — which the review flagged for bypassing
CAS and writing to the default Host — with the production adapter path
from spec apache#2015.
- IPC: new usage:pricing:load / usage:pricing:mutate over the existing
DesktopRuntimeHostClient adapter. The renderer round-trips the exact
snapshot it loaded back as the CAS base, so a save carries the revision
the user was viewing instead of a freshly reloaded latest; the three
legacy handlers are removed and a test fences them (Acceptance apache#12).
- Shared DesktopPricing* types move to src/shared with a boundary
decoder; preload exposes settings.pricing.{load,mutate} scoped to the
Settings-selected Host (fixes the wrong-Host write).
- Renderer: a controller / pure view-model / presentational panel split
(mirrors the Memory page) bound to the selected Host via context. The
tab lists the full built-in ∪ overrides table with a Source column,
resetEffect-aware reset-vs-delete copy, and "Not set" vs explicit $0
cache rates; it drops the range/summary so pricing no longer reads as
time-scoped; field-level validation and every mutation outcome
(committed, synchronized, revision_conflict, saved-refresh-failed,
uncertain) are handled per spec.
- Removes UsageStats.pricing and its now-dead read path.
- Tests: view-model, adapter IPC (base pass-through + legacy-fence gate),
and a linkedom renderer interaction test; Storybook variants (loading,
read-error, built-in-only, mixed, custom-only, narrow).
Interaction states (validation / conflict / uncertain) are covered by the
renderer tests rather than autoplay-disabled stories, per stories/FIDELITY.md.
Refs apache#2015
Generated-by: Claude Code6 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Verification