Uh oh!
There was an error while loading. Please reload this page.
fix(headless): align Harbor execution lifecycles - #1210
Merged
Conversation
Astro-Hanforce-pushed
the
fix/headless-align-harbor-lifecycles
branch
from
July 18, 2026 16:01
9963f89 to
f31f1f2CompareAstro-Hanforce-pushed
the
fix/headless-align-harbor-lifecycles
branch
from
July 18, 2026 17:00
5e61c12 to
4e6568fCompareUh oh!
There was an error while loading. Please reload this page.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
/proc/*/environmarker scans safe under Harbor'spipefail, including large environments where an early-exit grep would otherwise SIGPIPE the producer and skip cleanup.The process cleanup is a lifecycle hygiene boundary, not an adversarial process-containment boundary. A child that deliberately clears both scope markers and leaves the recorded process group requires an execution-owner primitive from Harbor, such as a per-exec cgroup or kill handle; this adapter does not add process-tree heuristics that cannot make that invariant reliable.
Verification
TDD regressions failed before their corresponding fixes for the stale experiment/cache identity, missing Kimi cell timeout, marker-retaining detached timed-out command, and pipefail-sensitive marker scan. The focused Harbor adapter contract passes locally, and an additional Linux
/procintegration proved that command cleanup kills both the wrapper and a marker-retaining detached child while preserving another command's service.node ../../worktree-bootstrap.mjs— complete repository build and stale-dist check passed.npm --workspace @maka/headless test— 1,105 passed, 0 skipped, 0 failed.python:3.13-slim-bookwormcommand-scope cleanup integration — passed.pipefailenabled — passed.git diff --check origin/main...HEAD— passed.Review focus
The branch is split into eight Conventional Commits by independently reviewable intent: timeout evidence recovery, Kimi execution lifetime, cell process-scope reclamation, verifier bootstrap retry, missing-timeout fallback, experiment identity rotation, marker-retaining detached timed-out command reclamation, and pipe-safe process-marker scans.
This PR owns Harbor execution lifecycles only. Runtime model output limits are in #1213. Pass@1 recovery, provider telemetry, trace retention, benchmark reporting, and final-usage drain remain separate changes.