Uh oh!
There was an error while loading. Please reload this page.
refactor(mcp): source brand marks from the simple-icons library - #1220
Merged
Conversation
Replace the #1215 vendored-asset approach (assets/mcp-brands/*.svg + <img>/mask rendering) with per-icon simple-icons imports. Marks now render as an inline <svg> mounting shell wrapping the library's <path>, filled with the official brand hex in light theme. A pure luminance gate flips near-black marks (Vercel/Notion/Slack) to currentColor on the dark plate so they stay legible; the threshold is documented and unit-tested. - add simple-icons@15.22.0 to apps/desktop (per-icon named ESM imports; main renderer chunk grows only ~1.3KB — tree-shaking confirmed) - Notion now renders a real library mark (was a text 'N') - 钉钉/飞书 keep text marks: simple-icons carries no mark for them in any release; macOS/filesystem/memory/… stay non-brand glyph/text by design - allowlist mcp-brand-marks.tsx for inline SVG (library-sourced path geometry, not hand-drawn) in the icon-governance contract - delete vendored SVG assets + dead mask CSS/machinery - extract luminance gate to mcp-brand-contrast.ts + add unit test
Uh oh!
There was an error while loading. Please reload this page.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
User direction: brand marks should come from an icon library, not vendored SVG files. Lucide ships no brand icons (deliberate upstream policy), so this adopts simple-icons — the de-facto brand-icon library (official paths, official brand hex, CC0).
What shipped
Gates
Tree already contains main tip. desktop 2720/2720 · ui 190/190 · typecheck · check-dead-css · knip ×2 = 0 (new dep properly declared) · alignment auditor all fixtures clean. New unit tests for the luminance gate (WCAG endpoints, per-brand flip decisions). CDP light+dark captures visually accepted by maintainer. Implemented by an opus worktree agent.