chore(main): split visual-smoke fixture into per-domain modules (arch R3) by jackwener · Pull Request #1243 · apache/maka

jackwener · 2026-07-19T15:07:48Z

Round 3 of notes/frontend-architecture-map-2026-07-19.md: the 2538-line visual-smoke-fixture.ts god-file becomes a 689-line registry barrel + 6 domain modules (seed-helpers / settings / modules / artifacts / chat / sessions, 100-672 lines each). bot-onboarding-visual-smoke.ts boundary respected.

Zero consumer churn: the 4-symbol public surface stays defined at the original path — main.ts / app-ipc / sessions-ipc / main-window imports byte-identical.
New visual-smoke-fixture-source-helpers.ts aggregator (renderer-shell-source-helpers precedent) keeps source-reading contracts covering all 7 files; copy-hygiene + fixture tests re-pinned, command-palette contract needed no change (its targets stayed in the barrel).
Pure-move proof: alignment auditor walks all 11 fixtures clean; module-skills capture sha256-identical pre/post. settings-bots-onboarding hashes differ pre-existing (live countdown in the modal → PNG never byte-stable; 4-run evidence in the agent report) — flagged as a small follow-up: freeze the countdown under MAKA_VISUAL_SMOKE.

Gates (merged tree): desktop 2744 · ui 196 · typecheck · check-dead-css · knip ×2 = 0. Implemented by an opus worktree agent.

… behind a barrel Pure move of the #1 main-process hotspot (2538 lines) into a thin registry barrel at the original path (visual-smoke-fixture.ts, 689 lines) plus 6 per-domain seeder modules under visual-smoke/: - seed-helpers.ts shared spine (NOW, session-id consts, scenario sets, header/writeSession/writeJson) - scenarios-settings.ts settings/connections/plan/daily-review - scenarios-modules.ts skills-market + MCP - scenarios-artifacts.ts ArtifactPane seed + spec writer - scenarios-chat.ts turn/processing/streaming/permission/error + task-ledger + live-turn projections - scenarios-sessions.ts long-transcript / workstation-statuses / turn-control lineage / long-sidebar / stale The 4-symbol public surface (resolveVisualSmokeFixture, getVisualSmokeState, seedVisualSmokeFixture, VisualSmokeFixture) stays defined in the barrel, so the 3 non-test consumers' imports are byte-identical. bot-onboarding-visual-smoke.ts boundary left untouched. Zero behavior change: registry order stable, every scenario renders identically (alignment auditor clean across all 11 fixtures).

…plit modules Add __tests__/visual-smoke-fixture-source-helpers.ts, a renderer-shell- source-helpers-style aggregator that enumerates the barrel + all 6 visual-smoke/ domain files. Re-pin the two contracts that read the fixture source so the seeded-copy hygiene coverage follows the copy into its new homes: - visible-copy-hygiene-contract: FILES_TO_SCAN now spreads VISUAL_SMOKE_FIXTURE_SOURCE_REPO_PATHS instead of the single monolith - visual-smoke-fixture placeholder-copy check reads the combined source command-palette-a11y-copy-contract needs no change: its assertions target the barrel's scenario set + getVisualSmokeState switch, both unmoved.

…unts)

jackwener · 2026-07-19T15:07:48Z

Round 3 of notes/frontend-architecture-map-2026-07-19.md: the 2538-line visual-smoke-fixture.ts god-file becomes a 689-line registry barrel + 6 domain modules (seed-helpers / settings / modules / artifacts / chat / sessions, 100-672 lines each). bot-onboarding-visual-smoke.ts boundary respected.

Zero consumer churn: the 4-symbol public surface stays defined at the original path — main.ts / app-ipc / sessions-ipc / main-window imports byte-identical.
New visual-smoke-fixture-source-helpers.ts aggregator (renderer-shell-source-helpers precedent) keeps source-reading contracts covering all 7 files; copy-hygiene + fixture tests re-pinned, command-palette contract needed no change (its targets stayed in the barrel).
Pure-move proof: alignment auditor walks all 11 fixtures clean; module-skills capture sha256-identical pre/post. settings-bots-onboarding hashes differ pre-existing (live countdown in the modal → PNG never byte-stable; 4-run evidence in the agent report) — flagged as a small follow-up: freeze the countdown under MAKA_VISUAL_SMOKE.

Gates (merged tree): desktop 2744 · ui 196 · typecheck · check-dead-css · knip ×2 = 0. Implemented by an opus worktree agent.

… behind a barrel Pure move of the #1 main-process hotspot (2538 lines) into a thin registry barrel at the original path (visual-smoke-fixture.ts, 689 lines) plus 6 per-domain seeder modules under visual-smoke/: - seed-helpers.ts shared spine (NOW, session-id consts, scenario sets, header/writeSession/writeJson) - scenarios-settings.ts settings/connections/plan/daily-review - scenarios-modules.ts skills-market + MCP - scenarios-artifacts.ts ArtifactPane seed + spec writer - scenarios-chat.ts turn/processing/streaming/permission/error + task-ledger + live-turn projections - scenarios-sessions.ts long-transcript / workstation-statuses / turn-control lineage / long-sidebar / stale The 4-symbol public surface (resolveVisualSmokeFixture, getVisualSmokeState, seedVisualSmokeFixture, VisualSmokeFixture) stays defined in the barrel, so the 3 non-test consumers' imports are byte-identical. bot-onboarding-visual-smoke.ts boundary left untouched. Zero behavior change: registry order stable, every scenario renders identically (alignment auditor clean across all 11 fixtures).

…plit modules Add __tests__/visual-smoke-fixture-source-helpers.ts, a renderer-shell- source-helpers-style aggregator that enumerates the barrel + all 6 visual-smoke/ domain files. Re-pin the two contracts that read the fixture source so the seeded-copy hygiene coverage follows the copy into its new homes: - visible-copy-hygiene-contract: FILES_TO_SCAN now spreads VISUAL_SMOKE_FIXTURE_SOURCE_REPO_PATHS instead of the single monolith - visual-smoke-fixture placeholder-copy check reads the combined source command-palette-a11y-copy-contract needs no change: its assertions target the barrel's scenario set + getVisualSmokeState switch, both unmoved.

…unts)

jackwener · 2026-07-19T15:07:48Z

Round 3 of notes/frontend-architecture-map-2026-07-19.md: the 2538-line visual-smoke-fixture.ts god-file becomes a 689-line registry barrel + 6 domain modules (seed-helpers / settings / modules / artifacts / chat / sessions, 100-672 lines each). bot-onboarding-visual-smoke.ts boundary respected.

Zero consumer churn: the 4-symbol public surface stays defined at the original path — main.ts / app-ipc / sessions-ipc / main-window imports byte-identical.
New visual-smoke-fixture-source-helpers.ts aggregator (renderer-shell-source-helpers precedent) keeps source-reading contracts covering all 7 files; copy-hygiene + fixture tests re-pinned, command-palette contract needed no change (its targets stayed in the barrel).
Pure-move proof: alignment auditor walks all 11 fixtures clean; module-skills capture sha256-identical pre/post. settings-bots-onboarding hashes differ pre-existing (live countdown in the modal → PNG never byte-stable; 4-run evidence in the agent report) — flagged as a small follow-up: freeze the countdown under MAKA_VISUAL_SMOKE.

Gates (merged tree): desktop 2744 · ui 196 · typecheck · check-dead-css · knip ×2 = 0. Implemented by an opus worktree agent.

… behind a barrel Pure move of the #1 main-process hotspot (2538 lines) into a thin registry barrel at the original path (visual-smoke-fixture.ts, 689 lines) plus 6 per-domain seeder modules under visual-smoke/: - seed-helpers.ts shared spine (NOW, session-id consts, scenario sets, header/writeSession/writeJson) - scenarios-settings.ts settings/connections/plan/daily-review - scenarios-modules.ts skills-market + MCP - scenarios-artifacts.ts ArtifactPane seed + spec writer - scenarios-chat.ts turn/processing/streaming/permission/error + task-ledger + live-turn projections - scenarios-sessions.ts long-transcript / workstation-statuses / turn-control lineage / long-sidebar / stale The 4-symbol public surface (resolveVisualSmokeFixture, getVisualSmokeState, seedVisualSmokeFixture, VisualSmokeFixture) stays defined in the barrel, so the 3 non-test consumers' imports are byte-identical. bot-onboarding-visual-smoke.ts boundary left untouched. Zero behavior change: registry order stable, every scenario renders identically (alignment auditor clean across all 11 fixtures).

…plit modules Add __tests__/visual-smoke-fixture-source-helpers.ts, a renderer-shell- source-helpers-style aggregator that enumerates the barrel + all 6 visual-smoke/ domain files. Re-pin the two contracts that read the fixture source so the seeded-copy hygiene coverage follows the copy into its new homes: - visible-copy-hygiene-contract: FILES_TO_SCAN now spreads VISUAL_SMOKE_FIXTURE_SOURCE_REPO_PATHS instead of the single monolith - visual-smoke-fixture placeholder-copy check reads the combined source command-palette-a11y-copy-contract needs no change: its assertions target the barrel's scenario set + getVisualSmokeState switch, both unmoved.

…unts)

jackwener · 2026-07-19T15:07:48Z

Round 3 of notes/frontend-architecture-map-2026-07-19.md: the 2538-line visual-smoke-fixture.ts god-file becomes a 689-line registry barrel + 6 domain modules (seed-helpers / settings / modules / artifacts / chat / sessions, 100-672 lines each). bot-onboarding-visual-smoke.ts boundary respected.

Zero consumer churn: the 4-symbol public surface stays defined at the original path — main.ts / app-ipc / sessions-ipc / main-window imports byte-identical.
New visual-smoke-fixture-source-helpers.ts aggregator (renderer-shell-source-helpers precedent) keeps source-reading contracts covering all 7 files; copy-hygiene + fixture tests re-pinned, command-palette contract needed no change (its targets stayed in the barrel).
Pure-move proof: alignment auditor walks all 11 fixtures clean; module-skills capture sha256-identical pre/post. settings-bots-onboarding hashes differ pre-existing (live countdown in the modal → PNG never byte-stable; 4-run evidence in the agent report) — flagged as a small follow-up: freeze the countdown under MAKA_VISUAL_SMOKE.

Gates (merged tree): desktop 2744 · ui 196 · typecheck · check-dead-css · knip ×2 = 0. Implemented by an opus worktree agent.

… behind a barrel Pure move of the #1 main-process hotspot (2538 lines) into a thin registry barrel at the original path (visual-smoke-fixture.ts, 689 lines) plus 6 per-domain seeder modules under visual-smoke/: - seed-helpers.ts shared spine (NOW, session-id consts, scenario sets, header/writeSession/writeJson) - scenarios-settings.ts settings/connections/plan/daily-review - scenarios-modules.ts skills-market + MCP - scenarios-artifacts.ts ArtifactPane seed + spec writer - scenarios-chat.ts turn/processing/streaming/permission/error + task-ledger + live-turn projections - scenarios-sessions.ts long-transcript / workstation-statuses / turn-control lineage / long-sidebar / stale The 4-symbol public surface (resolveVisualSmokeFixture, getVisualSmokeState, seedVisualSmokeFixture, VisualSmokeFixture) stays defined in the barrel, so the 3 non-test consumers' imports are byte-identical. bot-onboarding-visual-smoke.ts boundary left untouched. Zero behavior change: registry order stable, every scenario renders identically (alignment auditor clean across all 11 fixtures).

…plit modules Add __tests__/visual-smoke-fixture-source-helpers.ts, a renderer-shell- source-helpers-style aggregator that enumerates the barrel + all 6 visual-smoke/ domain files. Re-pin the two contracts that read the fixture source so the seeded-copy hygiene coverage follows the copy into its new homes: - visible-copy-hygiene-contract: FILES_TO_SCAN now spreads VISUAL_SMOKE_FIXTURE_SOURCE_REPO_PATHS instead of the single monolith - visual-smoke-fixture placeholder-copy check reads the combined source command-palette-a11y-copy-contract needs no change: its assertions target the barrel's scenario set + getVisualSmokeState switch, both unmoved.

…unts)

jackwener · 2026-07-19T15:07:48Z

Round 3 of notes/frontend-architecture-map-2026-07-19.md: the 2538-line visual-smoke-fixture.ts god-file becomes a 689-line registry barrel + 6 domain modules (seed-helpers / settings / modules / artifacts / chat / sessions, 100-672 lines each). bot-onboarding-visual-smoke.ts boundary respected.

Zero consumer churn: the 4-symbol public surface stays defined at the original path — main.ts / app-ipc / sessions-ipc / main-window imports byte-identical.
New visual-smoke-fixture-source-helpers.ts aggregator (renderer-shell-source-helpers precedent) keeps source-reading contracts covering all 7 files; copy-hygiene + fixture tests re-pinned, command-palette contract needed no change (its targets stayed in the barrel).
Pure-move proof: alignment auditor walks all 11 fixtures clean; module-skills capture sha256-identical pre/post. settings-bots-onboarding hashes differ pre-existing (live countdown in the modal → PNG never byte-stable; 4-run evidence in the agent report) — flagged as a small follow-up: freeze the countdown under MAKA_VISUAL_SMOKE.

Gates (merged tree): desktop 2744 · ui 196 · typecheck · check-dead-css · knip ×2 = 0. Implemented by an opus worktree agent.

… behind a barrel Pure move of the #1 main-process hotspot (2538 lines) into a thin registry barrel at the original path (visual-smoke-fixture.ts, 689 lines) plus 6 per-domain seeder modules under visual-smoke/: - seed-helpers.ts shared spine (NOW, session-id consts, scenario sets, header/writeSession/writeJson) - scenarios-settings.ts settings/connections/plan/daily-review - scenarios-modules.ts skills-market + MCP - scenarios-artifacts.ts ArtifactPane seed + spec writer - scenarios-chat.ts turn/processing/streaming/permission/error + task-ledger + live-turn projections - scenarios-sessions.ts long-transcript / workstation-statuses / turn-control lineage / long-sidebar / stale The 4-symbol public surface (resolveVisualSmokeFixture, getVisualSmokeState, seedVisualSmokeFixture, VisualSmokeFixture) stays defined in the barrel, so the 3 non-test consumers' imports are byte-identical. bot-onboarding-visual-smoke.ts boundary left untouched. Zero behavior change: registry order stable, every scenario renders identically (alignment auditor clean across all 11 fixtures).

…plit modules Add __tests__/visual-smoke-fixture-source-helpers.ts, a renderer-shell- source-helpers-style aggregator that enumerates the barrel + all 6 visual-smoke/ domain files. Re-pin the two contracts that read the fixture source so the seeded-copy hygiene coverage follows the copy into its new homes: - visible-copy-hygiene-contract: FILES_TO_SCAN now spreads VISUAL_SMOKE_FIXTURE_SOURCE_REPO_PATHS instead of the single monolith - visual-smoke-fixture placeholder-copy check reads the combined source command-palette-a11y-copy-contract needs no change: its assertions target the barrel's scenario set + getVisualSmokeState switch, both unmoved.

…unts)

jackwener · 2026-07-19T15:07:48Z

Round 3 of notes/frontend-architecture-map-2026-07-19.md: the 2538-line visual-smoke-fixture.ts god-file becomes a 689-line registry barrel + 6 domain modules (seed-helpers / settings / modules / artifacts / chat / sessions, 100-672 lines each). bot-onboarding-visual-smoke.ts boundary respected.

Zero consumer churn: the 4-symbol public surface stays defined at the original path — main.ts / app-ipc / sessions-ipc / main-window imports byte-identical.
New visual-smoke-fixture-source-helpers.ts aggregator (renderer-shell-source-helpers precedent) keeps source-reading contracts covering all 7 files; copy-hygiene + fixture tests re-pinned, command-palette contract needed no change (its targets stayed in the barrel).
Pure-move proof: alignment auditor walks all 11 fixtures clean; module-skills capture sha256-identical pre/post. settings-bots-onboarding hashes differ pre-existing (live countdown in the modal → PNG never byte-stable; 4-run evidence in the agent report) — flagged as a small follow-up: freeze the countdown under MAKA_VISUAL_SMOKE.

Gates (merged tree): desktop 2744 · ui 196 · typecheck · check-dead-css · knip ×2 = 0. Implemented by an opus worktree agent.

… behind a barrel Pure move of the #1 main-process hotspot (2538 lines) into a thin registry barrel at the original path (visual-smoke-fixture.ts, 689 lines) plus 6 per-domain seeder modules under visual-smoke/: - seed-helpers.ts shared spine (NOW, session-id consts, scenario sets, header/writeSession/writeJson) - scenarios-settings.ts settings/connections/plan/daily-review - scenarios-modules.ts skills-market + MCP - scenarios-artifacts.ts ArtifactPane seed + spec writer - scenarios-chat.ts turn/processing/streaming/permission/error + task-ledger + live-turn projections - scenarios-sessions.ts long-transcript / workstation-statuses / turn-control lineage / long-sidebar / stale The 4-symbol public surface (resolveVisualSmokeFixture, getVisualSmokeState, seedVisualSmokeFixture, VisualSmokeFixture) stays defined in the barrel, so the 3 non-test consumers' imports are byte-identical. bot-onboarding-visual-smoke.ts boundary left untouched. Zero behavior change: registry order stable, every scenario renders identically (alignment auditor clean across all 11 fixtures).

…plit modules Add __tests__/visual-smoke-fixture-source-helpers.ts, a renderer-shell- source-helpers-style aggregator that enumerates the barrel + all 6 visual-smoke/ domain files. Re-pin the two contracts that read the fixture source so the seeded-copy hygiene coverage follows the copy into its new homes: - visible-copy-hygiene-contract: FILES_TO_SCAN now spreads VISUAL_SMOKE_FIXTURE_SOURCE_REPO_PATHS instead of the single monolith - visual-smoke-fixture placeholder-copy check reads the combined source command-palette-a11y-copy-contract needs no change: its assertions target the barrel's scenario set + getVisualSmokeState switch, both unmoved.

…unts)

jackwener · 2026-07-19T15:07:48Z

Round 3 of notes/frontend-architecture-map-2026-07-19.md: the 2538-line visual-smoke-fixture.ts god-file becomes a 689-line registry barrel + 6 domain modules (seed-helpers / settings / modules / artifacts / chat / sessions, 100-672 lines each). bot-onboarding-visual-smoke.ts boundary respected.

Zero consumer churn: the 4-symbol public surface stays defined at the original path — main.ts / app-ipc / sessions-ipc / main-window imports byte-identical.
New visual-smoke-fixture-source-helpers.ts aggregator (renderer-shell-source-helpers precedent) keeps source-reading contracts covering all 7 files; copy-hygiene + fixture tests re-pinned, command-palette contract needed no change (its targets stayed in the barrel).
Pure-move proof: alignment auditor walks all 11 fixtures clean; module-skills capture sha256-identical pre/post. settings-bots-onboarding hashes differ pre-existing (live countdown in the modal → PNG never byte-stable; 4-run evidence in the agent report) — flagged as a small follow-up: freeze the countdown under MAKA_VISUAL_SMOKE.

Gates (merged tree): desktop 2744 · ui 196 · typecheck · check-dead-css · knip ×2 = 0. Implemented by an opus worktree agent.

… behind a barrel Pure move of the #1 main-process hotspot (2538 lines) into a thin registry barrel at the original path (visual-smoke-fixture.ts, 689 lines) plus 6 per-domain seeder modules under visual-smoke/: - seed-helpers.ts shared spine (NOW, session-id consts, scenario sets, header/writeSession/writeJson) - scenarios-settings.ts settings/connections/plan/daily-review - scenarios-modules.ts skills-market + MCP - scenarios-artifacts.ts ArtifactPane seed + spec writer - scenarios-chat.ts turn/processing/streaming/permission/error + task-ledger + live-turn projections - scenarios-sessions.ts long-transcript / workstation-statuses / turn-control lineage / long-sidebar / stale The 4-symbol public surface (resolveVisualSmokeFixture, getVisualSmokeState, seedVisualSmokeFixture, VisualSmokeFixture) stays defined in the barrel, so the 3 non-test consumers' imports are byte-identical. bot-onboarding-visual-smoke.ts boundary left untouched. Zero behavior change: registry order stable, every scenario renders identically (alignment auditor clean across all 11 fixtures).

…plit modules Add __tests__/visual-smoke-fixture-source-helpers.ts, a renderer-shell- source-helpers-style aggregator that enumerates the barrel + all 6 visual-smoke/ domain files. Re-pin the two contracts that read the fixture source so the seeded-copy hygiene coverage follows the copy into its new homes: - visible-copy-hygiene-contract: FILES_TO_SCAN now spreads VISUAL_SMOKE_FIXTURE_SOURCE_REPO_PATHS instead of the single monolith - visual-smoke-fixture placeholder-copy check reads the combined source command-palette-a11y-copy-contract needs no change: its assertions target the barrel's scenario set + getVisualSmokeState switch, both unmoved.

…unts)

jackwener · 2026-07-19T15:07:48Z

Round 3 of notes/frontend-architecture-map-2026-07-19.md: the 2538-line visual-smoke-fixture.ts god-file becomes a 689-line registry barrel + 6 domain modules (seed-helpers / settings / modules / artifacts / chat / sessions, 100-672 lines each). bot-onboarding-visual-smoke.ts boundary respected.

Zero consumer churn: the 4-symbol public surface stays defined at the original path — main.ts / app-ipc / sessions-ipc / main-window imports byte-identical.
New visual-smoke-fixture-source-helpers.ts aggregator (renderer-shell-source-helpers precedent) keeps source-reading contracts covering all 7 files; copy-hygiene + fixture tests re-pinned, command-palette contract needed no change (its targets stayed in the barrel).
Pure-move proof: alignment auditor walks all 11 fixtures clean; module-skills capture sha256-identical pre/post. settings-bots-onboarding hashes differ pre-existing (live countdown in the modal → PNG never byte-stable; 4-run evidence in the agent report) — flagged as a small follow-up: freeze the countdown under MAKA_VISUAL_SMOKE.

Gates (merged tree): desktop 2744 · ui 196 · typecheck · check-dead-css · knip ×2 = 0. Implemented by an opus worktree agent.

… behind a barrel Pure move of the #1 main-process hotspot (2538 lines) into a thin registry barrel at the original path (visual-smoke-fixture.ts, 689 lines) plus 6 per-domain seeder modules under visual-smoke/: - seed-helpers.ts shared spine (NOW, session-id consts, scenario sets, header/writeSession/writeJson) - scenarios-settings.ts settings/connections/plan/daily-review - scenarios-modules.ts skills-market + MCP - scenarios-artifacts.ts ArtifactPane seed + spec writer - scenarios-chat.ts turn/processing/streaming/permission/error + task-ledger + live-turn projections - scenarios-sessions.ts long-transcript / workstation-statuses / turn-control lineage / long-sidebar / stale The 4-symbol public surface (resolveVisualSmokeFixture, getVisualSmokeState, seedVisualSmokeFixture, VisualSmokeFixture) stays defined in the barrel, so the 3 non-test consumers' imports are byte-identical. bot-onboarding-visual-smoke.ts boundary left untouched. Zero behavior change: registry order stable, every scenario renders identically (alignment auditor clean across all 11 fixtures).

…plit modules Add __tests__/visual-smoke-fixture-source-helpers.ts, a renderer-shell- source-helpers-style aggregator that enumerates the barrel + all 6 visual-smoke/ domain files. Re-pin the two contracts that read the fixture source so the seeded-copy hygiene coverage follows the copy into its new homes: - visible-copy-hygiene-contract: FILES_TO_SCAN now spreads VISUAL_SMOKE_FIXTURE_SOURCE_REPO_PATHS instead of the single monolith - visual-smoke-fixture placeholder-copy check reads the combined source command-palette-a11y-copy-contract needs no change: its assertions target the barrel's scenario set + getVisualSmokeState switch, both unmoved.

…unts)

jackwener added 4 commits July 19, 2026 23:03

docs: mark R3 done in frontend architecture map (before/after line co…
a6875d0
…unts)

Merge remote-tracking branch 'origin/main' into r3-merge
6deb133

jackwener merged commit b41c324 into mainJul 19, 2026
3 checks passed