Uh oh!
There was an error while loading. Please reload this page.
fix(scripts): repin cu-real-model-launcher test to session-stream split - #1250
Merged
Merged
Conversation
R5 (#1248) moved the isComputerUseRealModelE2e tool/economy branches from main.ts into session-stream.ts and repinned three main-process contract tests to the combined source, but missed scripts/cu-real-model-launcher.test.mjs, which still read main.ts alone. Its `Desktop isolation gate does not enable FakeBackend` case then failed the `? computerUseTools` and `? { economy: false, groups: [] }` matches, turning main CI red. Scan main.ts + session-stream.ts together (same follow-the-split shape as the R5 contract repins) so the isolation-gate pins follow the extracted module. Test-only; no production code changes.
Uh oh!
There was an error while loading. Please reload this page.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
R5 (#1248) moved the
isComputerUseRealModelE2etool / economy branches frommain.tsintosession-stream.tsand repinned the threeapps/desktop/src/main/__tests__/contract tests to the combined main-process source. It missedscripts/cu-real-model-launcher.test.mjs, which still readmain.tsalone — so itsDesktop isolation gate does not enable FakeBackendcase stopped matching? computerUseToolsand? { economy: false, groups: [] }(those expressions now live insession-stream.ts), turning main CI red (run 29695233566).Scan
main.ts+session-stream.tstogether — the same follow-the-split shape as the R5 contract repins — so the isolation-gate pins follow the extracted module.scripts/is.mjsand can't import the.tsreadMainProcessCombinedSourcehelper, so this covers exactly the two files R5 split between instead of the full 38-file aggregator list. Test-only; no production code changes.Verification
node --test scripts/cu-real-model-launcher.test.mjs→Desktop isolation gate does not enable FakeBackendfails onisComputerUseRealModelE2e…? computerUseTools, matching CI run 29695233566.npm run test:scripts→ 116/116 pass (no other scripts test regressed).npx @biomejs/biome check scripts/cu-real-model-launcher.test.mjs→ clean.typecheck,e2e, andrun-workspace-tests-parallel— no TS production code or package code touched.