Uh oh!
There was an error while loading. Please reload this page.
PR-NAV-NEW-TASK-WEIGHT-0: unbold 新任务 + harmonize nav row size - #130
Merged
Conversation
…rence WAWQAQ flagged two sidebar nav-row issues: 1. "新任务" was rendered with `font-weight: 600` permanently — it read as if it were the active page, even when nothing was selected. Active state already carries weight: 600, and reference nav rows are all normal weight at rest. The SquarePen glyph already signals "create", so the label doesn't need to also shout. Drop the explicit weight. 2. `.maka-nav-row` was at 13px / 1.25 line-height (≈16.25px line). The reference-atlas §2 text-sm token is 14px / 20px, which is what the reference sidebar uses. Bump to 14px / 1.43 to match.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
WAWQAQ flagged two sidebar nav typography issues:
新任务was permanently bold (font-weight: 600on.maka-nav-new-task). It read as if it were the active page even when nothing was selected. The active state already carries weight 600, and reference nav rows are all normal-weight at rest. The SquarePen glyph already signals "create" — the label doesn't need to also shout. Dropped the explicit weight..maka-nav-rowwas at 13px / 1.25 line-height (≈16.25px). Reference-atlas §2 text-sm token is 14px / 20px, which is what the reference sidebar uses. Bumped to 14px / 1.43.Test plan
npm testinapps/desktop: 1466 passedsidebar-long-sessions/light-1280-motionshows 新任务 / 每日回顾 / 技能 at uniform weight, with 定时任务 (active) the only weight-600 row.