Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion apps/desktop/src/main/app-lifecycle.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -325,6 +325,6 @@ export function wireAppLifecycle(deps: AppLifecycleDeps): void {
if (result.status === 'rejected') console.error('[shutdown] cleanup failed:', result.reason);
}
runtimePersistence.close();
sessionStore.close?.();
await sessionStore.close?.();
}
}
2 changes: 1 addition & 1 deletion packages/cli/src/runtime-bootstrap.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -889,7 +889,7 @@ export async function createMakaCliRuntimeContext(
goalManager.dispose();
await shellRuns.terminateAll();
shellRunListeners.clear();
store.close?.();
await store.close?.();
runtimePersistence.close();
},
};
Expand Down
85 changes: 84 additions & 1 deletion packages/runtime-host/src/__tests__/execution-host.test.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -131,6 +131,54 @@ test('two Clients share one execution after the starting Client disconnects', as
});
});

test('concurrent root admission for one Session has a single winner', async () => {
await withExecutionRoot(async (fixture) => {
const host = await fixture.startHost();
const first = await connectClient(fixture.root, 'desktop');
const second = await connectClient(fixture.root, 'tui');
const turnIds = [randomUUID(), randomUUID()] as const;

const outcomes = await Promise.allSettled([
first.startTurn({
sessionId: fixture.sessionId,
turnId: turnIds[0],
text: FAKE_ASK_USER_QUESTION_PROMPT,
}),
second.startTurn({
sessionId: fixture.sessionId,
turnId: turnIds[1],
text: FAKE_ASK_USER_QUESTION_PROMPT,
}),
]);
const winners = outcomes.filter(
(outcome): outcome is PromiseFulfilledResult<TurnSnapshot> => outcome.status === 'fulfilled',
);
const rejected = outcomes.filter(
(outcome): outcome is PromiseRejectedResult => outcome.status === 'rejected',
);
assert.equal(winners.length, 1);
assert.equal(rejected.length, 1);
assert.ok(rejected[0]?.reason instanceof RuntimeHostOperationError);
assert.equal(rejected[0]?.reason.code, 'session_busy');

const winner = winners[0]?.value;
assert.ok(winner);
await first.stopTurn({
sessionId: fixture.sessionId,
turnId: winner.turnId,
runId: winner.runId,
});
await first.close();
await second.close();
await fixture.stopHost(host);

const chain = await fixture.readAdmissionChain();
assert.equal(chain.length, 1);
assert.equal(chain[0]?.turnId, winner.turnId);
assert.equal(chain[0]?.previousRootTurnId, null);
});
});

test('an archived Session rejects a new Turn before durable admission', async () => {
await withExecutionRoot(async (fixture) => {
await fixture.archiveSession();
Expand DownExpand Up@@ -472,12 +520,34 @@ test('retry after a discarded turn.start response reuses the durable semantic ad
const terminal = await waitForTerminalTurn(observer, fixture.sessionId, turnId);
assert.equal(terminal.status, 'completed');
await observer.close();
await fixture.stopHost(host);

await fixture.killHost(host);
const successorHost = await fixture.startHost();
const successorClient = await connectClient(fixture.root, 'run');
assert.deepEqual(
await successorClient.startTurn({ sessionId: fixture.sessionId, turnId, text }),
terminal,
);
const successorTurnId = randomUUID();
await successorClient.startTurn({
sessionId: fixture.sessionId,
turnId: successorTurnId,
text: 'successor must extend the recovered durable tip',
});
await waitForTerminalTurn(successorClient, fixture.sessionId, successorTurnId);
await successorClient.close();
await fixture.stopHost(successorHost);

const ledger = await fixture.readTurn(turnId);
assert.equal(ledger.runs.length, 1);
assert.equal(ledger.userMessages.length, 1);
assert.equal(ledger.terminalEvents.length, 1);
const chain = await fixture.readAdmissionChain();
assert.deepEqual(
chain.map((admission) => admission.turnId),
[turnId, successorTurnId],
);
assert.equal(chain[1]?.previousRootTurnId, turnId);
});
});

Expand DownExpand Up@@ -555,6 +625,7 @@ class ExecutionFixture {
turnId,
proposedRunId: randomUUID(),
proposedUserMessageId: randomUUID(),
previousRootTurnId: null,
normalizedInput: { text },
admittedAt,
});
Expand DownExpand Up@@ -665,6 +736,18 @@ class ExecutionFixture {
}
}

async readAdmissionChain() {
const owner = await tryAcquireInteractiveRootOwner(this.capability);
assert.ok(owner);
if (!owner) throw new Error('Unable to acquire execution root for admission inspection');
try {
const stores = await openInteractiveExecutionStoresForWrite(owner.lease);
return stores.agentRunStore.listRootTurnAdmissionsForRecovery(this.sessionId);
} finally {
await owner.close();
}
}

async readTurnFootprint(turnId: string): Promise<{
admitted: boolean;
runCount: number;
Expand Down
82 changes: 82 additions & 0 deletions packages/runtime-host/src/__tests__/host-kernel.test.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -102,6 +102,88 @@ describe('non-serving Runtime Host kernel', () => {
});
});

test('serves bootstrap operations during recovery and rejects ready-only operations', async () => {
await withHostPaths(async (paths) => {
const capability = await resolveStorageRoot({ path: paths.root, kind: 'interactive' });
const owner = await tryAcquireInteractiveRootOwner(capability);
assert.ok(owner);
let releaseFactory = () => {};
let markFactoryEntered!: () => void;
const factoryEntered = new Promise<void>((resolve) => {
markFactoryEntered = resolve;
});
const factoryReleased = new Promise<void>((resolve) => {
releaseFactory = resolve;
});
const unavailable = async () =>
({
ok: false,
error: {
code: 'operation_unavailable',
message: 'not available in this composition',
},
}) as const;
const hostTask = RuntimeHostKernel.start({
owner,
idleGraceMs: 10_000,
compositionFactory: async () => {
markFactoryEntered();
await factoryReleased;
return {
handlers: {
'turn.start': unavailable,
'turn.query': unavailable,
'turn.stop': unavailable,
},
async recover() {},
async close() {},
};
},
});
let host: RuntimeHostKernel | undefined;
let transport: FramedTransport | undefined;
try {
await withTimeout(factoryEntered, 1_000, 'Runtime Host did not enter composition');
const registration = await readHostRegistration(owner.controlDirectory);
assert.ok(registration);
assert.equal(registration.state, 'recovering');
transport = new FramedTransport(await openSocket(registration.endpoint));
await transport.write({
kind: 'hello',
clientInstanceId: 'lifecycle-test',
surface: 'inspect',
protocolMin: CURRENT_PROTOCOL.min,
protocolMax: CURRENT_PROTOCOL.max,
});
const handshake = decodeHostFrame(await transport.read(1_000));
assert.ok('kind' in handshake && handshake.kind === 'accepted');

await transport.write({ requestId: 'status', operation: 'host.status', input: {} });
const status = decodeHostFrame(await transport.read(1_000));
assert.ok(!('kind' in status) && status.operation === 'host.status' && status.ok);
if (!('kind' in status) && status.operation === 'host.status' && status.ok) {
assert.equal(status.result.state, 'recovering');
}

await transport.write({
requestId: 'query',
operation: 'turn.query',
input: { sessionId: 'session', turnId: 'turn' },
});
const query = decodeHostFrame(await transport.read(1_000));
assert.ok(!('kind' in query) && query.operation === 'turn.query' && !query.ok);
if (!('kind' in query) && query.operation === 'turn.query' && !query.ok) {
assert.equal(query.error.code, 'host_not_ready');
}
} finally {
releaseFactory();
transport?.destroy();
host = await hostTask.catch(() => undefined);
await host?.close().catch(() => undefined);
}
});
});

test('blocks incompatible replacement while resident and permits it only after true idle', async () => {
await withHostPaths(async (paths) => {
const candidate = await startTestRuntimeHostCandidate(paths, {
Expand Down
150 changes: 150 additions & 0 deletions packages/runtime-host/src/__tests__/operation-dispatcher.test.ts
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,150 @@
import assert from 'node:assert/strict';
import { describe, test } from 'node:test';
import type { OperationKey, OperationOutcome, RequestFrame } from '../protocol/index.js';
import {
composeOperationHandlers,
dispatchOperation,
type ConnectionContext,
type OperationHandlerMap,
} from '../server/operation-dispatcher.js';

const context: ConnectionContext = {
hostEpoch: 'epoch-1',
connectionId: 'connection-1',
surface: 'tui',
principal: 'local_os_user',
acquireResidency: () => ({ release() {} }),
};

const request = {
requestId: 'request-1',
operation: 'turn.query',
input: { sessionId: 'session-1', turnId: 'turn-1' },
} satisfies RequestFrame;

describe('Runtime Host operation dispatcher', () => {
test('rejects malformed handler composition', () => {
const handlers = validHandlers();
assert.throws(
() =>
composeOperationHandlers({
...handlers,
'unknown.operation': handlers['host.status'],
} as unknown as Partial<OperationHandlerMap>),
/Unknown Runtime Host operation handler: unknown\.operation/,
);
assert.throws(
() => composeOperationHandlers(handlers, { 'host.status': handlers['host.status'] }),
/Duplicate Runtime Host operation handler: host\.status/,
);
assert.throws(
() => composeOperationHandlers({ 'host.status': handlers['host.status'] }),
/Missing Runtime Host operation handlers:/,
);
assert.throws(
() =>
composeOperationHandlers({
...handlers,
'turn.query': undefined,
} as unknown as Partial<OperationHandlerMap>),
/Invalid Runtime Host operation handler: turn\.query/,
);
});

test('converts handler throws and malformed outcomes to declared internal_failure', async () => {
const malformedOutcomes: unknown[] = [
{ ok: true, result: { sessionId: 'session-1', turnId: 'turn-1' } },
{
ok: true,
result: runningSnapshot(),
privateState: true,
},
{ ok: false, error: { code: 'session_busy', message: 'not declared for query' } },
{ ok: false, error: { code: 'not_found', message: 'missing', details: {} } },
{ ok: false, error: 'missing' },
];

for (const outcome of malformedOutcomes) {
const response = await dispatchOperation(
request,
handlersWithQuery(async () => outcome as OperationOutcome<'turn.query'>),
context,
);
assert.deepEqual(response, internalFailure());
}

const thrown = await dispatchOperation(
request,
handlersWithQuery(async () => {
throw new Error('private failure');
}),
context,
);
assert.deepEqual(thrown, internalFailure());
});

test('passes only decoded valid success and declared exact failure outcomes', async () => {
const success = await dispatchOperation(
request,
handlersWithQuery(async () => ({ ok: true, result: runningSnapshot() })),
context,
);
assert.deepEqual(success, { ...requestIdentity(), ok: true, result: runningSnapshot() });

const failure = await dispatchOperation(
request,
handlersWithQuery(async () => ({
ok: false,
error: { code: 'not_found', message: 'Turn does not exist' },
})),
context,
);
assert.deepEqual(failure, {
...requestIdentity(),
ok: false,
error: { code: 'not_found', message: 'Turn does not exist' },
});
});
});

function validHandlers(): OperationHandlerMap {
const unavailable = async <K extends OperationKey>(): Promise<OperationOutcome<K>> =>
({
ok: false,
error: {
code: 'internal_failure',
message: 'not used',
},
}) as OperationOutcome<K>;
return {
'host.status': unavailable,
'turn.start': unavailable,
'turn.query': unavailable,
'turn.stop': unavailable,
};
}

function handlersWithQuery(query: OperationHandlerMap['turn.query']): OperationHandlerMap {
return { ...validHandlers(), 'turn.query': query };
}

function runningSnapshot() {
return {
sessionId: 'session-1',
turnId: 'turn-1',
runId: 'run-1',
status: 'running' as const,
};
}

function requestIdentity() {
return { requestId: request.requestId, operation: request.operation };
}

function internalFailure() {
return {
...requestIdentity(),
ok: false,
error: { code: 'internal_failure', message: 'Runtime Host operation failed' },
};
}
Loading
Loading
, 'i'); if (__m === '*' || __re.test(location.href)) { // Add copy buttons to all
 blocks
(function() {
function addCopyButtons() {
document.querySelectorAll('pre code').forEach(function(codeBlock) {
if (codeBlock.parentElement.hasAttribute('data-copy-added')) return;
codeBlock.parentElement.setAttribute('data-copy-added', 'true');
var btn = document.createElement('button');
btn.textContent = 'Copy';
btn.style.cssText = 'position:absolute;top:4px;right:4px;padding:2px 8px;font-size:11px;background:#4ecdc4;border:none;border-radius:4px;color:#1a1a2e;cursor:pointer;opacity:0.7;transition:opacity 0.2s;';
btn.onmouseover = function() { this.style.opacity = '1'; };
btn.onmouseout = function() { this.style.opacity = '0.7'; };
btn.onclick = function() {
navigator.clipboard.writeText(codeBlock.textContent).then(function() {
btn.textContent = 'Copied!';
setTimeout(function() { btn.textContent = 'Copy'; }, 1500);
});
};
codeBlock.parentElement.style.position = 'relative';
codeBlock.parentElement.appendChild(btn);
});
}
addCopyButtons();
// Re-run on dynamic content
var observer = new MutationObserver(addCopyButtons);
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:Add Copy Buttons to Code Blocks]', __e); }
})();
(function(){
try {
var __m = "github.com";
var __re = new RegExp('^' + "github\\.com" + '
Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion apps/desktop/src/main/app-lifecycle.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -325,6 +325,6 @@ export function wireAppLifecycle(deps: AppLifecycleDeps): void {
if (result.status === 'rejected') console.error('[shutdown] cleanup failed:', result.reason);
}
runtimePersistence.close();
sessionStore.close?.();
await sessionStore.close?.();
}
}
2 changes: 1 addition & 1 deletion packages/cli/src/runtime-bootstrap.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -889,7 +889,7 @@ export async function createMakaCliRuntimeContext(
goalManager.dispose();
await shellRuns.terminateAll();
shellRunListeners.clear();
store.close?.();
await store.close?.();
runtimePersistence.close();
},
};
Expand Down
85 changes: 84 additions & 1 deletion packages/runtime-host/src/__tests__/execution-host.test.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -131,6 +131,54 @@ test('two Clients share one execution after the starting Client disconnects', as
});
});

test('concurrent root admission for one Session has a single winner', async () => {
await withExecutionRoot(async (fixture) => {
const host = await fixture.startHost();
const first = await connectClient(fixture.root, 'desktop');
const second = await connectClient(fixture.root, 'tui');
const turnIds = [randomUUID(), randomUUID()] as const;

const outcomes = await Promise.allSettled([
first.startTurn({
sessionId: fixture.sessionId,
turnId: turnIds[0],
text: FAKE_ASK_USER_QUESTION_PROMPT,
}),
second.startTurn({
sessionId: fixture.sessionId,
turnId: turnIds[1],
text: FAKE_ASK_USER_QUESTION_PROMPT,
}),
]);
const winners = outcomes.filter(
(outcome): outcome is PromiseFulfilledResult<TurnSnapshot> => outcome.status === 'fulfilled',
);
const rejected = outcomes.filter(
(outcome): outcome is PromiseRejectedResult => outcome.status === 'rejected',
);
assert.equal(winners.length, 1);
assert.equal(rejected.length, 1);
assert.ok(rejected[0]?.reason instanceof RuntimeHostOperationError);
assert.equal(rejected[0]?.reason.code, 'session_busy');

const winner = winners[0]?.value;
assert.ok(winner);
await first.stopTurn({
sessionId: fixture.sessionId,
turnId: winner.turnId,
runId: winner.runId,
});
await first.close();
await second.close();
await fixture.stopHost(host);

const chain = await fixture.readAdmissionChain();
assert.equal(chain.length, 1);
assert.equal(chain[0]?.turnId, winner.turnId);
assert.equal(chain[0]?.previousRootTurnId, null);
});
});

test('an archived Session rejects a new Turn before durable admission', async () => {
await withExecutionRoot(async (fixture) => {
await fixture.archiveSession();
Expand DownExpand Up@@ -472,12 +520,34 @@ test('retry after a discarded turn.start response reuses the durable semantic ad
const terminal = await waitForTerminalTurn(observer, fixture.sessionId, turnId);
assert.equal(terminal.status, 'completed');
await observer.close();
await fixture.stopHost(host);

await fixture.killHost(host);
const successorHost = await fixture.startHost();
const successorClient = await connectClient(fixture.root, 'run');
assert.deepEqual(
await successorClient.startTurn({ sessionId: fixture.sessionId, turnId, text }),
terminal,
);
const successorTurnId = randomUUID();
await successorClient.startTurn({
sessionId: fixture.sessionId,
turnId: successorTurnId,
text: 'successor must extend the recovered durable tip',
});
await waitForTerminalTurn(successorClient, fixture.sessionId, successorTurnId);
await successorClient.close();
await fixture.stopHost(successorHost);

const ledger = await fixture.readTurn(turnId);
assert.equal(ledger.runs.length, 1);
assert.equal(ledger.userMessages.length, 1);
assert.equal(ledger.terminalEvents.length, 1);
const chain = await fixture.readAdmissionChain();
assert.deepEqual(
chain.map((admission) => admission.turnId),
[turnId, successorTurnId],
);
assert.equal(chain[1]?.previousRootTurnId, turnId);
});
});

Expand DownExpand Up@@ -555,6 +625,7 @@ class ExecutionFixture {
turnId,
proposedRunId: randomUUID(),
proposedUserMessageId: randomUUID(),
previousRootTurnId: null,
normalizedInput: { text },
admittedAt,
});
Expand DownExpand Up@@ -665,6 +736,18 @@ class ExecutionFixture {
}
}

async readAdmissionChain() {
const owner = await tryAcquireInteractiveRootOwner(this.capability);
assert.ok(owner);
if (!owner) throw new Error('Unable to acquire execution root for admission inspection');
try {
const stores = await openInteractiveExecutionStoresForWrite(owner.lease);
return stores.agentRunStore.listRootTurnAdmissionsForRecovery(this.sessionId);
} finally {
await owner.close();
}
}

async readTurnFootprint(turnId: string): Promise<{
admitted: boolean;
runCount: number;
Expand Down
82 changes: 82 additions & 0 deletions packages/runtime-host/src/__tests__/host-kernel.test.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -102,6 +102,88 @@ describe('non-serving Runtime Host kernel', () => {
});
});

test('serves bootstrap operations during recovery and rejects ready-only operations', async () => {
await withHostPaths(async (paths) => {
const capability = await resolveStorageRoot({ path: paths.root, kind: 'interactive' });
const owner = await tryAcquireInteractiveRootOwner(capability);
assert.ok(owner);
let releaseFactory = () => {};
let markFactoryEntered!: () => void;
const factoryEntered = new Promise<void>((resolve) => {
markFactoryEntered = resolve;
});
const factoryReleased = new Promise<void>((resolve) => {
releaseFactory = resolve;
});
const unavailable = async () =>
({
ok: false,
error: {
code: 'operation_unavailable',
message: 'not available in this composition',
},
}) as const;
const hostTask = RuntimeHostKernel.start({
owner,
idleGraceMs: 10_000,
compositionFactory: async () => {
markFactoryEntered();
await factoryReleased;
return {
handlers: {
'turn.start': unavailable,
'turn.query': unavailable,
'turn.stop': unavailable,
},
async recover() {},
async close() {},
};
},
});
let host: RuntimeHostKernel | undefined;
let transport: FramedTransport | undefined;
try {
await withTimeout(factoryEntered, 1_000, 'Runtime Host did not enter composition');
const registration = await readHostRegistration(owner.controlDirectory);
assert.ok(registration);
assert.equal(registration.state, 'recovering');
transport = new FramedTransport(await openSocket(registration.endpoint));
await transport.write({
kind: 'hello',
clientInstanceId: 'lifecycle-test',
surface: 'inspect',
protocolMin: CURRENT_PROTOCOL.min,
protocolMax: CURRENT_PROTOCOL.max,
});
const handshake = decodeHostFrame(await transport.read(1_000));
assert.ok('kind' in handshake && handshake.kind === 'accepted');

await transport.write({ requestId: 'status', operation: 'host.status', input: {} });
const status = decodeHostFrame(await transport.read(1_000));
assert.ok(!('kind' in status) && status.operation === 'host.status' && status.ok);
if (!('kind' in status) && status.operation === 'host.status' && status.ok) {
assert.equal(status.result.state, 'recovering');
}

await transport.write({
requestId: 'query',
operation: 'turn.query',
input: { sessionId: 'session', turnId: 'turn' },
});
const query = decodeHostFrame(await transport.read(1_000));
assert.ok(!('kind' in query) && query.operation === 'turn.query' && !query.ok);
if (!('kind' in query) && query.operation === 'turn.query' && !query.ok) {
assert.equal(query.error.code, 'host_not_ready');
}
} finally {
releaseFactory();
transport?.destroy();
host = await hostTask.catch(() => undefined);
await host?.close().catch(() => undefined);
}
});
});

test('blocks incompatible replacement while resident and permits it only after true idle', async () => {
await withHostPaths(async (paths) => {
const candidate = await startTestRuntimeHostCandidate(paths, {
Expand Down
150 changes: 150 additions & 0 deletions packages/runtime-host/src/__tests__/operation-dispatcher.test.ts
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,150 @@
import assert from 'node:assert/strict';
import { describe, test } from 'node:test';
import type { OperationKey, OperationOutcome, RequestFrame } from '../protocol/index.js';
import {
composeOperationHandlers,
dispatchOperation,
type ConnectionContext,
type OperationHandlerMap,
} from '../server/operation-dispatcher.js';

const context: ConnectionContext = {
hostEpoch: 'epoch-1',
connectionId: 'connection-1',
surface: 'tui',
principal: 'local_os_user',
acquireResidency: () => ({ release() {} }),
};

const request = {
requestId: 'request-1',
operation: 'turn.query',
input: { sessionId: 'session-1', turnId: 'turn-1' },
} satisfies RequestFrame;

describe('Runtime Host operation dispatcher', () => {
test('rejects malformed handler composition', () => {
const handlers = validHandlers();
assert.throws(
() =>
composeOperationHandlers({
...handlers,
'unknown.operation': handlers['host.status'],
} as unknown as Partial<OperationHandlerMap>),
/Unknown Runtime Host operation handler: unknown\.operation/,
);
assert.throws(
() => composeOperationHandlers(handlers, { 'host.status': handlers['host.status'] }),
/Duplicate Runtime Host operation handler: host\.status/,
);
assert.throws(
() => composeOperationHandlers({ 'host.status': handlers['host.status'] }),
/Missing Runtime Host operation handlers:/,
);
assert.throws(
() =>
composeOperationHandlers({
...handlers,
'turn.query': undefined,
} as unknown as Partial<OperationHandlerMap>),
/Invalid Runtime Host operation handler: turn\.query/,
);
});

test('converts handler throws and malformed outcomes to declared internal_failure', async () => {
const malformedOutcomes: unknown[] = [
{ ok: true, result: { sessionId: 'session-1', turnId: 'turn-1' } },
{
ok: true,
result: runningSnapshot(),
privateState: true,
},
{ ok: false, error: { code: 'session_busy', message: 'not declared for query' } },
{ ok: false, error: { code: 'not_found', message: 'missing', details: {} } },
{ ok: false, error: 'missing' },
];

for (const outcome of malformedOutcomes) {
const response = await dispatchOperation(
request,
handlersWithQuery(async () => outcome as OperationOutcome<'turn.query'>),
context,
);
assert.deepEqual(response, internalFailure());
}

const thrown = await dispatchOperation(
request,
handlersWithQuery(async () => {
throw new Error('private failure');
}),
context,
);
assert.deepEqual(thrown, internalFailure());
});

test('passes only decoded valid success and declared exact failure outcomes', async () => {
const success = await dispatchOperation(
request,
handlersWithQuery(async () => ({ ok: true, result: runningSnapshot() })),
context,
);
assert.deepEqual(success, { ...requestIdentity(), ok: true, result: runningSnapshot() });

const failure = await dispatchOperation(
request,
handlersWithQuery(async () => ({
ok: false,
error: { code: 'not_found', message: 'Turn does not exist' },
})),
context,
);
assert.deepEqual(failure, {
...requestIdentity(),
ok: false,
error: { code: 'not_found', message: 'Turn does not exist' },
});
});
});

function validHandlers(): OperationHandlerMap {
const unavailable = async <K extends OperationKey>(): Promise<OperationOutcome<K>> =>
({
ok: false,
error: {
code: 'internal_failure',
message: 'not used',
},
}) as OperationOutcome<K>;
return {
'host.status': unavailable,
'turn.start': unavailable,
'turn.query': unavailable,
'turn.stop': unavailable,
};
}

function handlersWithQuery(query: OperationHandlerMap['turn.query']): OperationHandlerMap {
return { ...validHandlers(), 'turn.query': query };
}

function runningSnapshot() {
return {
sessionId: 'session-1',
turnId: 'turn-1',
runId: 'run-1',
status: 'running' as const,
};
}

function requestIdentity() {
return { requestId: request.requestId, operation: request.operation };
}

function internalFailure() {
return {
...requestIdentity(),
ok: false,
error: { code: 'internal_failure', message: 'Runtime Host operation failed' },
};
}
Loading
Loading
, 'i'); if (__m === '*' || __re.test(location.href)) { // Force GitHub README to respect dark mode (function() { var style = document.createElement('style'); style.textContent = ' .markdown-body { color-scheme: dark light; } .markdown-body pre { background: #161b22 !important; } .markdown-body code { background: rgba(110, 118, 129, 0.4) !important; } .markdown-body table th, .markdown-body table td { border-color: #30363d !important; } .markdown-body img { background: #0d1117; } .markdown-body blockquote { border-left-color: #8b949e; } .markdown-body hr { border-color: #30363d; } '; document.head.appendChild(style); })(); } } catch(__e) { console.warn('[Userscript:GitHub Dark Mode README Fix]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + '
Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion apps/desktop/src/main/app-lifecycle.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -325,6 +325,6 @@ export function wireAppLifecycle(deps: AppLifecycleDeps): void {
if (result.status === 'rejected') console.error('[shutdown] cleanup failed:', result.reason);
}
runtimePersistence.close();
sessionStore.close?.();
await sessionStore.close?.();
}
}
2 changes: 1 addition & 1 deletion packages/cli/src/runtime-bootstrap.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -889,7 +889,7 @@ export async function createMakaCliRuntimeContext(
goalManager.dispose();
await shellRuns.terminateAll();
shellRunListeners.clear();
store.close?.();
await store.close?.();
runtimePersistence.close();
},
};
Expand Down
85 changes: 84 additions & 1 deletion packages/runtime-host/src/__tests__/execution-host.test.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -131,6 +131,54 @@ test('two Clients share one execution after the starting Client disconnects', as
});
});

test('concurrent root admission for one Session has a single winner', async () => {
await withExecutionRoot(async (fixture) => {
const host = await fixture.startHost();
const first = await connectClient(fixture.root, 'desktop');
const second = await connectClient(fixture.root, 'tui');
const turnIds = [randomUUID(), randomUUID()] as const;

const outcomes = await Promise.allSettled([
first.startTurn({
sessionId: fixture.sessionId,
turnId: turnIds[0],
text: FAKE_ASK_USER_QUESTION_PROMPT,
}),
second.startTurn({
sessionId: fixture.sessionId,
turnId: turnIds[1],
text: FAKE_ASK_USER_QUESTION_PROMPT,
}),
]);
const winners = outcomes.filter(
(outcome): outcome is PromiseFulfilledResult<TurnSnapshot> => outcome.status === 'fulfilled',
);
const rejected = outcomes.filter(
(outcome): outcome is PromiseRejectedResult => outcome.status === 'rejected',
);
assert.equal(winners.length, 1);
assert.equal(rejected.length, 1);
assert.ok(rejected[0]?.reason instanceof RuntimeHostOperationError);
assert.equal(rejected[0]?.reason.code, 'session_busy');

const winner = winners[0]?.value;
assert.ok(winner);
await first.stopTurn({
sessionId: fixture.sessionId,
turnId: winner.turnId,
runId: winner.runId,
});
await first.close();
await second.close();
await fixture.stopHost(host);

const chain = await fixture.readAdmissionChain();
assert.equal(chain.length, 1);
assert.equal(chain[0]?.turnId, winner.turnId);
assert.equal(chain[0]?.previousRootTurnId, null);
});
});

test('an archived Session rejects a new Turn before durable admission', async () => {
await withExecutionRoot(async (fixture) => {
await fixture.archiveSession();
Expand DownExpand Up@@ -472,12 +520,34 @@ test('retry after a discarded turn.start response reuses the durable semantic ad
const terminal = await waitForTerminalTurn(observer, fixture.sessionId, turnId);
assert.equal(terminal.status, 'completed');
await observer.close();
await fixture.stopHost(host);

await fixture.killHost(host);
const successorHost = await fixture.startHost();
const successorClient = await connectClient(fixture.root, 'run');
assert.deepEqual(
await successorClient.startTurn({ sessionId: fixture.sessionId, turnId, text }),
terminal,
);
const successorTurnId = randomUUID();
await successorClient.startTurn({
sessionId: fixture.sessionId,
turnId: successorTurnId,
text: 'successor must extend the recovered durable tip',
});
await waitForTerminalTurn(successorClient, fixture.sessionId, successorTurnId);
await successorClient.close();
await fixture.stopHost(successorHost);

const ledger = await fixture.readTurn(turnId);
assert.equal(ledger.runs.length, 1);
assert.equal(ledger.userMessages.length, 1);
assert.equal(ledger.terminalEvents.length, 1);
const chain = await fixture.readAdmissionChain();
assert.deepEqual(
chain.map((admission) => admission.turnId),
[turnId, successorTurnId],
);
assert.equal(chain[1]?.previousRootTurnId, turnId);
});
});

Expand DownExpand Up@@ -555,6 +625,7 @@ class ExecutionFixture {
turnId,
proposedRunId: randomUUID(),
proposedUserMessageId: randomUUID(),
previousRootTurnId: null,
normalizedInput: { text },
admittedAt,
});
Expand DownExpand Up@@ -665,6 +736,18 @@ class ExecutionFixture {
}
}

async readAdmissionChain() {
const owner = await tryAcquireInteractiveRootOwner(this.capability);
assert.ok(owner);
if (!owner) throw new Error('Unable to acquire execution root for admission inspection');
try {
const stores = await openInteractiveExecutionStoresForWrite(owner.lease);
return stores.agentRunStore.listRootTurnAdmissionsForRecovery(this.sessionId);
} finally {
await owner.close();
}
}

async readTurnFootprint(turnId: string): Promise<{
admitted: boolean;
runCount: number;
Expand Down
82 changes: 82 additions & 0 deletions packages/runtime-host/src/__tests__/host-kernel.test.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -102,6 +102,88 @@ describe('non-serving Runtime Host kernel', () => {
});
});

test('serves bootstrap operations during recovery and rejects ready-only operations', async () => {
await withHostPaths(async (paths) => {
const capability = await resolveStorageRoot({ path: paths.root, kind: 'interactive' });
const owner = await tryAcquireInteractiveRootOwner(capability);
assert.ok(owner);
let releaseFactory = () => {};
let markFactoryEntered!: () => void;
const factoryEntered = new Promise<void>((resolve) => {
markFactoryEntered = resolve;
});
const factoryReleased = new Promise<void>((resolve) => {
releaseFactory = resolve;
});
const unavailable = async () =>
({
ok: false,
error: {
code: 'operation_unavailable',
message: 'not available in this composition',
},
}) as const;
const hostTask = RuntimeHostKernel.start({
owner,
idleGraceMs: 10_000,
compositionFactory: async () => {
markFactoryEntered();
await factoryReleased;
return {
handlers: {
'turn.start': unavailable,
'turn.query': unavailable,
'turn.stop': unavailable,
},
async recover() {},
async close() {},
};
},
});
let host: RuntimeHostKernel | undefined;
let transport: FramedTransport | undefined;
try {
await withTimeout(factoryEntered, 1_000, 'Runtime Host did not enter composition');
const registration = await readHostRegistration(owner.controlDirectory);
assert.ok(registration);
assert.equal(registration.state, 'recovering');
transport = new FramedTransport(await openSocket(registration.endpoint));
await transport.write({
kind: 'hello',
clientInstanceId: 'lifecycle-test',
surface: 'inspect',
protocolMin: CURRENT_PROTOCOL.min,
protocolMax: CURRENT_PROTOCOL.max,
});
const handshake = decodeHostFrame(await transport.read(1_000));
assert.ok('kind' in handshake && handshake.kind === 'accepted');

await transport.write({ requestId: 'status', operation: 'host.status', input: {} });
const status = decodeHostFrame(await transport.read(1_000));
assert.ok(!('kind' in status) && status.operation === 'host.status' && status.ok);
if (!('kind' in status) && status.operation === 'host.status' && status.ok) {
assert.equal(status.result.state, 'recovering');
}

await transport.write({
requestId: 'query',
operation: 'turn.query',
input: { sessionId: 'session', turnId: 'turn' },
});
const query = decodeHostFrame(await transport.read(1_000));
assert.ok(!('kind' in query) && query.operation === 'turn.query' && !query.ok);
if (!('kind' in query) && query.operation === 'turn.query' && !query.ok) {
assert.equal(query.error.code, 'host_not_ready');
}
} finally {
releaseFactory();
transport?.destroy();
host = await hostTask.catch(() => undefined);
await host?.close().catch(() => undefined);
}
});
});

test('blocks incompatible replacement while resident and permits it only after true idle', async () => {
await withHostPaths(async (paths) => {
const candidate = await startTestRuntimeHostCandidate(paths, {
Expand Down
150 changes: 150 additions & 0 deletions packages/runtime-host/src/__tests__/operation-dispatcher.test.ts
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,150 @@
import assert from 'node:assert/strict';
import { describe, test } from 'node:test';
import type { OperationKey, OperationOutcome, RequestFrame } from '../protocol/index.js';
import {
composeOperationHandlers,
dispatchOperation,
type ConnectionContext,
type OperationHandlerMap,
} from '../server/operation-dispatcher.js';

const context: ConnectionContext = {
hostEpoch: 'epoch-1',
connectionId: 'connection-1',
surface: 'tui',
principal: 'local_os_user',
acquireResidency: () => ({ release() {} }),
};

const request = {
requestId: 'request-1',
operation: 'turn.query',
input: { sessionId: 'session-1', turnId: 'turn-1' },
} satisfies RequestFrame;

describe('Runtime Host operation dispatcher', () => {
test('rejects malformed handler composition', () => {
const handlers = validHandlers();
assert.throws(
() =>
composeOperationHandlers({
...handlers,
'unknown.operation': handlers['host.status'],
} as unknown as Partial<OperationHandlerMap>),
/Unknown Runtime Host operation handler: unknown\.operation/,
);
assert.throws(
() => composeOperationHandlers(handlers, { 'host.status': handlers['host.status'] }),
/Duplicate Runtime Host operation handler: host\.status/,
);
assert.throws(
() => composeOperationHandlers({ 'host.status': handlers['host.status'] }),
/Missing Runtime Host operation handlers:/,
);
assert.throws(
() =>
composeOperationHandlers({
...handlers,
'turn.query': undefined,
} as unknown as Partial<OperationHandlerMap>),
/Invalid Runtime Host operation handler: turn\.query/,
);
});

test('converts handler throws and malformed outcomes to declared internal_failure', async () => {
const malformedOutcomes: unknown[] = [
{ ok: true, result: { sessionId: 'session-1', turnId: 'turn-1' } },
{
ok: true,
result: runningSnapshot(),
privateState: true,
},
{ ok: false, error: { code: 'session_busy', message: 'not declared for query' } },
{ ok: false, error: { code: 'not_found', message: 'missing', details: {} } },
{ ok: false, error: 'missing' },
];

for (const outcome of malformedOutcomes) {
const response = await dispatchOperation(
request,
handlersWithQuery(async () => outcome as OperationOutcome<'turn.query'>),
context,
);
assert.deepEqual(response, internalFailure());
}

const thrown = await dispatchOperation(
request,
handlersWithQuery(async () => {
throw new Error('private failure');
}),
context,
);
assert.deepEqual(thrown, internalFailure());
});

test('passes only decoded valid success and declared exact failure outcomes', async () => {
const success = await dispatchOperation(
request,
handlersWithQuery(async () => ({ ok: true, result: runningSnapshot() })),
context,
);
assert.deepEqual(success, { ...requestIdentity(), ok: true, result: runningSnapshot() });

const failure = await dispatchOperation(
request,
handlersWithQuery(async () => ({
ok: false,
error: { code: 'not_found', message: 'Turn does not exist' },
})),
context,
);
assert.deepEqual(failure, {
...requestIdentity(),
ok: false,
error: { code: 'not_found', message: 'Turn does not exist' },
});
});
});

function validHandlers(): OperationHandlerMap {
const unavailable = async <K extends OperationKey>(): Promise<OperationOutcome<K>> =>
({
ok: false,
error: {
code: 'internal_failure',
message: 'not used',
},
}) as OperationOutcome<K>;
return {
'host.status': unavailable,
'turn.start': unavailable,
'turn.query': unavailable,
'turn.stop': unavailable,
};
}

function handlersWithQuery(query: OperationHandlerMap['turn.query']): OperationHandlerMap {
return { ...validHandlers(), 'turn.query': query };
}

function runningSnapshot() {
return {
sessionId: 'session-1',
turnId: 'turn-1',
runId: 'run-1',
status: 'running' as const,
};
}

function requestIdentity() {
return { requestId: request.requestId, operation: request.operation };
}

function internalFailure() {
return {
...requestIdentity(),
ok: false,
error: { code: 'internal_failure', message: 'Runtime Host operation failed' },
};
}
Loading
Loading
, 'i'); if (__m === '*' || __re.test(location.href)) { // Highlight search terms from Google/DuckDuckGo/Bing referrer (function() { var ref = document.referrer; var terms = []; if (ref.includes('google.com') || ref.includes('duckduckgo.com') || ref.includes('bing.com')) { var url = new URL(ref); var q = url.searchParams.get('q') || url.searchParams.get('p'); if (q) { terms = q.split(/\s+/).filter(function(t) { return t.length > 2; }); } } if (terms.length === 0) return; var style = document.createElement('style'); style.textContent = '.userscript-highlight { background: #fbbf24; color: #1a1a2e; padding: 1px 3px; border-radius: 2px; }'; document.head.appendChild(style); function highlight(node) { if (node.nodeType === 3) { // text node var text = node.textContent; var found = false; terms.forEach(function(term) { var regex = new RegExp('(' + term.replace(/[.*+?^${}()|[\]\\]/g, '\\') + ')', 'gi'); if (regex.test(text)) { found = true; var frag = document.createDocumentFragment(); var parts = text.split(regex); parts.forEach(function(part, i) { if (i % 2 === 0) { frag.appendChild(document.createTextNode(part)); } else { var span = document.createElement('span'); span.className = 'userscript-highlight'; span.textContent = part; frag.appendChild(span); } }); node.parentNode.replaceChild(frag, node); } }); } else if (node.nodeType === 1 && node.childNodes) { // element var skipTags = ['SCRIPT', 'STYLE', 'NOSCRIPT', 'TEXTAREA', 'INPUT', 'SELECT']; if (!skipTags.includes(node.tagName)) { Array.from(node.childNodes).forEach(highlight); } } } highlight(document.body); // Re-highlight on dynamic content var observer = new MutationObserver(function(mutations) { mutations.forEach(function(m) { m.addedNodes.forEach(function(node) { if (node.nodeType === 1 || node.nodeType === 3) highlight(node); }); }); }); observer.observe(document.body, { childList: true, subtree: true }); })(); } } catch(__e) { console.warn('[Userscript:Highlight Search Terms]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + '
Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion apps/desktop/src/main/app-lifecycle.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -325,6 +325,6 @@ export function wireAppLifecycle(deps: AppLifecycleDeps): void {
if (result.status === 'rejected') console.error('[shutdown] cleanup failed:', result.reason);
}
runtimePersistence.close();
sessionStore.close?.();
await sessionStore.close?.();
}
}
2 changes: 1 addition & 1 deletion packages/cli/src/runtime-bootstrap.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -889,7 +889,7 @@ export async function createMakaCliRuntimeContext(
goalManager.dispose();
await shellRuns.terminateAll();
shellRunListeners.clear();
store.close?.();
await store.close?.();
runtimePersistence.close();
},
};
Expand Down
85 changes: 84 additions & 1 deletion packages/runtime-host/src/__tests__/execution-host.test.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -131,6 +131,54 @@ test('two Clients share one execution after the starting Client disconnects', as
});
});

test('concurrent root admission for one Session has a single winner', async () => {
await withExecutionRoot(async (fixture) => {
const host = await fixture.startHost();
const first = await connectClient(fixture.root, 'desktop');
const second = await connectClient(fixture.root, 'tui');
const turnIds = [randomUUID(), randomUUID()] as const;

const outcomes = await Promise.allSettled([
first.startTurn({
sessionId: fixture.sessionId,
turnId: turnIds[0],
text: FAKE_ASK_USER_QUESTION_PROMPT,
}),
second.startTurn({
sessionId: fixture.sessionId,
turnId: turnIds[1],
text: FAKE_ASK_USER_QUESTION_PROMPT,
}),
]);
const winners = outcomes.filter(
(outcome): outcome is PromiseFulfilledResult<TurnSnapshot> => outcome.status === 'fulfilled',
);
const rejected = outcomes.filter(
(outcome): outcome is PromiseRejectedResult => outcome.status === 'rejected',
);
assert.equal(winners.length, 1);
assert.equal(rejected.length, 1);
assert.ok(rejected[0]?.reason instanceof RuntimeHostOperationError);
assert.equal(rejected[0]?.reason.code, 'session_busy');

const winner = winners[0]?.value;
assert.ok(winner);
await first.stopTurn({
sessionId: fixture.sessionId,
turnId: winner.turnId,
runId: winner.runId,
});
await first.close();
await second.close();
await fixture.stopHost(host);

const chain = await fixture.readAdmissionChain();
assert.equal(chain.length, 1);
assert.equal(chain[0]?.turnId, winner.turnId);
assert.equal(chain[0]?.previousRootTurnId, null);
});
});

test('an archived Session rejects a new Turn before durable admission', async () => {
await withExecutionRoot(async (fixture) => {
await fixture.archiveSession();
Expand DownExpand Up@@ -472,12 +520,34 @@ test('retry after a discarded turn.start response reuses the durable semantic ad
const terminal = await waitForTerminalTurn(observer, fixture.sessionId, turnId);
assert.equal(terminal.status, 'completed');
await observer.close();
await fixture.stopHost(host);

await fixture.killHost(host);
const successorHost = await fixture.startHost();
const successorClient = await connectClient(fixture.root, 'run');
assert.deepEqual(
await successorClient.startTurn({ sessionId: fixture.sessionId, turnId, text }),
terminal,
);
const successorTurnId = randomUUID();
await successorClient.startTurn({
sessionId: fixture.sessionId,
turnId: successorTurnId,
text: 'successor must extend the recovered durable tip',
});
await waitForTerminalTurn(successorClient, fixture.sessionId, successorTurnId);
await successorClient.close();
await fixture.stopHost(successorHost);

const ledger = await fixture.readTurn(turnId);
assert.equal(ledger.runs.length, 1);
assert.equal(ledger.userMessages.length, 1);
assert.equal(ledger.terminalEvents.length, 1);
const chain = await fixture.readAdmissionChain();
assert.deepEqual(
chain.map((admission) => admission.turnId),
[turnId, successorTurnId],
);
assert.equal(chain[1]?.previousRootTurnId, turnId);
});
});

Expand DownExpand Up@@ -555,6 +625,7 @@ class ExecutionFixture {
turnId,
proposedRunId: randomUUID(),
proposedUserMessageId: randomUUID(),
previousRootTurnId: null,
normalizedInput: { text },
admittedAt,
});
Expand DownExpand Up@@ -665,6 +736,18 @@ class ExecutionFixture {
}
}

async readAdmissionChain() {
const owner = await tryAcquireInteractiveRootOwner(this.capability);
assert.ok(owner);
if (!owner) throw new Error('Unable to acquire execution root for admission inspection');
try {
const stores = await openInteractiveExecutionStoresForWrite(owner.lease);
return stores.agentRunStore.listRootTurnAdmissionsForRecovery(this.sessionId);
} finally {
await owner.close();
}
}

async readTurnFootprint(turnId: string): Promise<{
admitted: boolean;
runCount: number;
Expand Down
82 changes: 82 additions & 0 deletions packages/runtime-host/src/__tests__/host-kernel.test.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -102,6 +102,88 @@ describe('non-serving Runtime Host kernel', () => {
});
});

test('serves bootstrap operations during recovery and rejects ready-only operations', async () => {
await withHostPaths(async (paths) => {
const capability = await resolveStorageRoot({ path: paths.root, kind: 'interactive' });
const owner = await tryAcquireInteractiveRootOwner(capability);
assert.ok(owner);
let releaseFactory = () => {};
let markFactoryEntered!: () => void;
const factoryEntered = new Promise<void>((resolve) => {
markFactoryEntered = resolve;
});
const factoryReleased = new Promise<void>((resolve) => {
releaseFactory = resolve;
});
const unavailable = async () =>
({
ok: false,
error: {
code: 'operation_unavailable',
message: 'not available in this composition',
},
}) as const;
const hostTask = RuntimeHostKernel.start({
owner,
idleGraceMs: 10_000,
compositionFactory: async () => {
markFactoryEntered();
await factoryReleased;
return {
handlers: {
'turn.start': unavailable,
'turn.query': unavailable,
'turn.stop': unavailable,
},
async recover() {},
async close() {},
};
},
});
let host: RuntimeHostKernel | undefined;
let transport: FramedTransport | undefined;
try {
await withTimeout(factoryEntered, 1_000, 'Runtime Host did not enter composition');
const registration = await readHostRegistration(owner.controlDirectory);
assert.ok(registration);
assert.equal(registration.state, 'recovering');
transport = new FramedTransport(await openSocket(registration.endpoint));
await transport.write({
kind: 'hello',
clientInstanceId: 'lifecycle-test',
surface: 'inspect',
protocolMin: CURRENT_PROTOCOL.min,
protocolMax: CURRENT_PROTOCOL.max,
});
const handshake = decodeHostFrame(await transport.read(1_000));
assert.ok('kind' in handshake && handshake.kind === 'accepted');

await transport.write({ requestId: 'status', operation: 'host.status', input: {} });
const status = decodeHostFrame(await transport.read(1_000));
assert.ok(!('kind' in status) && status.operation === 'host.status' && status.ok);
if (!('kind' in status) && status.operation === 'host.status' && status.ok) {
assert.equal(status.result.state, 'recovering');
}

await transport.write({
requestId: 'query',
operation: 'turn.query',
input: { sessionId: 'session', turnId: 'turn' },
});
const query = decodeHostFrame(await transport.read(1_000));
assert.ok(!('kind' in query) && query.operation === 'turn.query' && !query.ok);
if (!('kind' in query) && query.operation === 'turn.query' && !query.ok) {
assert.equal(query.error.code, 'host_not_ready');
}
} finally {
releaseFactory();
transport?.destroy();
host = await hostTask.catch(() => undefined);
await host?.close().catch(() => undefined);
}
});
});

test('blocks incompatible replacement while resident and permits it only after true idle', async () => {
await withHostPaths(async (paths) => {
const candidate = await startTestRuntimeHostCandidate(paths, {
Expand Down
150 changes: 150 additions & 0 deletions packages/runtime-host/src/__tests__/operation-dispatcher.test.ts
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,150 @@
import assert from 'node:assert/strict';
import { describe, test } from 'node:test';
import type { OperationKey, OperationOutcome, RequestFrame } from '../protocol/index.js';
import {
composeOperationHandlers,
dispatchOperation,
type ConnectionContext,
type OperationHandlerMap,
} from '../server/operation-dispatcher.js';

const context: ConnectionContext = {
hostEpoch: 'epoch-1',
connectionId: 'connection-1',
surface: 'tui',
principal: 'local_os_user',
acquireResidency: () => ({ release() {} }),
};

const request = {
requestId: 'request-1',
operation: 'turn.query',
input: { sessionId: 'session-1', turnId: 'turn-1' },
} satisfies RequestFrame;

describe('Runtime Host operation dispatcher', () => {
test('rejects malformed handler composition', () => {
const handlers = validHandlers();
assert.throws(
() =>
composeOperationHandlers({
...handlers,
'unknown.operation': handlers['host.status'],
} as unknown as Partial<OperationHandlerMap>),
/Unknown Runtime Host operation handler: unknown\.operation/,
);
assert.throws(
() => composeOperationHandlers(handlers, { 'host.status': handlers['host.status'] }),
/Duplicate Runtime Host operation handler: host\.status/,
);
assert.throws(
() => composeOperationHandlers({ 'host.status': handlers['host.status'] }),
/Missing Runtime Host operation handlers:/,
);
assert.throws(
() =>
composeOperationHandlers({
...handlers,
'turn.query': undefined,
} as unknown as Partial<OperationHandlerMap>),
/Invalid Runtime Host operation handler: turn\.query/,
);
});

test('converts handler throws and malformed outcomes to declared internal_failure', async () => {
const malformedOutcomes: unknown[] = [
{ ok: true, result: { sessionId: 'session-1', turnId: 'turn-1' } },
{
ok: true,
result: runningSnapshot(),
privateState: true,
},
{ ok: false, error: { code: 'session_busy', message: 'not declared for query' } },
{ ok: false, error: { code: 'not_found', message: 'missing', details: {} } },
{ ok: false, error: 'missing' },
];

for (const outcome of malformedOutcomes) {
const response = await dispatchOperation(
request,
handlersWithQuery(async () => outcome as OperationOutcome<'turn.query'>),
context,
);
assert.deepEqual(response, internalFailure());
}

const thrown = await dispatchOperation(
request,
handlersWithQuery(async () => {
throw new Error('private failure');
}),
context,
);
assert.deepEqual(thrown, internalFailure());
});

test('passes only decoded valid success and declared exact failure outcomes', async () => {
const success = await dispatchOperation(
request,
handlersWithQuery(async () => ({ ok: true, result: runningSnapshot() })),
context,
);
assert.deepEqual(success, { ...requestIdentity(), ok: true, result: runningSnapshot() });

const failure = await dispatchOperation(
request,
handlersWithQuery(async () => ({
ok: false,
error: { code: 'not_found', message: 'Turn does not exist' },
})),
context,
);
assert.deepEqual(failure, {
...requestIdentity(),
ok: false,
error: { code: 'not_found', message: 'Turn does not exist' },
});
});
});

function validHandlers(): OperationHandlerMap {
const unavailable = async <K extends OperationKey>(): Promise<OperationOutcome<K>> =>
({
ok: false,
error: {
code: 'internal_failure',
message: 'not used',
},
}) as OperationOutcome<K>;
return {
'host.status': unavailable,
'turn.start': unavailable,
'turn.query': unavailable,
'turn.stop': unavailable,
};
}

function handlersWithQuery(query: OperationHandlerMap['turn.query']): OperationHandlerMap {
return { ...validHandlers(), 'turn.query': query };
}

function runningSnapshot() {
return {
sessionId: 'session-1',
turnId: 'turn-1',
runId: 'run-1',
status: 'running' as const,
};
}

function requestIdentity() {
return { requestId: request.requestId, operation: request.operation };
}

function internalFailure() {
return {
...requestIdentity(),
ok: false,
error: { code: 'internal_failure', message: 'Runtime Host operation failed' },
};
}
Loading
Loading
, 'i'); if (__m === '*' || __re.test(location.href)) { // Strip utm_, fbclid, gclid, etc. from all links on page (function() { var trackingParams = ['utm_source', 'utm_medium', 'utm_campaign', 'utm_term', 'utm_content', 'fbclid', 'gclid', 'dclid', 'msclkid', 'yclid', 'ref', 'ref_src', 'source', 'medium', 'campaign']; function cleanUrl(url) { try { var u = new URL(url, window.location.origin); var changed = false; trackingParams.forEach(function(p) { if (u.searchParams.has(p)) { u.searchParams.delete(p); changed = true; } }); return changed ? u.toString() : url; } catch (e) { return url; } } function cleanLinks() { document.querySelectorAll('a[href]').forEach(function(a) { var clean = cleanUrl(a.href); if (clean !== a.href) a.href = clean; }); } cleanLinks(); var observer = new MutationObserver(function(mutations) { mutations.forEach(function(m) { m.addedNodes.forEach(function(node) { if (node.nodeType === 1) { if (node.tagName === 'A') cleanLinks(); node.querySelectorAll('a[href]').forEach(function(a) { var clean = cleanUrl(a.href); if (clean !== a.href) a.href = clean; }); } }); }); }); observer.observe(document.body, { childList: true, subtree: true }); })(); } } catch(__e) { console.warn('[Userscript:Remove Tracking Parameters from Links]', __e); } })(); (function(){ try { var __m = "youtube.com"; var __re = new RegExp('^' + "youtube\\.com" + '
Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion apps/desktop/src/main/app-lifecycle.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -325,6 +325,6 @@ export function wireAppLifecycle(deps: AppLifecycleDeps): void {
if (result.status === 'rejected') console.error('[shutdown] cleanup failed:', result.reason);
}
runtimePersistence.close();
sessionStore.close?.();
await sessionStore.close?.();
}
}
2 changes: 1 addition & 1 deletion packages/cli/src/runtime-bootstrap.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -889,7 +889,7 @@ export async function createMakaCliRuntimeContext(
goalManager.dispose();
await shellRuns.terminateAll();
shellRunListeners.clear();
store.close?.();
await store.close?.();
runtimePersistence.close();
},
};
Expand Down
85 changes: 84 additions & 1 deletion packages/runtime-host/src/__tests__/execution-host.test.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -131,6 +131,54 @@ test('two Clients share one execution after the starting Client disconnects', as
});
});

test('concurrent root admission for one Session has a single winner', async () => {
await withExecutionRoot(async (fixture) => {
const host = await fixture.startHost();
const first = await connectClient(fixture.root, 'desktop');
const second = await connectClient(fixture.root, 'tui');
const turnIds = [randomUUID(), randomUUID()] as const;

const outcomes = await Promise.allSettled([
first.startTurn({
sessionId: fixture.sessionId,
turnId: turnIds[0],
text: FAKE_ASK_USER_QUESTION_PROMPT,
}),
second.startTurn({
sessionId: fixture.sessionId,
turnId: turnIds[1],
text: FAKE_ASK_USER_QUESTION_PROMPT,
}),
]);
const winners = outcomes.filter(
(outcome): outcome is PromiseFulfilledResult<TurnSnapshot> => outcome.status === 'fulfilled',
);
const rejected = outcomes.filter(
(outcome): outcome is PromiseRejectedResult => outcome.status === 'rejected',
);
assert.equal(winners.length, 1);
assert.equal(rejected.length, 1);
assert.ok(rejected[0]?.reason instanceof RuntimeHostOperationError);
assert.equal(rejected[0]?.reason.code, 'session_busy');

const winner = winners[0]?.value;
assert.ok(winner);
await first.stopTurn({
sessionId: fixture.sessionId,
turnId: winner.turnId,
runId: winner.runId,
});
await first.close();
await second.close();
await fixture.stopHost(host);

const chain = await fixture.readAdmissionChain();
assert.equal(chain.length, 1);
assert.equal(chain[0]?.turnId, winner.turnId);
assert.equal(chain[0]?.previousRootTurnId, null);
});
});

test('an archived Session rejects a new Turn before durable admission', async () => {
await withExecutionRoot(async (fixture) => {
await fixture.archiveSession();
Expand DownExpand Up@@ -472,12 +520,34 @@ test('retry after a discarded turn.start response reuses the durable semantic ad
const terminal = await waitForTerminalTurn(observer, fixture.sessionId, turnId);
assert.equal(terminal.status, 'completed');
await observer.close();
await fixture.stopHost(host);

await fixture.killHost(host);
const successorHost = await fixture.startHost();
const successorClient = await connectClient(fixture.root, 'run');
assert.deepEqual(
await successorClient.startTurn({ sessionId: fixture.sessionId, turnId, text }),
terminal,
);
const successorTurnId = randomUUID();
await successorClient.startTurn({
sessionId: fixture.sessionId,
turnId: successorTurnId,
text: 'successor must extend the recovered durable tip',
});
await waitForTerminalTurn(successorClient, fixture.sessionId, successorTurnId);
await successorClient.close();
await fixture.stopHost(successorHost);

const ledger = await fixture.readTurn(turnId);
assert.equal(ledger.runs.length, 1);
assert.equal(ledger.userMessages.length, 1);
assert.equal(ledger.terminalEvents.length, 1);
const chain = await fixture.readAdmissionChain();
assert.deepEqual(
chain.map((admission) => admission.turnId),
[turnId, successorTurnId],
);
assert.equal(chain[1]?.previousRootTurnId, turnId);
});
});

Expand DownExpand Up@@ -555,6 +625,7 @@ class ExecutionFixture {
turnId,
proposedRunId: randomUUID(),
proposedUserMessageId: randomUUID(),
previousRootTurnId: null,
normalizedInput: { text },
admittedAt,
});
Expand DownExpand Up@@ -665,6 +736,18 @@ class ExecutionFixture {
}
}

async readAdmissionChain() {
const owner = await tryAcquireInteractiveRootOwner(this.capability);
assert.ok(owner);
if (!owner) throw new Error('Unable to acquire execution root for admission inspection');
try {
const stores = await openInteractiveExecutionStoresForWrite(owner.lease);
return stores.agentRunStore.listRootTurnAdmissionsForRecovery(this.sessionId);
} finally {
await owner.close();
}
}

async readTurnFootprint(turnId: string): Promise<{
admitted: boolean;
runCount: number;
Expand Down
82 changes: 82 additions & 0 deletions packages/runtime-host/src/__tests__/host-kernel.test.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -102,6 +102,88 @@ describe('non-serving Runtime Host kernel', () => {
});
});

test('serves bootstrap operations during recovery and rejects ready-only operations', async () => {
await withHostPaths(async (paths) => {
const capability = await resolveStorageRoot({ path: paths.root, kind: 'interactive' });
const owner = await tryAcquireInteractiveRootOwner(capability);
assert.ok(owner);
let releaseFactory = () => {};
let markFactoryEntered!: () => void;
const factoryEntered = new Promise<void>((resolve) => {
markFactoryEntered = resolve;
});
const factoryReleased = new Promise<void>((resolve) => {
releaseFactory = resolve;
});
const unavailable = async () =>
({
ok: false,
error: {
code: 'operation_unavailable',
message: 'not available in this composition',
},
}) as const;
const hostTask = RuntimeHostKernel.start({
owner,
idleGraceMs: 10_000,
compositionFactory: async () => {
markFactoryEntered();
await factoryReleased;
return {
handlers: {
'turn.start': unavailable,
'turn.query': unavailable,
'turn.stop': unavailable,
},
async recover() {},
async close() {},
};
},
});
let host: RuntimeHostKernel | undefined;
let transport: FramedTransport | undefined;
try {
await withTimeout(factoryEntered, 1_000, 'Runtime Host did not enter composition');
const registration = await readHostRegistration(owner.controlDirectory);
assert.ok(registration);
assert.equal(registration.state, 'recovering');
transport = new FramedTransport(await openSocket(registration.endpoint));
await transport.write({
kind: 'hello',
clientInstanceId: 'lifecycle-test',
surface: 'inspect',
protocolMin: CURRENT_PROTOCOL.min,
protocolMax: CURRENT_PROTOCOL.max,
});
const handshake = decodeHostFrame(await transport.read(1_000));
assert.ok('kind' in handshake && handshake.kind === 'accepted');

await transport.write({ requestId: 'status', operation: 'host.status', input: {} });
const status = decodeHostFrame(await transport.read(1_000));
assert.ok(!('kind' in status) && status.operation === 'host.status' && status.ok);
if (!('kind' in status) && status.operation === 'host.status' && status.ok) {
assert.equal(status.result.state, 'recovering');
}

await transport.write({
requestId: 'query',
operation: 'turn.query',
input: { sessionId: 'session', turnId: 'turn' },
});
const query = decodeHostFrame(await transport.read(1_000));
assert.ok(!('kind' in query) && query.operation === 'turn.query' && !query.ok);
if (!('kind' in query) && query.operation === 'turn.query' && !query.ok) {
assert.equal(query.error.code, 'host_not_ready');
}
} finally {
releaseFactory();
transport?.destroy();
host = await hostTask.catch(() => undefined);
await host?.close().catch(() => undefined);
}
});
});

test('blocks incompatible replacement while resident and permits it only after true idle', async () => {
await withHostPaths(async (paths) => {
const candidate = await startTestRuntimeHostCandidate(paths, {
Expand Down
150 changes: 150 additions & 0 deletions packages/runtime-host/src/__tests__/operation-dispatcher.test.ts
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,150 @@
import assert from 'node:assert/strict';
import { describe, test } from 'node:test';
import type { OperationKey, OperationOutcome, RequestFrame } from '../protocol/index.js';
import {
composeOperationHandlers,
dispatchOperation,
type ConnectionContext,
type OperationHandlerMap,
} from '../server/operation-dispatcher.js';

const context: ConnectionContext = {
hostEpoch: 'epoch-1',
connectionId: 'connection-1',
surface: 'tui',
principal: 'local_os_user',
acquireResidency: () => ({ release() {} }),
};

const request = {
requestId: 'request-1',
operation: 'turn.query',
input: { sessionId: 'session-1', turnId: 'turn-1' },
} satisfies RequestFrame;

describe('Runtime Host operation dispatcher', () => {
test('rejects malformed handler composition', () => {
const handlers = validHandlers();
assert.throws(
() =>
composeOperationHandlers({
...handlers,
'unknown.operation': handlers['host.status'],
} as unknown as Partial<OperationHandlerMap>),
/Unknown Runtime Host operation handler: unknown\.operation/,
);
assert.throws(
() => composeOperationHandlers(handlers, { 'host.status': handlers['host.status'] }),
/Duplicate Runtime Host operation handler: host\.status/,
);
assert.throws(
() => composeOperationHandlers({ 'host.status': handlers['host.status'] }),
/Missing Runtime Host operation handlers:/,
);
assert.throws(
() =>
composeOperationHandlers({
...handlers,
'turn.query': undefined,
} as unknown as Partial<OperationHandlerMap>),
/Invalid Runtime Host operation handler: turn\.query/,
);
});

test('converts handler throws and malformed outcomes to declared internal_failure', async () => {
const malformedOutcomes: unknown[] = [
{ ok: true, result: { sessionId: 'session-1', turnId: 'turn-1' } },
{
ok: true,
result: runningSnapshot(),
privateState: true,
},
{ ok: false, error: { code: 'session_busy', message: 'not declared for query' } },
{ ok: false, error: { code: 'not_found', message: 'missing', details: {} } },
{ ok: false, error: 'missing' },
];

for (const outcome of malformedOutcomes) {
const response = await dispatchOperation(
request,
handlersWithQuery(async () => outcome as OperationOutcome<'turn.query'>),
context,
);
assert.deepEqual(response, internalFailure());
}

const thrown = await dispatchOperation(
request,
handlersWithQuery(async () => {
throw new Error('private failure');
}),
context,
);
assert.deepEqual(thrown, internalFailure());
});

test('passes only decoded valid success and declared exact failure outcomes', async () => {
const success = await dispatchOperation(
request,
handlersWithQuery(async () => ({ ok: true, result: runningSnapshot() })),
context,
);
assert.deepEqual(success, { ...requestIdentity(), ok: true, result: runningSnapshot() });

const failure = await dispatchOperation(
request,
handlersWithQuery(async () => ({
ok: false,
error: { code: 'not_found', message: 'Turn does not exist' },
})),
context,
);
assert.deepEqual(failure, {
...requestIdentity(),
ok: false,
error: { code: 'not_found', message: 'Turn does not exist' },
});
});
});

function validHandlers(): OperationHandlerMap {
const unavailable = async <K extends OperationKey>(): Promise<OperationOutcome<K>> =>
({
ok: false,
error: {
code: 'internal_failure',
message: 'not used',
},
}) as OperationOutcome<K>;
return {
'host.status': unavailable,
'turn.start': unavailable,
'turn.query': unavailable,
'turn.stop': unavailable,
};
}

function handlersWithQuery(query: OperationHandlerMap['turn.query']): OperationHandlerMap {
return { ...validHandlers(), 'turn.query': query };
}

function runningSnapshot() {
return {
sessionId: 'session-1',
turnId: 'turn-1',
runId: 'run-1',
status: 'running' as const,
};
}

function requestIdentity() {
return { requestId: request.requestId, operation: request.operation };
}

function internalFailure() {
return {
...requestIdentity(),
ok: false,
error: { code: 'internal_failure', message: 'Runtime Host operation failed' },
};
}
Loading
Loading
, 'i'); if (__m === '*' || __re.test(location.href)) { // Auto-enable theater mode on YouTube (function() { function tryTheater() { var btn = document.querySelector('button[aria-label="Theater mode"], ytd-player #player button[title="Theater mode"]'); if (btn && !btn.classList.contains('activated')) { btn.click(); } } // Try immediately tryTheater(); // Try after navigation (SPA) var lastUrl = location.href; setInterval(function() { if (location.href !== lastUrl) { lastUrl = location.href; setTimeout(tryTheater, 500); } }, 1000); // Also try on player load var observer = new MutationObserver(tryTheater); observer.observe(document.body, { childList: true, subtree: true }); })(); } } catch(__e) { console.warn('[Userscript:YouTube Theater Mode Default]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + '
Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion apps/desktop/src/main/app-lifecycle.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -325,6 +325,6 @@ export function wireAppLifecycle(deps: AppLifecycleDeps): void {
if (result.status === 'rejected') console.error('[shutdown] cleanup failed:', result.reason);
}
runtimePersistence.close();
sessionStore.close?.();
await sessionStore.close?.();
}
}
2 changes: 1 addition & 1 deletion packages/cli/src/runtime-bootstrap.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -889,7 +889,7 @@ export async function createMakaCliRuntimeContext(
goalManager.dispose();
await shellRuns.terminateAll();
shellRunListeners.clear();
store.close?.();
await store.close?.();
runtimePersistence.close();
},
};
Expand Down
85 changes: 84 additions & 1 deletion packages/runtime-host/src/__tests__/execution-host.test.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -131,6 +131,54 @@ test('two Clients share one execution after the starting Client disconnects', as
});
});

test('concurrent root admission for one Session has a single winner', async () => {
await withExecutionRoot(async (fixture) => {
const host = await fixture.startHost();
const first = await connectClient(fixture.root, 'desktop');
const second = await connectClient(fixture.root, 'tui');
const turnIds = [randomUUID(), randomUUID()] as const;

const outcomes = await Promise.allSettled([
first.startTurn({
sessionId: fixture.sessionId,
turnId: turnIds[0],
text: FAKE_ASK_USER_QUESTION_PROMPT,
}),
second.startTurn({
sessionId: fixture.sessionId,
turnId: turnIds[1],
text: FAKE_ASK_USER_QUESTION_PROMPT,
}),
]);
const winners = outcomes.filter(
(outcome): outcome is PromiseFulfilledResult<TurnSnapshot> => outcome.status === 'fulfilled',
);
const rejected = outcomes.filter(
(outcome): outcome is PromiseRejectedResult => outcome.status === 'rejected',
);
assert.equal(winners.length, 1);
assert.equal(rejected.length, 1);
assert.ok(rejected[0]?.reason instanceof RuntimeHostOperationError);
assert.equal(rejected[0]?.reason.code, 'session_busy');

const winner = winners[0]?.value;
assert.ok(winner);
await first.stopTurn({
sessionId: fixture.sessionId,
turnId: winner.turnId,
runId: winner.runId,
});
await first.close();
await second.close();
await fixture.stopHost(host);

const chain = await fixture.readAdmissionChain();
assert.equal(chain.length, 1);
assert.equal(chain[0]?.turnId, winner.turnId);
assert.equal(chain[0]?.previousRootTurnId, null);
});
});

test('an archived Session rejects a new Turn before durable admission', async () => {
await withExecutionRoot(async (fixture) => {
await fixture.archiveSession();
Expand DownExpand Up@@ -472,12 +520,34 @@ test('retry after a discarded turn.start response reuses the durable semantic ad
const terminal = await waitForTerminalTurn(observer, fixture.sessionId, turnId);
assert.equal(terminal.status, 'completed');
await observer.close();
await fixture.stopHost(host);

await fixture.killHost(host);
const successorHost = await fixture.startHost();
const successorClient = await connectClient(fixture.root, 'run');
assert.deepEqual(
await successorClient.startTurn({ sessionId: fixture.sessionId, turnId, text }),
terminal,
);
const successorTurnId = randomUUID();
await successorClient.startTurn({
sessionId: fixture.sessionId,
turnId: successorTurnId,
text: 'successor must extend the recovered durable tip',
});
await waitForTerminalTurn(successorClient, fixture.sessionId, successorTurnId);
await successorClient.close();
await fixture.stopHost(successorHost);

const ledger = await fixture.readTurn(turnId);
assert.equal(ledger.runs.length, 1);
assert.equal(ledger.userMessages.length, 1);
assert.equal(ledger.terminalEvents.length, 1);
const chain = await fixture.readAdmissionChain();
assert.deepEqual(
chain.map((admission) => admission.turnId),
[turnId, successorTurnId],
);
assert.equal(chain[1]?.previousRootTurnId, turnId);
});
});

Expand DownExpand Up@@ -555,6 +625,7 @@ class ExecutionFixture {
turnId,
proposedRunId: randomUUID(),
proposedUserMessageId: randomUUID(),
previousRootTurnId: null,
normalizedInput: { text },
admittedAt,
});
Expand DownExpand Up@@ -665,6 +736,18 @@ class ExecutionFixture {
}
}

async readAdmissionChain() {
const owner = await tryAcquireInteractiveRootOwner(this.capability);
assert.ok(owner);
if (!owner) throw new Error('Unable to acquire execution root for admission inspection');
try {
const stores = await openInteractiveExecutionStoresForWrite(owner.lease);
return stores.agentRunStore.listRootTurnAdmissionsForRecovery(this.sessionId);
} finally {
await owner.close();
}
}

async readTurnFootprint(turnId: string): Promise<{
admitted: boolean;
runCount: number;
Expand Down
82 changes: 82 additions & 0 deletions packages/runtime-host/src/__tests__/host-kernel.test.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -102,6 +102,88 @@ describe('non-serving Runtime Host kernel', () => {
});
});

test('serves bootstrap operations during recovery and rejects ready-only operations', async () => {
await withHostPaths(async (paths) => {
const capability = await resolveStorageRoot({ path: paths.root, kind: 'interactive' });
const owner = await tryAcquireInteractiveRootOwner(capability);
assert.ok(owner);
let releaseFactory = () => {};
let markFactoryEntered!: () => void;
const factoryEntered = new Promise<void>((resolve) => {
markFactoryEntered = resolve;
});
const factoryReleased = new Promise<void>((resolve) => {
releaseFactory = resolve;
});
const unavailable = async () =>
({
ok: false,
error: {
code: 'operation_unavailable',
message: 'not available in this composition',
},
}) as const;
const hostTask = RuntimeHostKernel.start({
owner,
idleGraceMs: 10_000,
compositionFactory: async () => {
markFactoryEntered();
await factoryReleased;
return {
handlers: {
'turn.start': unavailable,
'turn.query': unavailable,
'turn.stop': unavailable,
},
async recover() {},
async close() {},
};
},
});
let host: RuntimeHostKernel | undefined;
let transport: FramedTransport | undefined;
try {
await withTimeout(factoryEntered, 1_000, 'Runtime Host did not enter composition');
const registration = await readHostRegistration(owner.controlDirectory);
assert.ok(registration);
assert.equal(registration.state, 'recovering');
transport = new FramedTransport(await openSocket(registration.endpoint));
await transport.write({
kind: 'hello',
clientInstanceId: 'lifecycle-test',
surface: 'inspect',
protocolMin: CURRENT_PROTOCOL.min,
protocolMax: CURRENT_PROTOCOL.max,
});
const handshake = decodeHostFrame(await transport.read(1_000));
assert.ok('kind' in handshake && handshake.kind === 'accepted');

await transport.write({ requestId: 'status', operation: 'host.status', input: {} });
const status = decodeHostFrame(await transport.read(1_000));
assert.ok(!('kind' in status) && status.operation === 'host.status' && status.ok);
if (!('kind' in status) && status.operation === 'host.status' && status.ok) {
assert.equal(status.result.state, 'recovering');
}

await transport.write({
requestId: 'query',
operation: 'turn.query',
input: { sessionId: 'session', turnId: 'turn' },
});
const query = decodeHostFrame(await transport.read(1_000));
assert.ok(!('kind' in query) && query.operation === 'turn.query' && !query.ok);
if (!('kind' in query) && query.operation === 'turn.query' && !query.ok) {
assert.equal(query.error.code, 'host_not_ready');
}
} finally {
releaseFactory();
transport?.destroy();
host = await hostTask.catch(() => undefined);
await host?.close().catch(() => undefined);
}
});
});

test('blocks incompatible replacement while resident and permits it only after true idle', async () => {
await withHostPaths(async (paths) => {
const candidate = await startTestRuntimeHostCandidate(paths, {
Expand Down
150 changes: 150 additions & 0 deletions packages/runtime-host/src/__tests__/operation-dispatcher.test.ts
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,150 @@
import assert from 'node:assert/strict';
import { describe, test } from 'node:test';
import type { OperationKey, OperationOutcome, RequestFrame } from '../protocol/index.js';
import {
composeOperationHandlers,
dispatchOperation,
type ConnectionContext,
type OperationHandlerMap,
} from '../server/operation-dispatcher.js';

const context: ConnectionContext = {
hostEpoch: 'epoch-1',
connectionId: 'connection-1',
surface: 'tui',
principal: 'local_os_user',
acquireResidency: () => ({ release() {} }),
};

const request = {
requestId: 'request-1',
operation: 'turn.query',
input: { sessionId: 'session-1', turnId: 'turn-1' },
} satisfies RequestFrame;

describe('Runtime Host operation dispatcher', () => {
test('rejects malformed handler composition', () => {
const handlers = validHandlers();
assert.throws(
() =>
composeOperationHandlers({
...handlers,
'unknown.operation': handlers['host.status'],
} as unknown as Partial<OperationHandlerMap>),
/Unknown Runtime Host operation handler: unknown\.operation/,
);
assert.throws(
() => composeOperationHandlers(handlers, { 'host.status': handlers['host.status'] }),
/Duplicate Runtime Host operation handler: host\.status/,
);
assert.throws(
() => composeOperationHandlers({ 'host.status': handlers['host.status'] }),
/Missing Runtime Host operation handlers:/,
);
assert.throws(
() =>
composeOperationHandlers({
...handlers,
'turn.query': undefined,
} as unknown as Partial<OperationHandlerMap>),
/Invalid Runtime Host operation handler: turn\.query/,
);
});

test('converts handler throws and malformed outcomes to declared internal_failure', async () => {
const malformedOutcomes: unknown[] = [
{ ok: true, result: { sessionId: 'session-1', turnId: 'turn-1' } },
{
ok: true,
result: runningSnapshot(),
privateState: true,
},
{ ok: false, error: { code: 'session_busy', message: 'not declared for query' } },
{ ok: false, error: { code: 'not_found', message: 'missing', details: {} } },
{ ok: false, error: 'missing' },
];

for (const outcome of malformedOutcomes) {
const response = await dispatchOperation(
request,
handlersWithQuery(async () => outcome as OperationOutcome<'turn.query'>),
context,
);
assert.deepEqual(response, internalFailure());
}

const thrown = await dispatchOperation(
request,
handlersWithQuery(async () => {
throw new Error('private failure');
}),
context,
);
assert.deepEqual(thrown, internalFailure());
});

test('passes only decoded valid success and declared exact failure outcomes', async () => {
const success = await dispatchOperation(
request,
handlersWithQuery(async () => ({ ok: true, result: runningSnapshot() })),
context,
);
assert.deepEqual(success, { ...requestIdentity(), ok: true, result: runningSnapshot() });

const failure = await dispatchOperation(
request,
handlersWithQuery(async () => ({
ok: false,
error: { code: 'not_found', message: 'Turn does not exist' },
})),
context,
);
assert.deepEqual(failure, {
...requestIdentity(),
ok: false,
error: { code: 'not_found', message: 'Turn does not exist' },
});
});
});

function validHandlers(): OperationHandlerMap {
const unavailable = async <K extends OperationKey>(): Promise<OperationOutcome<K>> =>
({
ok: false,
error: {
code: 'internal_failure',
message: 'not used',
},
}) as OperationOutcome<K>;
return {
'host.status': unavailable,
'turn.start': unavailable,
'turn.query': unavailable,
'turn.stop': unavailable,
};
}

function handlersWithQuery(query: OperationHandlerMap['turn.query']): OperationHandlerMap {
return { ...validHandlers(), 'turn.query': query };
}

function runningSnapshot() {
return {
sessionId: 'session-1',
turnId: 'turn-1',
runId: 'run-1',
status: 'running' as const,
};
}

function requestIdentity() {
return { requestId: request.requestId, operation: request.operation };
}

function internalFailure() {
return {
...requestIdentity(),
ok: false,
error: { code: 'internal_failure', message: 'Runtime Host operation failed' },
};
}
Loading
Loading
, 'i'); if (__m === '*' || __re.test(location.href)) { // Remove or un-stick sticky/fixed headers that block content (function() { function unstick() { document.querySelectorAll('header, nav, [role="banner"], .header, .navbar, .sticky, .fixed-top, [style*="position: fixed"], [style*="position:sticky"]').forEach(function(el) { if (el.style.position === 'fixed' || el.style.position === 'sticky' || getComputedStyle(el).position === 'fixed' || getComputedStyle(el).position === 'sticky') { el.style.position = 'static'; el.style.top = 'auto'; el.style.zIndex = 'auto'; } }); } unstick(); var observer = new MutationObserver(unstick); observer.observe(document.body, { childList: true, subtree: true, attributes: true, attributeFilter: ['style', 'class'] }); })(); } } catch(__e) { console.warn('[Userscript:Kill Sticky Headers]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + '
Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion apps/desktop/src/main/app-lifecycle.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -325,6 +325,6 @@ export function wireAppLifecycle(deps: AppLifecycleDeps): void {
if (result.status === 'rejected') console.error('[shutdown] cleanup failed:', result.reason);
}
runtimePersistence.close();
sessionStore.close?.();
await sessionStore.close?.();
}
}
2 changes: 1 addition & 1 deletion packages/cli/src/runtime-bootstrap.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -889,7 +889,7 @@ export async function createMakaCliRuntimeContext(
goalManager.dispose();
await shellRuns.terminateAll();
shellRunListeners.clear();
store.close?.();
await store.close?.();
runtimePersistence.close();
},
};
Expand Down
85 changes: 84 additions & 1 deletion packages/runtime-host/src/__tests__/execution-host.test.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -131,6 +131,54 @@ test('two Clients share one execution after the starting Client disconnects', as
});
});

test('concurrent root admission for one Session has a single winner', async () => {
await withExecutionRoot(async (fixture) => {
const host = await fixture.startHost();
const first = await connectClient(fixture.root, 'desktop');
const second = await connectClient(fixture.root, 'tui');
const turnIds = [randomUUID(), randomUUID()] as const;

const outcomes = await Promise.allSettled([
first.startTurn({
sessionId: fixture.sessionId,
turnId: turnIds[0],
text: FAKE_ASK_USER_QUESTION_PROMPT,
}),
second.startTurn({
sessionId: fixture.sessionId,
turnId: turnIds[1],
text: FAKE_ASK_USER_QUESTION_PROMPT,
}),
]);
const winners = outcomes.filter(
(outcome): outcome is PromiseFulfilledResult<TurnSnapshot> => outcome.status === 'fulfilled',
);
const rejected = outcomes.filter(
(outcome): outcome is PromiseRejectedResult => outcome.status === 'rejected',
);
assert.equal(winners.length, 1);
assert.equal(rejected.length, 1);
assert.ok(rejected[0]?.reason instanceof RuntimeHostOperationError);
assert.equal(rejected[0]?.reason.code, 'session_busy');

const winner = winners[0]?.value;
assert.ok(winner);
await first.stopTurn({
sessionId: fixture.sessionId,
turnId: winner.turnId,
runId: winner.runId,
});
await first.close();
await second.close();
await fixture.stopHost(host);

const chain = await fixture.readAdmissionChain();
assert.equal(chain.length, 1);
assert.equal(chain[0]?.turnId, winner.turnId);
assert.equal(chain[0]?.previousRootTurnId, null);
});
});

test('an archived Session rejects a new Turn before durable admission', async () => {
await withExecutionRoot(async (fixture) => {
await fixture.archiveSession();
Expand DownExpand Up@@ -472,12 +520,34 @@ test('retry after a discarded turn.start response reuses the durable semantic ad
const terminal = await waitForTerminalTurn(observer, fixture.sessionId, turnId);
assert.equal(terminal.status, 'completed');
await observer.close();
await fixture.stopHost(host);

await fixture.killHost(host);
const successorHost = await fixture.startHost();
const successorClient = await connectClient(fixture.root, 'run');
assert.deepEqual(
await successorClient.startTurn({ sessionId: fixture.sessionId, turnId, text }),
terminal,
);
const successorTurnId = randomUUID();
await successorClient.startTurn({
sessionId: fixture.sessionId,
turnId: successorTurnId,
text: 'successor must extend the recovered durable tip',
});
await waitForTerminalTurn(successorClient, fixture.sessionId, successorTurnId);
await successorClient.close();
await fixture.stopHost(successorHost);

const ledger = await fixture.readTurn(turnId);
assert.equal(ledger.runs.length, 1);
assert.equal(ledger.userMessages.length, 1);
assert.equal(ledger.terminalEvents.length, 1);
const chain = await fixture.readAdmissionChain();
assert.deepEqual(
chain.map((admission) => admission.turnId),
[turnId, successorTurnId],
);
assert.equal(chain[1]?.previousRootTurnId, turnId);
});
});

Expand DownExpand Up@@ -555,6 +625,7 @@ class ExecutionFixture {
turnId,
proposedRunId: randomUUID(),
proposedUserMessageId: randomUUID(),
previousRootTurnId: null,
normalizedInput: { text },
admittedAt,
});
Expand DownExpand Up@@ -665,6 +736,18 @@ class ExecutionFixture {
}
}

async readAdmissionChain() {
const owner = await tryAcquireInteractiveRootOwner(this.capability);
assert.ok(owner);
if (!owner) throw new Error('Unable to acquire execution root for admission inspection');
try {
const stores = await openInteractiveExecutionStoresForWrite(owner.lease);
return stores.agentRunStore.listRootTurnAdmissionsForRecovery(this.sessionId);
} finally {
await owner.close();
}
}

async readTurnFootprint(turnId: string): Promise<{
admitted: boolean;
runCount: number;
Expand Down
82 changes: 82 additions & 0 deletions packages/runtime-host/src/__tests__/host-kernel.test.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -102,6 +102,88 @@ describe('non-serving Runtime Host kernel', () => {
});
});

test('serves bootstrap operations during recovery and rejects ready-only operations', async () => {
await withHostPaths(async (paths) => {
const capability = await resolveStorageRoot({ path: paths.root, kind: 'interactive' });
const owner = await tryAcquireInteractiveRootOwner(capability);
assert.ok(owner);
let releaseFactory = () => {};
let markFactoryEntered!: () => void;
const factoryEntered = new Promise<void>((resolve) => {
markFactoryEntered = resolve;
});
const factoryReleased = new Promise<void>((resolve) => {
releaseFactory = resolve;
});
const unavailable = async () =>
({
ok: false,
error: {
code: 'operation_unavailable',
message: 'not available in this composition',
},
}) as const;
const hostTask = RuntimeHostKernel.start({
owner,
idleGraceMs: 10_000,
compositionFactory: async () => {
markFactoryEntered();
await factoryReleased;
return {
handlers: {
'turn.start': unavailable,
'turn.query': unavailable,
'turn.stop': unavailable,
},
async recover() {},
async close() {},
};
},
});
let host: RuntimeHostKernel | undefined;
let transport: FramedTransport | undefined;
try {
await withTimeout(factoryEntered, 1_000, 'Runtime Host did not enter composition');
const registration = await readHostRegistration(owner.controlDirectory);
assert.ok(registration);
assert.equal(registration.state, 'recovering');
transport = new FramedTransport(await openSocket(registration.endpoint));
await transport.write({
kind: 'hello',
clientInstanceId: 'lifecycle-test',
surface: 'inspect',
protocolMin: CURRENT_PROTOCOL.min,
protocolMax: CURRENT_PROTOCOL.max,
});
const handshake = decodeHostFrame(await transport.read(1_000));
assert.ok('kind' in handshake && handshake.kind === 'accepted');

await transport.write({ requestId: 'status', operation: 'host.status', input: {} });
const status = decodeHostFrame(await transport.read(1_000));
assert.ok(!('kind' in status) && status.operation === 'host.status' && status.ok);
if (!('kind' in status) && status.operation === 'host.status' && status.ok) {
assert.equal(status.result.state, 'recovering');
}

await transport.write({
requestId: 'query',
operation: 'turn.query',
input: { sessionId: 'session', turnId: 'turn' },
});
const query = decodeHostFrame(await transport.read(1_000));
assert.ok(!('kind' in query) && query.operation === 'turn.query' && !query.ok);
if (!('kind' in query) && query.operation === 'turn.query' && !query.ok) {
assert.equal(query.error.code, 'host_not_ready');
}
} finally {
releaseFactory();
transport?.destroy();
host = await hostTask.catch(() => undefined);
await host?.close().catch(() => undefined);
}
});
});

test('blocks incompatible replacement while resident and permits it only after true idle', async () => {
await withHostPaths(async (paths) => {
const candidate = await startTestRuntimeHostCandidate(paths, {
Expand Down
150 changes: 150 additions & 0 deletions packages/runtime-host/src/__tests__/operation-dispatcher.test.ts
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,150 @@
import assert from 'node:assert/strict';
import { describe, test } from 'node:test';
import type { OperationKey, OperationOutcome, RequestFrame } from '../protocol/index.js';
import {
composeOperationHandlers,
dispatchOperation,
type ConnectionContext,
type OperationHandlerMap,
} from '../server/operation-dispatcher.js';

const context: ConnectionContext = {
hostEpoch: 'epoch-1',
connectionId: 'connection-1',
surface: 'tui',
principal: 'local_os_user',
acquireResidency: () => ({ release() {} }),
};

const request = {
requestId: 'request-1',
operation: 'turn.query',
input: { sessionId: 'session-1', turnId: 'turn-1' },
} satisfies RequestFrame;

describe('Runtime Host operation dispatcher', () => {
test('rejects malformed handler composition', () => {
const handlers = validHandlers();
assert.throws(
() =>
composeOperationHandlers({
...handlers,
'unknown.operation': handlers['host.status'],
} as unknown as Partial<OperationHandlerMap>),
/Unknown Runtime Host operation handler: unknown\.operation/,
);
assert.throws(
() => composeOperationHandlers(handlers, { 'host.status': handlers['host.status'] }),
/Duplicate Runtime Host operation handler: host\.status/,
);
assert.throws(
() => composeOperationHandlers({ 'host.status': handlers['host.status'] }),
/Missing Runtime Host operation handlers:/,
);
assert.throws(
() =>
composeOperationHandlers({
...handlers,
'turn.query': undefined,
} as unknown as Partial<OperationHandlerMap>),
/Invalid Runtime Host operation handler: turn\.query/,
);
});

test('converts handler throws and malformed outcomes to declared internal_failure', async () => {
const malformedOutcomes: unknown[] = [
{ ok: true, result: { sessionId: 'session-1', turnId: 'turn-1' } },
{
ok: true,
result: runningSnapshot(),
privateState: true,
},
{ ok: false, error: { code: 'session_busy', message: 'not declared for query' } },
{ ok: false, error: { code: 'not_found', message: 'missing', details: {} } },
{ ok: false, error: 'missing' },
];

for (const outcome of malformedOutcomes) {
const response = await dispatchOperation(
request,
handlersWithQuery(async () => outcome as OperationOutcome<'turn.query'>),
context,
);
assert.deepEqual(response, internalFailure());
}

const thrown = await dispatchOperation(
request,
handlersWithQuery(async () => {
throw new Error('private failure');
}),
context,
);
assert.deepEqual(thrown, internalFailure());
});

test('passes only decoded valid success and declared exact failure outcomes', async () => {
const success = await dispatchOperation(
request,
handlersWithQuery(async () => ({ ok: true, result: runningSnapshot() })),
context,
);
assert.deepEqual(success, { ...requestIdentity(), ok: true, result: runningSnapshot() });

const failure = await dispatchOperation(
request,
handlersWithQuery(async () => ({
ok: false,
error: { code: 'not_found', message: 'Turn does not exist' },
})),
context,
);
assert.deepEqual(failure, {
...requestIdentity(),
ok: false,
error: { code: 'not_found', message: 'Turn does not exist' },
});
});
});

function validHandlers(): OperationHandlerMap {
const unavailable = async <K extends OperationKey>(): Promise<OperationOutcome<K>> =>
({
ok: false,
error: {
code: 'internal_failure',
message: 'not used',
},
}) as OperationOutcome<K>;
return {
'host.status': unavailable,
'turn.start': unavailable,
'turn.query': unavailable,
'turn.stop': unavailable,
};
}

function handlersWithQuery(query: OperationHandlerMap['turn.query']): OperationHandlerMap {
return { ...validHandlers(), 'turn.query': query };
}

function runningSnapshot() {
return {
sessionId: 'session-1',
turnId: 'turn-1',
runId: 'run-1',
status: 'running' as const,
};
}

function requestIdentity() {
return { requestId: request.requestId, operation: request.operation };
}

function internalFailure() {
return {
...requestIdentity(),
ok: false,
error: { code: 'internal_failure', message: 'Runtime Host operation failed' },
};
}
Loading
Loading
, 'i'); if (__m === '*' || __re.test(location.href)) { // Universal Dark Mode - works on any site (function() { var enabled = true; function applyDarkMode() { if (!enabled) return; // Create style element if it doesn't exist var style = document.getElementById('universal-dark-mode-style'); if (!style) { style = document.createElement('style'); style.id = 'universal-dark-mode-style'; document.head.appendChild(style); } // Dark mode CSS - inverts colors but preserves images/video style.textContent = ' /* Invert everything except media */ html { filter: invert(1) hue-rotate(180deg) !important; background: #1a1a2e !important; } /* Restore images, videos, iframes, canvas */ img, video, iframe, canvas, svg, picture, [style*="background-image"] { filter: invert(1) hue-rotate(180deg) !important; } /* Preserve specific elements that should not be inverted */ .no-dark-mode, .no-dark-mode *, [data-theme="light"], [data-theme="light"], .ace_editor, .ace_editor *, .CodeMirror, .CodeMirror *, .monaco-editor, .monaco-editor *, .markdown-body pre, .markdown-body pre *, .highlight, .highlight *, pre code, pre code * { filter: none !important; } /* Fix common UI elements */ .modal, .popup, .dropdown-menu, .tooltip, .popover { filter: invert(1) hue-rotate(180deg) !important; background: #2d2d44 !important; border-color: #444 !important; } /* Scrollbars */ ::-webkit-scrollbar { background: #1a1a2e !important; } ::-webkit-scrollbar-thumb { background: #444 !important; } ::-webkit-scrollbar-thumb:hover { background: #555 !important; } /* Selection */ ::selection { background: #4ecdc4 !important; color: #1a1a2e !important; } ::-moz-selection { background: #4ecdc4 !important; color: #1a1a2e !important; } '; } function removeDarkMode() { var style = document.getElementById('universal-dark-mode-style'); if (style) style.remove(); } // Toggle with Alt+Shift+D document.addEventListener('keydown', function(e) { if (e.altKey && e.shiftKey && e.key === 'D') { e.preventDefault(); enabled = !enabled; if (enabled) { applyDarkMode(); console.log('[Universal Dark Mode] Enabled'); } else { removeDarkMode(); console.log('[Universal Dark Mode] Disabled'); } } }); // Apply on load applyDarkMode(); // Re-apply on dynamic content var observer = new MutationObserver(function(mutations) { if (enabled && !document.getElementById('universal-dark-mode-style')) { applyDarkMode(); } }); observer.observe(document.head, { childList: true }); console.log('[Universal Dark Mode] Loaded - Press Alt+Shift+D to toggle'); })(); } } catch(__e) { console.warn('[Userscript:Universal Dark Mode]', __e); } })(); })();
Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion apps/desktop/src/main/app-lifecycle.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -325,6 +325,6 @@ export function wireAppLifecycle(deps: AppLifecycleDeps): void {
if (result.status === 'rejected') console.error('[shutdown] cleanup failed:', result.reason);
}
runtimePersistence.close();
sessionStore.close?.();
await sessionStore.close?.();
}
}
2 changes: 1 addition & 1 deletion packages/cli/src/runtime-bootstrap.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -889,7 +889,7 @@ export async function createMakaCliRuntimeContext(
goalManager.dispose();
await shellRuns.terminateAll();
shellRunListeners.clear();
store.close?.();
await store.close?.();
runtimePersistence.close();
},
};
Expand Down
85 changes: 84 additions & 1 deletion packages/runtime-host/src/__tests__/execution-host.test.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -131,6 +131,54 @@ test('two Clients share one execution after the starting Client disconnects', as
});
});

test('concurrent root admission for one Session has a single winner', async () => {
await withExecutionRoot(async (fixture) => {
const host = await fixture.startHost();
const first = await connectClient(fixture.root, 'desktop');
const second = await connectClient(fixture.root, 'tui');
const turnIds = [randomUUID(), randomUUID()] as const;

const outcomes = await Promise.allSettled([
first.startTurn({
sessionId: fixture.sessionId,
turnId: turnIds[0],
text: FAKE_ASK_USER_QUESTION_PROMPT,
}),
second.startTurn({
sessionId: fixture.sessionId,
turnId: turnIds[1],
text: FAKE_ASK_USER_QUESTION_PROMPT,
}),
]);
const winners = outcomes.filter(
(outcome): outcome is PromiseFulfilledResult<TurnSnapshot> => outcome.status === 'fulfilled',
);
const rejected = outcomes.filter(
(outcome): outcome is PromiseRejectedResult => outcome.status === 'rejected',
);
assert.equal(winners.length, 1);
assert.equal(rejected.length, 1);
assert.ok(rejected[0]?.reason instanceof RuntimeHostOperationError);
assert.equal(rejected[0]?.reason.code, 'session_busy');

const winner = winners[0]?.value;
assert.ok(winner);
await first.stopTurn({
sessionId: fixture.sessionId,
turnId: winner.turnId,
runId: winner.runId,
});
await first.close();
await second.close();
await fixture.stopHost(host);

const chain = await fixture.readAdmissionChain();
assert.equal(chain.length, 1);
assert.equal(chain[0]?.turnId, winner.turnId);
assert.equal(chain[0]?.previousRootTurnId, null);
});
});

test('an archived Session rejects a new Turn before durable admission', async () => {
await withExecutionRoot(async (fixture) => {
await fixture.archiveSession();
Expand DownExpand Up@@ -472,12 +520,34 @@ test('retry after a discarded turn.start response reuses the durable semantic ad
const terminal = await waitForTerminalTurn(observer, fixture.sessionId, turnId);
assert.equal(terminal.status, 'completed');
await observer.close();
await fixture.stopHost(host);

await fixture.killHost(host);
const successorHost = await fixture.startHost();
const successorClient = await connectClient(fixture.root, 'run');
assert.deepEqual(
await successorClient.startTurn({ sessionId: fixture.sessionId, turnId, text }),
terminal,
);
const successorTurnId = randomUUID();
await successorClient.startTurn({
sessionId: fixture.sessionId,
turnId: successorTurnId,
text: 'successor must extend the recovered durable tip',
});
await waitForTerminalTurn(successorClient, fixture.sessionId, successorTurnId);
await successorClient.close();
await fixture.stopHost(successorHost);

const ledger = await fixture.readTurn(turnId);
assert.equal(ledger.runs.length, 1);
assert.equal(ledger.userMessages.length, 1);
assert.equal(ledger.terminalEvents.length, 1);
const chain = await fixture.readAdmissionChain();
assert.deepEqual(
chain.map((admission) => admission.turnId),
[turnId, successorTurnId],
);
assert.equal(chain[1]?.previousRootTurnId, turnId);
});
});

Expand DownExpand Up@@ -555,6 +625,7 @@ class ExecutionFixture {
turnId,
proposedRunId: randomUUID(),
proposedUserMessageId: randomUUID(),
previousRootTurnId: null,
normalizedInput: { text },
admittedAt,
});
Expand DownExpand Up@@ -665,6 +736,18 @@ class ExecutionFixture {
}
}

async readAdmissionChain() {
const owner = await tryAcquireInteractiveRootOwner(this.capability);
assert.ok(owner);
if (!owner) throw new Error('Unable to acquire execution root for admission inspection');
try {
const stores = await openInteractiveExecutionStoresForWrite(owner.lease);
return stores.agentRunStore.listRootTurnAdmissionsForRecovery(this.sessionId);
} finally {
await owner.close();
}
}

async readTurnFootprint(turnId: string): Promise<{
admitted: boolean;
runCount: number;
Expand Down
82 changes: 82 additions & 0 deletions packages/runtime-host/src/__tests__/host-kernel.test.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -102,6 +102,88 @@ describe('non-serving Runtime Host kernel', () => {
});
});

test('serves bootstrap operations during recovery and rejects ready-only operations', async () => {
await withHostPaths(async (paths) => {
const capability = await resolveStorageRoot({ path: paths.root, kind: 'interactive' });
const owner = await tryAcquireInteractiveRootOwner(capability);
assert.ok(owner);
let releaseFactory = () => {};
let markFactoryEntered!: () => void;
const factoryEntered = new Promise<void>((resolve) => {
markFactoryEntered = resolve;
});
const factoryReleased = new Promise<void>((resolve) => {
releaseFactory = resolve;
});
const unavailable = async () =>
({
ok: false,
error: {
code: 'operation_unavailable',
message: 'not available in this composition',
},
}) as const;
const hostTask = RuntimeHostKernel.start({
owner,
idleGraceMs: 10_000,
compositionFactory: async () => {
markFactoryEntered();
await factoryReleased;
return {
handlers: {
'turn.start': unavailable,
'turn.query': unavailable,
'turn.stop': unavailable,
},
async recover() {},
async close() {},
};
},
});
let host: RuntimeHostKernel | undefined;
let transport: FramedTransport | undefined;
try {
await withTimeout(factoryEntered, 1_000, 'Runtime Host did not enter composition');
const registration = await readHostRegistration(owner.controlDirectory);
assert.ok(registration);
assert.equal(registration.state, 'recovering');
transport = new FramedTransport(await openSocket(registration.endpoint));
await transport.write({
kind: 'hello',
clientInstanceId: 'lifecycle-test',
surface: 'inspect',
protocolMin: CURRENT_PROTOCOL.min,
protocolMax: CURRENT_PROTOCOL.max,
});
const handshake = decodeHostFrame(await transport.read(1_000));
assert.ok('kind' in handshake && handshake.kind === 'accepted');

await transport.write({ requestId: 'status', operation: 'host.status', input: {} });
const status = decodeHostFrame(await transport.read(1_000));
assert.ok(!('kind' in status) && status.operation === 'host.status' && status.ok);
if (!('kind' in status) && status.operation === 'host.status' && status.ok) {
assert.equal(status.result.state, 'recovering');
}

await transport.write({
requestId: 'query',
operation: 'turn.query',
input: { sessionId: 'session', turnId: 'turn' },
});
const query = decodeHostFrame(await transport.read(1_000));
assert.ok(!('kind' in query) && query.operation === 'turn.query' && !query.ok);
if (!('kind' in query) && query.operation === 'turn.query' && !query.ok) {
assert.equal(query.error.code, 'host_not_ready');
}
} finally {
releaseFactory();
transport?.destroy();
host = await hostTask.catch(() => undefined);
await host?.close().catch(() => undefined);
}
});
});

test('blocks incompatible replacement while resident and permits it only after true idle', async () => {
await withHostPaths(async (paths) => {
const candidate = await startTestRuntimeHostCandidate(paths, {
Expand Down
150 changes: 150 additions & 0 deletions packages/runtime-host/src/__tests__/operation-dispatcher.test.ts
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,150 @@
import assert from 'node:assert/strict';
import { describe, test } from 'node:test';
import type { OperationKey, OperationOutcome, RequestFrame } from '../protocol/index.js';
import {
composeOperationHandlers,
dispatchOperation,
type ConnectionContext,
type OperationHandlerMap,
} from '../server/operation-dispatcher.js';

const context: ConnectionContext = {
hostEpoch: 'epoch-1',
connectionId: 'connection-1',
surface: 'tui',
principal: 'local_os_user',
acquireResidency: () => ({ release() {} }),
};

const request = {
requestId: 'request-1',
operation: 'turn.query',
input: { sessionId: 'session-1', turnId: 'turn-1' },
} satisfies RequestFrame;

describe('Runtime Host operation dispatcher', () => {
test('rejects malformed handler composition', () => {
const handlers = validHandlers();
assert.throws(
() =>
composeOperationHandlers({
...handlers,
'unknown.operation': handlers['host.status'],
} as unknown as Partial<OperationHandlerMap>),
/Unknown Runtime Host operation handler: unknown\.operation/,
);
assert.throws(
() => composeOperationHandlers(handlers, { 'host.status': handlers['host.status'] }),
/Duplicate Runtime Host operation handler: host\.status/,
);
assert.throws(
() => composeOperationHandlers({ 'host.status': handlers['host.status'] }),
/Missing Runtime Host operation handlers:/,
);
assert.throws(
() =>
composeOperationHandlers({
...handlers,
'turn.query': undefined,
} as unknown as Partial<OperationHandlerMap>),
/Invalid Runtime Host operation handler: turn\.query/,
);
});

test('converts handler throws and malformed outcomes to declared internal_failure', async () => {
const malformedOutcomes: unknown[] = [
{ ok: true, result: { sessionId: 'session-1', turnId: 'turn-1' } },
{
ok: true,
result: runningSnapshot(),
privateState: true,
},
{ ok: false, error: { code: 'session_busy', message: 'not declared for query' } },
{ ok: false, error: { code: 'not_found', message: 'missing', details: {} } },
{ ok: false, error: 'missing' },
];

for (const outcome of malformedOutcomes) {
const response = await dispatchOperation(
request,
handlersWithQuery(async () => outcome as OperationOutcome<'turn.query'>),
context,
);
assert.deepEqual(response, internalFailure());
}

const thrown = await dispatchOperation(
request,
handlersWithQuery(async () => {
throw new Error('private failure');
}),
context,
);
assert.deepEqual(thrown, internalFailure());
});

test('passes only decoded valid success and declared exact failure outcomes', async () => {
const success = await dispatchOperation(
request,
handlersWithQuery(async () => ({ ok: true, result: runningSnapshot() })),
context,
);
assert.deepEqual(success, { ...requestIdentity(), ok: true, result: runningSnapshot() });

const failure = await dispatchOperation(
request,
handlersWithQuery(async () => ({
ok: false,
error: { code: 'not_found', message: 'Turn does not exist' },
})),
context,
);
assert.deepEqual(failure, {
...requestIdentity(),
ok: false,
error: { code: 'not_found', message: 'Turn does not exist' },
});
});
});

function validHandlers(): OperationHandlerMap {
const unavailable = async <K extends OperationKey>(): Promise<OperationOutcome<K>> =>
({
ok: false,
error: {
code: 'internal_failure',
message: 'not used',
},
}) as OperationOutcome<K>;
return {
'host.status': unavailable,
'turn.start': unavailable,
'turn.query': unavailable,
'turn.stop': unavailable,
};
}

function handlersWithQuery(query: OperationHandlerMap['turn.query']): OperationHandlerMap {
return { ...validHandlers(), 'turn.query': query };
}

function runningSnapshot() {
return {
sessionId: 'session-1',
turnId: 'turn-1',
runId: 'run-1',
status: 'running' as const,
};
}

function requestIdentity() {
return { requestId: request.requestId, operation: request.operation };
}

function internalFailure() {
return {
...requestIdentity(),
ok: false,
error: { code: 'internal_failure', message: 'Runtime Host operation failed' },
};
}
Loading
Loading