Uh oh!
There was an error while loading. Please reload this page.
PR-SETTINGS-NO-PANE-BORDER-0: pane seam removed + cards regrouped + 设置 brand dropped - #141
Merged
Merged
Conversation
…ed + 设置 brand dropped Three corrections, one PR (WAWQAQ msgs aabfa2b8 / 8effe691 / d0e7dfb3): 1. **Pane seam removed** — `.settingsMainPane` was a separate floating plate (border + tinted bg + corner radius + margin gap from sidebar). Reference's Settings has NO seam between sidebar and content — they share one continuous canvas. Drop pane border, margin, radius, explicit background. Right pane now flows into the sidebar surface. 2. **设置 sidebar brand removed + back button restyled** — reference sidebar has only `← 返回应用` then straight into the nav, no big "设置" header. Match it: deleted the header, switched the back icon from `ChevronLeft` to `ArrowLeft` (size 16, weight 1.85) so it reads as a proper "back to app" affordance. 3. **Card-in-card fix** — `.settingsStructuredPage` was a card AND it contained `<SettingsRows>` cards AND orphan `.settingsFormRow` children. Result: 隐身模式 floated alone with no chrome, then a card with 启动 etc., then 代理服务器 floated alone. Visually broken. Reference shows multiple GROUPED cards stacked vertically. New shape: `.settingsStructuredPage` is just a `display: grid; gap: 16px` container (NOT a card). `.settingsRows` is the only card primitive. Wrapped 隐身模式 in its own `<SettingsRows>`; wrapped `<NetworkProxySection>` in its own `<SettingsRows>`. Three logically distinct cards now stack vertically, matching reference's grouped-card pattern. 1466 / 1466 tests pass.
This was referenced Aug 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Three reference-alignment fixes batched into one PR:
Pane seam removed (WAWQAQ msg `aabfa2b8`) — `.settingsMainPane` was rendering as a separate floating plate (border + tinted bg + corner radius). Reference has no seam between sidebar and content. Dropped pane chrome; surfaces share one canvas.
设置 brand dropped + back button restyled (`8effe691`) — reference sidebar starts with `← 返回应用` then straight into the nav. Removed the "设置" header. Switched icon `ChevronLeft` → `ArrowLeft` size 16.
Card-in-card fix (`d0e7dfb3`) — `.settingsStructuredPage` was both a card AND a container of nested cards + orphan rows. Visually broken: rows like 隐身模式 floated chromeless, while 启动/新对话/默认 sat in a card, then 代理服务器 floated again. New shape: `.settingsStructuredPage` is just a grid with 16px gap, `.settingsRows` is the only card primitive. Each logical group wraps in ``. Now three grouped cards stack vertically per reference.
Test plan